From patchwork Wed Jun 14 07:33:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wangyijing X-Patchwork-Id: 105457 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp164884qgd; Wed, 14 Jun 2017 00:31:39 -0700 (PDT) X-Received: by 10.98.111.194 with SMTP id k185mr2784605pfc.13.1497425499693; Wed, 14 Jun 2017 00:31:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497425499; cv=none; d=google.com; s=arc-20160816; b=QmPaD6ntTXHIa4UFNWxl6Xk5Lj1sPKf/YkdWMfnqdSHv5ol/MTSmFhWw9aU//Qzv3w DstMipe8wwrW/pyh3YVl+LuA80o50cj8QyI0yWg/JKg/QHH65vdj8kIlCaOrfxClmiaH u+t1/qLNc3/abya1NpfAIRRD0cxXWukAd6opIsV8haKjvmI2Wg6Vr5zoNLikcyF25FbY UqSrBraNGE5iIyIc6Oee0KW1g/f+DghmJjZIw3stUVmiwG4Lw6+/UPQjB0x1bm5zV5wK webbCxvoy1Or3f+TyMBLz5nYoQvlY4l9ywG9uUgaobj4M9FNLfehJ+sXzv1TKZ2b8yfw bvVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=dMI7XJkJtiBj5MNj/GtYXxwF+4oRQDLkaBOzPXVJ+f0=; b=suSio21XPcW5KH44we0pOCrVm33fYHIPJwDjT66+/1z5KnYYq6FgEUsICgOGRa2fJz RJYugGlrpHjD4B4NrCTD3rBatozGOO5TRBpZqfvLKu/hZ0nO5RblDv6GWC8dXQdclqOu nn/H/JaLW+Au4Qc3NXvN3YhpMywyzXYY4MdCH60pDZqoBtsBNerfC4b23HyNKJpa/sUi jTpAN1cuNW+7VclhDPgOICMKVCzDHFhAsWdliwxJdNPAHHmH65421ZoHCGq+1UpM/Ojj 8G8HLyy6zcHugH25LI3L+sCS4nJiIcu24c3uqCODuBUVTAFns91ePvuhtQpdA0TBKXg1 Fp9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s82si67747pfd.374.2017.06.14.00.31.39; Wed, 14 Jun 2017 00:31:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754448AbdFNHbR (ORCPT + 25 others); Wed, 14 Jun 2017 03:31:17 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:8284 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754424AbdFNHbP (ORCPT ); Wed, 14 Jun 2017 03:31:15 -0400 Received: from 172.30.72.57 (EHLO DGGEML403-HUB.china.huawei.com) ([172.30.72.57]) by dggrg01-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id AQH04226; Wed, 14 Jun 2017 15:30:45 +0800 (CST) Received: from 138.huawei.com (10.175.124.28) by DGGEML403-HUB.china.huawei.com (10.3.17.33) with Microsoft SMTP Server id 14.3.301.0; Wed, 14 Jun 2017 15:30:29 +0800 From: Yijing Wang To: , CC: , , , , , , , , , , , , , , , , , , Yijing Wang Subject: [PATCH v2 0/2] Enhance libsas hotplug feature Date: Wed, 14 Jun 2017 15:33:15 +0800 Message-ID: <1497425597-18799-1-git-send-email-wangyijing@huawei.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.5940E626.0064, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 4206d09490a9f92f1132c0919662adc8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now the libsas hotplug has some issues, Dan Williams report a similar bug here before https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg39187.html The issues we have found 1. if LLDD burst reports lots of phy-up/phy-down sas events, some events may lost because a same sas events is pending now, finally libsas topo may different the hardware. 2. receive a phy down sas event, libsas call sas_deform_port to remove devices, it would first delete the sas port, then put a destruction discovery event in a new work, and queue it at the tail of workqueue, once the sas port be deleted, its children device will be deleted too, when the destruction work start, it will found the target device has been removed, and report a sysfs warnning. 3. since a hotplug process will be devided into several works, if a phy up sas event insert into phydown works, like destruction work ---> PORTE_BYTES_DMAED (sas_form_port) ---->PHYE_LOSS_OF_SIGNAL the hot remove flow would broken by PORTE_BYTES_DMAED event, it's not we expected, and issues would occur. The first patch fix the sas events lost, and the second one introudce wait-complete to fix the hotplug order issues. v1->v2: some code improvements suggested by John Garry Yijing Wang (2): libsas: Don't process sas events in static works libsas: Enhance libsas hotplug drivers/scsi/libsas/sas_discover.c | 58 +++++++++++++++++------- drivers/scsi/libsas/sas_event.c | 90 ++++++++++++++++++++++++++------------ drivers/scsi/libsas/sas_expander.c | 9 +++- drivers/scsi/libsas/sas_init.c | 29 +++++++++--- drivers/scsi/libsas/sas_internal.h | 64 +++++++++++++++++++++++++++ drivers/scsi/libsas/sas_phy.c | 45 ++++--------------- drivers/scsi/libsas/sas_port.c | 22 +++++----- include/scsi/libsas.h | 19 ++++---- 8 files changed, 232 insertions(+), 104 deletions(-) -- 2.5.0