[v6,0/5] clk: Add Aspeed clock driver

This driver supports the ast2500, ast2400 (and derivative) BMC SoCs from
Aspeed.

This is v6. See patches for detailed changelogs.

v6: Added reviewed-bys 
v5: Address review from Andrew
v4: Address review from Andrew and Stephen. 
v3: Address review from Andrew and has seen more testing on hardware
v2: split the driver out into a series of patches to make them easier to
review.

All of the important clocks are supported, with most non-essential ones
also implemented where information is available. I am working with
Aspeed to clear up some of the missing information, including the
missing parent-sibling relationships.

We need to know the rate of the apb clock in order to correctly program
the clocksource driver, so the apb and it's parents are created in the
CLK_OF_DECLARE_DRIVER callback.

The rest of the clocks are created at normal driver probe time. I
followed the Gemini driver's lead with using the regmap where I could,
but also having a pointer to the base address for use with the common
clock callbacks.

The driver borrows from the clk_gate common clock infrastructure, but modifies
it in order to support the clock gate and reset pair that most of the clocks
have. This pair must be reset-ungated-released, with appropriate delays,
according to the datasheet.

The first patch introduces the core clock registration parts, and describes
the clocks. The second creates the core clocks, giving the system enough to
boot (but without uart). Next come the non-core clocks, and finally the reset
controller that is used for the few cocks that don't have a gate to go with their
reset pair.

Please review!

Cheers,

Joel

Joel Stanley (5):
  clk: Add clock driver for ASPEED BMC SoCs
  clk: aspeed: Register core clocks
  clk: aspeed: Add platform driver and register PLLs
  clk: aspeed: Register gated clocks
  clk: aspeed: Add reset controller

 drivers/clk/Kconfig                      |  12 +
 drivers/clk/Makefile                     |   1 +
 drivers/clk/clk-aspeed.c                 | 657 +++++++++++++++++++++++++++++++
 include/dt-bindings/clock/aspeed-clock.h |  54 +++
 4 files changed, 724 insertions(+)
 create mode 100644 drivers/clk/clk-aspeed.c
 create mode 100644 include/dt-bindings/clock/aspeed-clock.h

-- 
2.14.1

Hello clk maintainers,

Has anyone had a chance to review these patches?

On Tue, Nov 28, 2017 at 5:49 PM, Joel Stanley <joel@jms.id.au> wrote:
> This driver supports the ast2500, ast2400 (and derivative) BMC SoCs from

> Aspeed.

>

> This is v6. See patches for detailed changelogs.

>

> v6: Added reviewed-bys

> v5: Address review from Andrew

> v4: Address review from Andrew and Stephen.

> v3: Address review from Andrew and has seen more testing on hardware

> v2: split the driver out into a series of patches to make them easier to

> review.

>

> All of the important clocks are supported, with most non-essential ones

> also implemented where information is available. I am working with

> Aspeed to clear up some of the missing information, including the

> missing parent-sibling relationships.

>

> We need to know the rate of the apb clock in order to correctly program

> the clocksource driver, so the apb and it's parents are created in the

> CLK_OF_DECLARE_DRIVER callback.

>

> The rest of the clocks are created at normal driver probe time. I

> followed the Gemini driver's lead with using the regmap where I could,

> but also having a pointer to the base address for use with the common

> clock callbacks.

>

> The driver borrows from the clk_gate common clock infrastructure, but modifies

> it in order to support the clock gate and reset pair that most of the clocks

> have. This pair must be reset-ungated-released, with appropriate delays,

> according to the datasheet.

>

> The first patch introduces the core clock registration parts, and describes

> the clocks. The second creates the core clocks, giving the system enough to

> boot (but without uart). Next come the non-core clocks, and finally the reset

> controller that is used for the few cocks that don't have a gate to go with their

> reset pair.

>

> Please review!

>

> Cheers,

>

> Joel

>

> Joel Stanley (5):

>   clk: Add clock driver for ASPEED BMC SoCs

>   clk: aspeed: Register core clocks

>   clk: aspeed: Add platform driver and register PLLs

>   clk: aspeed: Register gated clocks

>   clk: aspeed: Add reset controller

>

>  drivers/clk/Kconfig                      |  12 +

>  drivers/clk/Makefile                     |   1 +

>  drivers/clk/clk-aspeed.c                 | 657 +++++++++++++++++++++++++++++++

>  include/dt-bindings/clock/aspeed-clock.h |  54 +++

>  4 files changed, 724 insertions(+)

>  create mode 100644 drivers/clk/clk-aspeed.c

>  create mode 100644 include/dt-bindings/clock/aspeed-clock.h

>

> --

> 2.14.1

>

On 12/06, Joel Stanley wrote:
> Hello clk maintainers,

> 

> Has anyone had a chance to review these patches?

> 


Besides the sleeping call that should be a delay it looks OK.
Send v7?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

On Fri, Dec 22, 2017 at 10:10 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 12/06, Joel Stanley wrote:

>> Hello clk maintainers,

>>

>> Has anyone had a chance to review these patches?

>>

>

> Besides the sleeping call that should be a delay it looks OK.

> Send v7?


Thanks for taking a look. I'll fix the sleep call and send it out now.

Cheers,

Joel