mbox series

[v2,0/8] Remoteproc cleanups

Message ID 20180105235805.9948-1-bjorn.andersson@linaro.org
Headers show
Series Remoteproc cleanups | expand

Message

Bjorn Andersson Jan. 5, 2018, 11:57 p.m. UTC
The first patch removes code that became unnecessary when the recovery flow was
redesigned.

The following patches moves the assignment of cached_table to the resource
table loader, rather than core code, which allows this to made optional and
finally drops the various dummy resource tables provided by drivers.

Then finally the last patch ensures that table_ptr isn't left pointing into
memory of a stopped remoteproc.

Bjorn Andersson (8):
  remoteproc: Remove depricated crash completion
  remoteproc: Cache resource table size
  remoteproc: Clone rproc_ops in rproc_alloc()
  remoteproc: Merge rproc_ops and rproc_fw_ops
  remoteproc: Don't handle empty resource table
  remoteproc: Move resource table load logic to find
  remoteproc: Drop dangling find_rsc_table dummies
  remoteproc: Reset table_ptr on stop

 drivers/remoteproc/qcom_adsp_pil.c         |  8 +--
 drivers/remoteproc/qcom_common.c           | 19 -------
 drivers/remoteproc/qcom_common.h           |  4 --
 drivers/remoteproc/qcom_q6v5_pil.c         | 18 +------
 drivers/remoteproc/qcom_wcnss.c            |  8 +--
 drivers/remoteproc/remoteproc_core.c       | 83 ++++++++++++------------------
 drivers/remoteproc/remoteproc_elf_loader.c | 59 ++++++++++-----------
 drivers/remoteproc/remoteproc_internal.h   | 57 +++++++-------------
 drivers/remoteproc/st_slim_rproc.c         | 32 ++----------
 include/linux/remoteproc.h                 | 21 ++++++--
 10 files changed, 106 insertions(+), 203 deletions(-)

-- 
2.15.0

Comments

Loic Pallardy Jan. 15, 2018, 10:35 a.m. UTC | #1
> -----Original Message-----

> From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org]

> Sent: Saturday, January 06, 2018 12:58 AM

> To: Ohad Ben-Cohen <ohad@wizery.com>; Bjorn Andersson

> <bjorn.andersson@linaro.org>

> Cc: linux-remoteproc@vger.kernel.org; linux-kernel@vger.kernel.org; Loic

> PALLARDY <loic.pallardy@st.com>

> Subject: [PATCH v2 0/8] Remoteproc cleanups

> 

> The first patch removes code that became unnecessary when the recovery

> flow was

> redesigned.

> 

> The following patches moves the assignment of cached_table to the

> resource

> table loader, rather than core code, which allows this to made optional and

> finally drops the various dummy resource tables provided by drivers.

> 

> Then finally the last patch ensures that table_ptr isn't left pointing into

> memory of a stopped remoteproc.


I have tested this series on B2260 96Board for st-slim remote processor support.

Reviewed-By: Loic Pallardy <loic.pallardy@st.com>

Tested-By: Loic Pallardy <loic.pallardy@st.com>


Regards,
Loic
> 

> Bjorn Andersson (8):

>   remoteproc: Remove depricated crash completion

>   remoteproc: Cache resource table size

>   remoteproc: Clone rproc_ops in rproc_alloc()

>   remoteproc: Merge rproc_ops and rproc_fw_ops

>   remoteproc: Don't handle empty resource table

>   remoteproc: Move resource table load logic to find

>   remoteproc: Drop dangling find_rsc_table dummies

>   remoteproc: Reset table_ptr on stop

> 

>  drivers/remoteproc/qcom_adsp_pil.c         |  8 +--

>  drivers/remoteproc/qcom_common.c           | 19 -------

>  drivers/remoteproc/qcom_common.h           |  4 --

>  drivers/remoteproc/qcom_q6v5_pil.c         | 18 +------

>  drivers/remoteproc/qcom_wcnss.c            |  8 +--

>  drivers/remoteproc/remoteproc_core.c       | 83 ++++++++++++---------------

> ---

>  drivers/remoteproc/remoteproc_elf_loader.c | 59 ++++++++++-----------

>  drivers/remoteproc/remoteproc_internal.h   | 57 +++++++-------------

>  drivers/remoteproc/st_slim_rproc.c         | 32 ++----------

>  include/linux/remoteproc.h                 | 21 ++++++--

>  10 files changed, 106 insertions(+), 203 deletions(-)

> 

> --

> 2.15.0
Bjorn Andersson Jan. 15, 2018, 5:30 p.m. UTC | #2
On Mon 15 Jan 02:35 PST 2018, Loic PALLARDY wrote:

> 

> 

> > -----Original Message-----

> > From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org]

> > Sent: Saturday, January 06, 2018 12:58 AM

> > To: Ohad Ben-Cohen <ohad@wizery.com>; Bjorn Andersson

> > <bjorn.andersson@linaro.org>

> > Cc: linux-remoteproc@vger.kernel.org; linux-kernel@vger.kernel.org; Loic

> > PALLARDY <loic.pallardy@st.com>

> > Subject: [PATCH v2 0/8] Remoteproc cleanups

> > 

> > The first patch removes code that became unnecessary when the recovery

> > flow was

> > redesigned.

> > 

> > The following patches moves the assignment of cached_table to the

> > resource

> > table loader, rather than core code, which allows this to made optional and

> > finally drops the various dummy resource tables provided by drivers.

> > 

> > Then finally the last patch ensures that table_ptr isn't left pointing into

> > memory of a stopped remoteproc.

> 

> I have tested this series on B2260 96Board for st-slim remote processor support.

> 

> Reviewed-By: Loic Pallardy <loic.pallardy@st.com>

> Tested-By: Loic Pallardy <loic.pallardy@st.com>

> 


Thanks Loic, very much appreciate you looking into this!

Regards,
Bjorn