From patchwork Mon Feb 5 19:05:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 126921 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp2234716ljc; Mon, 5 Feb 2018 11:05:41 -0800 (PST) X-Google-Smtp-Source: AH8x225YY5Qy4A8urtg+HXe6Eej/Fdq7yLKjh8BgIfVMIZMsDgk2uq4+Hx62l+RbtO6mwKwzOaHA X-Received: by 2002:a17:902:722:: with SMTP id 31-v6mr19830592pli.331.1517857541534; Mon, 05 Feb 2018 11:05:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517857541; cv=none; d=google.com; s=arc-20160816; b=jnwrm6ZN+0KcRRSWV/WSx0sOf+ifQR7YZ4ttHq1u7BlVy3jZO1exdiQQVhIo4cGLIz MhxC4byZ3khhE4ctqBkBpFOvE4rwbMV6PrltuCTGxydlX842XAzFtnhwFTOjx7slFRqx jUJKBEVJi8ZkiyVwGDgVl2jknDb0pqm/PPvU1Dah1Xl+Qo0YFY2vb3HQ/LKsQTSdZfDx QYZ/WagpYlzDIfzyKByjt+Ov9+MXFR7kT+FnPHa52Ag6L5bvS3rgO0e2KX/EvW1szz1h u331xCHxKpXCpw0zjFxlXupZxYFoCix+7ko5qt6oq8kkSiqCIsK6w+ALdTPM+v5hh/hr Kj1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=5OR+U7o9zyeFqgGDen57iBeWEI1bsTjGqXpiilpUfr4=; b=ZigqFRVpr4hRliE7j8oQGoSr4Uokci+dtL70i+T2PsZyiJ66gTfR63e3rmSUvS0jBQ 5SsouYijrfXqKXs9JE0c8QFmHeezQONggLJf5uIg1mUJ2L9+Sz+neiQVFfrcPgk7Mzbm UnyQcqq7wp4u8hInnkWkxXhUcbvP0EVDejCkeVoSEW6AtSvz+/2Y/Pt/fo9GxHBjpki6 s/c+mQ74l5tN4fKbWHFvV+woTk4bKpW0sbyMHu46+ehtzH3f0byhL/nEYmNYIemo6n2a BdLQeWGpwQ7b/fimMNwYbDSBC2dzXrkO2dQP4hUwBUx0j/kVHPCEP0TovjL7v7SezdTk zJgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X5SIHDKH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2-v6si7268369plc.784.2018.02.05.11.05.41; Mon, 05 Feb 2018 11:05:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X5SIHDKH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685AbeBETFi (ORCPT + 27 others); Mon, 5 Feb 2018 14:05:38 -0500 Received: from mail-wr0-f175.google.com ([209.85.128.175]:44987 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753599AbeBETF0 (ORCPT ); Mon, 5 Feb 2018 14:05:26 -0500 Received: by mail-wr0-f175.google.com with SMTP id v31so30754111wrc.11 for ; Mon, 05 Feb 2018 11:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=5OR+U7o9zyeFqgGDen57iBeWEI1bsTjGqXpiilpUfr4=; b=X5SIHDKHXP/sU9OM5V7BV8OJgtaphzwP5Oq4xpZoLHvsArcvjkU6LHkUqLEgxP0soz WBYcJ4FHfQ5SaW/2d+PPfV3AgyTPEqp9YapCqxjJh7lVsltmQrO3W4vXzLpdSm58yjVD ymcqTbF0FPAJZzwAhD2Za4KLl9IYq5AcX9YRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5OR+U7o9zyeFqgGDen57iBeWEI1bsTjGqXpiilpUfr4=; b=aqF8cD7D8kG9YnmbyZgOmlQbyTSxIZ85b72BJbw7370TPB/3vepHCklaZRzg8GBBDt XZnDgQiH8BoI5c3DJXYSb5kgR3uQuiwyBKyyQW21sNad7OMijUIaRXV+r3yffbvpTdcf igAmdyGjRJNpO22o2ef0IOqqPumjoihfuxV1tL8s1+J/UvqIsgGXzCCivKnxOmv3CAGM SgWHHZAxx5ezUhdvR4FkgA0tzRV7McqZqNux86gEvaVFJSk9mpVN8Obx1qFJrJq7iVhu xlM3+ud2C7WatAuc43/uAs7QX/I1nfsd+8mkbPnSQVzIuQlQNaWPzM2aeEIrl3TxA28J wXyQ== X-Gm-Message-State: AKwxytdeDgUgMx+LqIgt4N12OdWMl+fxBIbkS5kct0+g4qQd1NYfC2fn oH2Ism/iMqEn9+87GIuLzG7lDQ== X-Received: by 10.223.177.193 with SMTP id r1mr25975632wra.232.1517857525185; Mon, 05 Feb 2018 11:05:25 -0800 (PST) Received: from localhost.localdomain (146-241-18-147.dyn.eolo.it. [146.241.18.147]) by smtp.gmail.com with ESMTPSA id h200sm4539004wme.11.2018.02.05.11.05.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 11:05:23 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, alban.browaeys@gmail.com, ming.lei@redhat.com, ivan@ludios.org, 169364@studenti.unimore.it, Paolo Valente Subject: [PATCH BUGFIX 0/1] block, bfq: handle requeues of I/O requests Date: Mon, 5 Feb 2018 20:05:09 +0100 Message-Id: <20180205190510.5499-1-paolo.valente@linaro.org> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, just a note: the most difficult part in the implementation of this patch has been how to handle the fact that the requeue and finish hooks of the active elevator get invoked even for requests that are not referred in that elevator any longer. You can find details in the comments introduced by the patch. This note is just to point out this unexpected fact (for me), in case it is not intentional. Thanks, Paolo Paolo Valente (1): block, bfq: add requeue-request hook block/bfq-iosched.c | 101 +++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 76 insertions(+), 25 deletions(-) -- 2.15.1