mbox series

[v3,0/2] ASoC: add es7241 support

Message ID 20180703132845.26554-1-jbrunet@baylibre.com
Headers show
Series ASoC: add es7241 support | expand

Message

Jerome Brunet July 3, 2018, 1:28 p.m. UTC 
Add support for the es7241 which is a simple 2 channels analog to
digital converter.

Changes since v1: [0]
 * Add missing break as reported by smatch [1]
   My device is hardwired in slave mode, which probably why this slipped
   through unnoticed.

Changes since v2: [2]
 * Supply are now required dt properties
 * Add a dt property to state the serial interface configuration

[0]: https://lkml.kernel.org/r/20180629152444.21525-1-jbrunet@baylibre.com
[1]: https://lkml.kernel.org/r/20180630082829.qwnhkk4f76n32omm@mwanda
[2]: https://lkml.kernel.org/r/20180630172241.10806-1-jbrunet@baylibre.com

Jerome Brunet (2):
  ASoC: es7241: add dt-bindings documentation for the es7241 adc
  ASoC: es7241: add es7241 codec support

 .../devicetree/bindings/sound/everest,es7241.txt   |  28 ++
 sound/soc/codecs/Kconfig                           |   4 +
 sound/soc/codecs/Makefile                          |   2 +
 sound/soc/codecs/es7241.c                          | 322 +++++++++++++++++++++
 4 files changed, 356 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/everest,es7241.txt
 create mode 100644 sound/soc/codecs/es7241.c

-- 
2.14.4

Comments

Mark Brown July 3, 2018, 3:32 p.m. UTC | #1 
On Tue, Jul 03, 2018 at 03:28:43PM +0200, Jerome Brunet wrote:
> Add support for the es7241 which is a simple 2 channels analog to

> digital converter.


Please don't resubmit patches that have already been applied, you should
submit patches against current code in the tree you're expecting things
to be applied to.  If any updates are needed to a patch that's already
been applied you should submit incremental patches which make those
updates.  This avoids having to change published git commits which could
cause problems for people working against git.
Jerome Brunet July 3, 2018, 3:36 p.m. UTC | #2 
On Tue, 2018-07-03 at 16:32 +0100, Mark Brown wrote:
> On Tue, Jul 03, 2018 at 03:28:43PM +0200, Jerome Brunet wrote:

> > Add support for the es7241 which is a simple 2 channels analog to

> > digital converter.

> 

> Please don't resubmit patches that have already been applied, you should

> submit patches against current code in the tree you're expecting things

> to be applied to.  If any updates are needed to a patch that's already

> been applied you should submit incremental patches which make those

> updates.  This avoids having to change published git commits which could

> cause problems for people working against git.


Unless I missed something, which entirely possible, I don't think any patches of
this series have been applied yet. You asked me resubmit after the v1 because of
 power supply bindings and the mode selection.

I don't see anything related to the es7241 in your tree ATM.
Jerome Brunet July 3, 2018, 3:59 p.m. UTC | #3 
On Tue, 2018-07-03 at 16:41 +0100, Mark Brown wrote:
> On Tue, Jul 03, 2018 at 05:36:19PM +0200, Jerome Brunet wrote:

> 

> > Unless I missed something, which entirely possible, I don't think any patches of

> > this series have been applied yet. You asked me resubmit after the v1 because of

> >  power supply bindings and the mode selection.

> > I don't see anything related to the es7241 in your tree ATM.

> 

> Oh, my mistake sorry - I must have copied it into my to apply queue

> twice so got a reject on the second application.


No worries. Just wanted to make sure.
Thanks !