From patchwork Fri Aug 31 20:51:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 145698 Delivered-To: patches@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp1217038ljw; Fri, 31 Aug 2018 13:52:29 -0700 (PDT) X-Received: by 2002:adf:9ab7:: with SMTP id a52-v6mr1841049wrc.75.1535748749375; Fri, 31 Aug 2018 13:52:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535748749; cv=none; d=google.com; s=arc-20160816; b=dHr1wShKcl131todhJ/0EK51J+aOKZA3dB16wD1LD6eNBlwRp+fwZyjKN6EirSv0wz 2wCva2eaLeUnQ3DhylRygmf6yC3TV/jHLSubu7QsIC8452ruFbRD9t3cMEopgugNEOxN oVH6TGjY1m70UFygXzBXHHFyrf93GDr13K/9DRQXpl+j90v9VChXHgxb805zZFJ2P+vB 4iD/COOUo/VougsekFAFzTpXy/JEuKt0I1ksNJ+WYE9sp8x4eavlN5up2qc4l+KF+HdA zWrXwlwucorbBz8oFEjg4+VEQrX2L6LDNAfgrdPx0z0/t9BszpyLjQt8CXxHuGXFb3z6 yRpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=xA7an3MtvPDHqyv/GmK4u4YNwImf+ORfvSp8ZP9m9CU=; b=ulCaqOI5TzFqBAMONpaxoUDkOzBx+B7wY8rccFnZP0JfTPefFzkxl0NWCHHgkDPRTY LCr3xZnk92A033SkFLiQxJ4fw616/uiok9B04v201hR9+igN0yNU5g5sqFL426DE19Vu T9vrjtNt+oi6rBxq/n8hWBCO31mah5WgATXmF/Pamb7kvkzPnv+C5L6vtz2zzDRHrXtZ cKcRrKgUFAPf44Pjwll7F3yBH3rmFmWUz80pyYaFCOtD7r9cN240qovjXkTWSXVdQqIX s76efnxrrbuPG8xc1IIs0Ju/v2GaqnTw/Xcibvn/CFtxja+5uX+QPxNKMFFg7uYZHqDG pYNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ieRmlfdr; spf=pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=daniel.thompson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id h13-v6sor7832788wrv.32.2018.08.31.13.52.29 for (Google Transport Security); Fri, 31 Aug 2018 13:52:29 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ieRmlfdr; spf=pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=daniel.thompson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=xA7an3MtvPDHqyv/GmK4u4YNwImf+ORfvSp8ZP9m9CU=; b=ieRmlfdrMXXHV9W4zShUk7QQaz6/vDGYOJkJKSEAfqiuLaM8yFUeZGTMS2wCUED/Oe MheQ6RWmWqAQCnRe2HKs8Rq2uBBIbeV6eXzHd8RSaHrGFM+qFdB7LBfp/CNS4DZrRVav rkcrBn+0YY+sDloPCHPAtqVgA9K1ZnOzLeDWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xA7an3MtvPDHqyv/GmK4u4YNwImf+ORfvSp8ZP9m9CU=; b=h7abIKxaxxAsh2INTYI05zK5hL0nSstQU4DIPBVJPSE0wyQqanC6snY7XXZeBmNF6i KXeQJ/7yNyNl5IjvkyeENvPM2N6/T4uhkjfkz+CvGWH8Sv6qJr8UrEUICmfOOmmRolIl x37pRqvQ1PuIQZD4PRQvGRepjp7PibTD9/W+3x2nUk0cpMbBOQXpYJ3ARZWhuOlqDtn5 qSeL8TcKm0Ajy5UAffkFGE25MtieqGU17rhwTqdqVGj78kh1PfUDtGT08IWJuu96lhje kQ9B9NE0q0RIuMmbUwwP5JgWIaGeEwQNLJ699kb9cHfSMu5tt0Iw8kFxYUVizknkMyOx K9Gg== X-Gm-Message-State: APzg51AeRP3l3DjUyztz1UfpPePHLWSlP9HLMxRlwy+aL7YnBMX6BOGR N82EdS8Dm5xQVC9YxNAzYTwE02KO X-Google-Smtp-Source: ANB0VdZmJ1LmMCj6aL1/6T+KPd+A3P3zZtSVvHhSjF523+H4PS2BxR4i13eGqmSJhNMnoMIiQhMvaw== X-Received: by 2002:a5d:608b:: with SMTP id w11-v6mr2037619wrt.193.1535748749046; Fri, 31 Aug 2018 13:52:29 -0700 (PDT) Return-Path: Received: from wychelm.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id u4-v6sm7659356wro.47.2018.08.31.13.52.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 13:52:28 -0700 (PDT) From: Daniel Thompson To: Jason Wessel Cc: Daniel Thompson , kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, patches@linaro.org Subject: [PATCH 0/5] kdb: Cleanup code to read user input and handle escape sequences Date: Fri, 31 Aug 2018 21:51:37 +0100 Message-Id: <20180831205142.23609-1-daniel.thompson@linaro.org> X-Mailer: git-send-email 2.17.1 I spend a little time earlier this month looking at kdb_read() and ended up doing a little light refactoring a bit to make easier to read. Most of the patches are simple tidy ups although patches 4 and 5 introduce new behaviours. Patch 4 is probably not controversial but perhaps patch 5 is ;-). Tested as shown here: https://github.com/daniel-thompson/kgdbtest/commit/c65e28d99357c2df6dac2cebe195574e634d04dc Daniel Thompson (5): kdb: Tidy up code to handle escape sequences kdb: Simplify code to fetch characters from console kdb: Remove special case logic from kdb_read() kdb: Improve handling of characters from different input sources kdb: Tweak escape handling for vi users kernel/debug/kdb/kdb_io.c | 218 +++++++++++++++++--------------------- 1 file changed, 99 insertions(+), 119 deletions(-) -- 2.17.1