From patchwork Tue Oct 26 08:31:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Wiklander X-Patchwork-Id: 516168 Delivered-To: patches@linaro.org Received: by 2002:ac0:c404:0:0:0:0:0 with SMTP id t4csp50543imj; Tue, 26 Oct 2021 01:31:44 -0700 (PDT) X-Received: by 2002:a05:651c:1541:: with SMTP id y1mr24733627ljp.392.1635237104556; Tue, 26 Oct 2021 01:31:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635237104; cv=none; d=google.com; s=arc-20160816; b=zRdwY5o2nJWHysnmlIN6lb2eWE4D1H1c7YB1w5IVCWsGLdoBZPspLIeajuDTCXahdD BjZY22mItb8gY40xurGqVPNUsddIrwz7XubRe9b3B3i1IsaXKtsvU+//PdYK5Tdh7efx PHyrFE6S0XD49iYD9wxx8zJo3qxhZa2mKfFYpBtBqaSgOrzUUHdYxY2bgTXRlAGxT+vm jsjItbRXt30+ICY9QRn3nODq8/ZRcZI+EyUDaoCLXdUg2X7tUL7LkOIObb5xkEsv6XVr XCh70ayVRVn+7DWv61ZfuRmTqJeWfMzhrxtq3VbbD+hLUdrNS4/KVplzRN5NSQXYbzy+ A8zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=hvjBpS0WQUpHH6xnR9S7oADkbGeXX564pPdc4gb5058=; b=qBFpSi+8LqDXfKYA/jEbG7NCFLuuEHMpf7cUz55bPQFsPdC/f8RJ/jF0Gj69A0ic5Z cJdRtHDV98+eRwujRIg5bZfrwgULbG50CAQoW9JfNPyK7vGzoxOpE/0Rwuqe/DqS1FeC jHfkiObMtqSP5bRhqRbu25GGrVsa9OppYWml9xYPPmNPIXkerPDAeR+tMmUYHOmeeBOr uaiuYMYtE7kwbYwTxmpcOuYyGQ+nPcF4XdckG76Tf3VIG0kNXc1lBU/DRy78f3cU84U+ WnxTjShaJkblTCR2dns/Ur1bKN6JBxV9rivjbggjl7hsHXsb3dXFBM/EAoAKAO1/fQ0H u4fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VZcjvQUL; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id o16sor9530055lji.27.2021.10.26.01.31.44 for (Google Transport Security); Tue, 26 Oct 2021 01:31:44 -0700 (PDT) Received-SPF: pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VZcjvQUL; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hvjBpS0WQUpHH6xnR9S7oADkbGeXX564pPdc4gb5058=; b=VZcjvQUL5lvIUQb7JbjlWotIYeRbEvfm5KDsiTM3mSpS4I5z/RcS3NbV75bZbHlTp7 LQcIJRuiLdhEklLz2y7Ca8kne37wZk5Ruqr9O+IePFhNMcaSi+9kdW4NDTTmcMeacCnR l9XQ+tFYGPMNyI9obP1G/xDghH4J4bgVe533MjaSFxH2XxPVItbqio9DpAhbzDfG61iP sgbPcY+WBijIyh8ymmeOjSAvNOMtaVSiXyFKy/y9uw/OpyRJiZ5rDQsTceQrnI4gMoDK 4H2fMckERh/J+BnK8QwmWie/zThPezP0IRy0Gn238hR1xAKPlWUm1cqA3NKGCmUjJ1fr cMvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hvjBpS0WQUpHH6xnR9S7oADkbGeXX564pPdc4gb5058=; b=4AW3gfRskuYugvrUnPv6Go09TRnCZYEo2hU20Z4swL368KlzNOMutLWNHAfDOF1c7m nGD3MQjnbCeHFWBB10s4BS9wR2duoy4hysR4nuFdNA/8l6K4Mu+zCcmi8B3a8Hq708TX 4mC63c8aouLiIMNkfB8u6qMNhN1L93IS7rBwWzao5xa+GG/m/h5mrr8qYc8w22QKRdDL AHbuITJUrBdI3DkRUeeWXT/MFcjVwOcoIg1OeW4E4MHFbKI9VYMaADggOWIBAlEtc2w9 CbW9ntyCKZH/iUv7xNDea2mAG/crpEGS3y+/8H+dDTI7xCsLRDc0k2sFtSkj61eQvX+I Y+pw== X-Gm-Message-State: AOAM530cNdqlReo1bJ1Ni7HhmHnjTYXJm0pJpKj7tV7MiAwZHG0eQCHG jQ+BQVNmhZXSLbRqU4lQv4I1uUok X-Google-Smtp-Source: ABdhPJzsA7vMWo/V630/oC1Bt0cC2WhkKii/4cRJucj3IpqEe90SIEX/iuuHl24z8jwZtEvJNccrHA== X-Received: by 2002:a05:651c:1506:: with SMTP id e6mr24696526ljf.129.1635237104122; Tue, 26 Oct 2021 01:31:44 -0700 (PDT) Return-Path: Received: from jade.urgonet (h-94-254-48-165.A175.priv.bahnhof.se. [94.254.48.165]) by smtp.gmail.com with ESMTPSA id e4sm1944598ljn.131.2021.10.26.01.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 01:31:43 -0700 (PDT) From: Jens Wiklander To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Cc: Jerome Forissier , Etienne Carriere , Sumit Garg , Vincent Guittot , Rob Herring , Jonathan Corbet , Ard Biesheuvel , Marc Zyngier , jens.vankeirsbilck@kuleuven.be, Jens Wiklander Subject: [PATCH v7 0/6] Asynchronous notifications from secure world Date: Tue, 26 Oct 2021 10:31:32 +0200 Message-Id: <20211026083138.1818705-1-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Hi all, This adds support for asynchronous notifications from OP-TEE in secure world to the OP-TEE driver. This allows a design with a top half and bottom half type of driver where the top half runs in secure interrupt context and a notifications tells normal world to schedule a yielding call to do the bottom half processing. An edge-triggered interrupt is used to notify the driver that there are asynchronous notifications pending. Only the SMC based ABI of the OP-TEE driver gains asynchronous notifications. Future support for asynchronous notifications in the FF-A based ABI will rely on APIs which are expected to be provided by the FF-A driver in a not too distant future. Most of the patches here are well reviewed, but the last patch "optee: add asynchronous notifications" could do with some more attention. This patchset is also available at https://git.linaro.org/people/jens.wiklander/linux-tee.git/log/?h=async_notif_v7 v6->v7: * Rebased on 4615e5a34b95 ("optee: add FF-A support") in https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git with 34f3c67b8178 ("optee: smc_abi.c: add missing #include ") cherry-picked on top. This allows to resolve the conflicts with pull request "[GIT PULL] OP-TEE FF-A for V5.16" * Factored out the interrupt handling added in "optee: add asynchronous notifications" to only go into smb_abi.c. A different approach is expected with FF-A once it has asynchronous notifications. * Addressed review comments from Sumit Garg: - Replaced 0 and 1 with the macros GIC_SPI and IRQ_TYPE_EDGE_RISING in the example in the bindings. - Replaced the magic number to optee_notif_init() with OPTEE_DEFAULT_MAX_NOTIF_VALUE in the commit "optee: separate notification functions" - Switched back to tagged error path in optee_probe() - Fixed a few nits in "optee: add asynchronous notifications" - Applied Sumit's Reviewed-by on all commits but the last, "optee: add asynchronous notifications" v5->v6: * Rebased on v5.15-rc2 * Replaced "tee: add tee_dev_open_helper() primitive" with "tee: export teedev_open() and teedev_close_context()" since it turned out that the normal teedev functions could be used instead as noted by Sumit. * Changed "optee: add asynchronous notifications" to use the exported teedev_open() and teedev_close_context() functions instead. v4->v5: * Rebased on v5.14-rc7 * Updated documentation to clarify that one interrupt may represent multiple notifications as requested. * Applied Marc's and Rob's tags v3->v4: * Clarfied the expected type of interrypt is edge-triggered, both in the normal documentation and in the DT bindings as requested. v2->v3: * Rebased on v5.14-rc2 which made the patch "dt-bindings: arm: Convert optee binding to json-schema" from the V2 patch set obsolete. * Applied Ard's Acked-by on "optee: add asynchronous notifications" v1->v2: * Added documentation * Converted optee bindings to json-schema and added interrupt property * Configure notification interrupt from DT instead of getting it from secure world, suggested by Ard Biesheuvel . Thanks, Jens Jens Wiklander (6): docs: staging/tee.rst: add a section on OP-TEE notifications dt-bindings: arm: optee: add interrupt property tee: fix put order in teedev_close_context() tee: export teedev_open() and teedev_close_context() optee: separate notification functions optee: add asynchronous notifications .../arm/firmware/linaro,optee-tz.yaml | 7 + Documentation/staging/tee.rst | 30 +++ drivers/tee/optee/Makefile | 1 + drivers/tee/optee/core.c | 2 +- drivers/tee/optee/ffa_abi.c | 6 +- drivers/tee/optee/notif.c | 125 +++++++++ drivers/tee/optee/optee_msg.h | 9 + drivers/tee/optee/optee_private.h | 28 ++- drivers/tee/optee/optee_rpc_cmd.h | 31 +-- drivers/tee/optee/optee_smc.h | 75 +++++- drivers/tee/optee/rpc.c | 71 +----- drivers/tee/optee/smc_abi.c | 238 +++++++++++++++--- drivers/tee/tee_core.c | 10 +- include/linux/tee_drv.h | 14 ++ 14 files changed, 522 insertions(+), 125 deletions(-) create mode 100644 drivers/tee/optee/notif.c -- 2.31.1