From patchwork Wed Nov 3 09:02:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Wiklander X-Patchwork-Id: 516724 Delivered-To: patches@linaro.org Received: by 2002:ad5:5208:0:0:0:0:0 with SMTP id p8csp392857iml; Wed, 3 Nov 2021 02:03:01 -0700 (PDT) X-Received: by 2002:a05:651c:626:: with SMTP id k38mr42299055lje.298.1635930181680; Wed, 03 Nov 2021 02:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635930181; cv=none; d=google.com; s=arc-20160816; b=bPpFD3aLFz9lGFCEg+LgEe/idWegKuZfzUmuMd3VDnHqbf8U7rhC9mPPy/dXDNCHj6 D9YHVe08YJAY3+f5m2s/UjZ41YjHwq5dtoRijX8FN/swmnRYBislap1j8vLCnK9UbWfN NvPWzXt5PEi83IIOO51XzXR1yr+bCrBYUTFlBmnfGBGvphgIob/hbiUMzql6bp/VzELD eibiaF0HTyd+AvWU17rFo2AuuVuqbeisQ0C9tRcCXNdROyyLtK8XnJB6MHTnpPObXXB6 lWpeQ94sloMn4y1Fh/0zPQxJ5QseASBXTtc2iGIcQyKpJPOaBnC/k1+KmHzC0pWQ8pbC hsDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=IOBd8zmaQ/o/1Os9BhWOC3FQNCJBCGeietUzMVOB0tg=; b=fiD8rQC5h89DCfARBBZiUnVBThLeNTwHxWtjuxUk7ypKaEWlDTvS4iU+SHbTdw6bpK iVnVwmyuUOAJJ9RZs3VwahSESMLEmJfN8D4lp1pSqiibtzOdVChlHhpqDmCruxCCmsSF lhiqtmW+R2OV26gaGor8uCcnRrdJg4hEANPMBdD06yc1U4RKF39WJ2xZkcVj/5j4UaBW 3SfGLHlQ2yhC8lFJKaQPJ4TN8pLEi9vBpB+vcFiKrqN4SoA+CvrMTgsevBtF77achT80 mQGm/8xIGJj8NqV28He6UUhfQmWOOWi7L5cKs8BuFpP2dGGsQv84T2Enm+nem4DjMWBL Svig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lkTCANro; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id v4sor753001ljn.32.2021.11.03.02.03.01 for (Google Transport Security); Wed, 03 Nov 2021 02:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lkTCANro; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IOBd8zmaQ/o/1Os9BhWOC3FQNCJBCGeietUzMVOB0tg=; b=lkTCANroPPKqVJC2MHaOK86LkAxmqCcoPdzizhKQsu5FLX5GklvxDeJF36LAnEbriE /d0D/zPVKfsDXRgwEhutWoZmAA51U6dk3gI5+u9Lv3F0VUsAHP3Xv6RVDqszdo5BAoI1 JyoHV7aHz2FclXZTqCpT1XmaI2aQbjBVX7IWMqUmOELfd4xCE95fU/YAOAnnFLaB8Vou qoW0LDe3srMyajm/2DrskM/J8/+Zyp+W9tkYBxloCHJHnbiFEx3Sh/zw6ehmn8mjV3ED jrSVMvnb93+jMNWRO/u+Gmse7D47hIk5dz4ytn6rByjj/ZLKlnTfmVppPx4KWIcV1O42 P8kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IOBd8zmaQ/o/1Os9BhWOC3FQNCJBCGeietUzMVOB0tg=; b=QapNd+D2vRP/edj7tAj/rVQBHiaRSLTp4aypv9Z6Gr/Nt6zjKq1oa8lwhH87fWCxFv S7wQ52Oh0rMJcOTvZlCaEt25C5xgPBqkVKYV7DvnIbSM9hnkKUCi0dilPc3nifc/aI78 0G7LpctF3OH7/jwpyQekhxuB6EtzjGKuuFnU6fh1LENwV78ezAhJmhEGIkFXZOIli0VO lH0KskfIHZ+pjaoTZgCjba1CO0GhOyHmhKnSIXCvqp5mihxBQwAPI7zpxHpXPtRn48lx kVK4CbtefMqYS/wWT10NyHtVFdXY2EbEEytdam4Mn1bDHY5vfhrFS+cRpNZQVpiDjKJ0 DvSg== X-Gm-Message-State: AOAM530UWJJftnM7tdribJxwddTqimEL+MWPVPPMAiTodhtJBfE0U3JC S6d+4jel8TIao8FBTY8ZtkW4Urem X-Google-Smtp-Source: ABdhPJw1zrzgQqG3DycM6ORsIoM0D4GUG1DpG6pE6I48Ta4qjxKuttUcAyk2hbAKXaylJrPkGpV71w== X-Received: by 2002:a2e:a5c8:: with SMTP id n8mr43739989ljp.307.1635930181221; Wed, 03 Nov 2021 02:03:01 -0700 (PDT) Return-Path: Received: from jade.urgonet (h-94-254-48-165.A175.priv.bahnhof.se. [94.254.48.165]) by smtp.gmail.com with ESMTPSA id w16sm124373lfr.233.2021.11.03.02.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 02:03:00 -0700 (PDT) From: Jens Wiklander To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Cc: Jerome Forissier , Etienne Carriere , Sumit Garg , Vincent Guittot , Rob Herring , Jonathan Corbet , Ard Biesheuvel , Marc Zyngier , jens.vankeirsbilck@kuleuven.be, Jens Wiklander Subject: [PATCH v8 0/6] Asynchronous notifications from secure world Date: Wed, 3 Nov 2021 10:02:49 +0100 Message-Id: <20211103090255.998070-1-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Hi all, This adds support for asynchronous notifications from OP-TEE in secure world to the OP-TEE driver. This allows a design with a top half and bottom half type of driver where the top half runs in secure interrupt context and a notifications tells normal world to schedule a yielding call to do the bottom half processing. An edge-triggered interrupt is used to notify the driver that there are asynchronous notifications pending. Only the SMC based ABI of the OP-TEE driver gains asynchronous notifications. Future support for asynchronous notifications in the FF-A based ABI will rely on APIs which are expected to be provided by the FF-A driver in a not too distant future. This patchset is also available at https://git.linaro.org/people/jens.wiklander/linux-tee.git/log/?h=async_notif_v8 v7->v8: * Fixed an error in "dt-bindings: arm: optee: add interrupt property" reported by Rob's bot. * "optee: add asynchronous notifications": - Fixed a few spell errors in comments - Added a missing optee_unregister_devices() in the cleanup path of optee_probe(). - Added Sumit's Reviewed-by v6->v7: * Rebased on 4615e5a34b95 ("optee: add FF-A support") in https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git with 34f3c67b8178 ("optee: smc_abi.c: add missing #include ") cherry-picked on top. This allows to resolve the conflicts with pull request "[GIT PULL] OP-TEE FF-A for V5.16" * Factored out the interrupt handling added in "optee: add asynchronous notifications" to only go into smb_abi.c. A different approach is expected with FF-A once it has asynchronous notifications. * Addressed review comments from Sumit Garg: - Replaced 0 and 1 with the macros GIC_SPI and IRQ_TYPE_EDGE_RISING in the example in the bindings. - Replaced the magic number to optee_notif_init() with OPTEE_DEFAULT_MAX_NOTIF_VALUE in the commit "optee: separate notification functions" - Switched back to tagged error path in optee_probe() - Fixed a few nits in "optee: add asynchronous notifications" - Applied Sumit's Reviewed-by on all commits but the last, "optee: add asynchronous notifications" v5->v6: * Rebased on v5.15-rc2 * Replaced "tee: add tee_dev_open_helper() primitive" with "tee: export teedev_open() and teedev_close_context()" since it turned out that the normal teedev functions could be used instead as noted by Sumit. * Changed "optee: add asynchronous notifications" to use the exported teedev_open() and teedev_close_context() functions instead. v4->v5: * Rebased on v5.14-rc7 * Updated documentation to clarify that one interrupt may represent multiple notifications as requested. * Applied Marc's and Rob's tags v3->v4: * Clarfied the expected type of interrypt is edge-triggered, both in the normal documentation and in the DT bindings as requested. v2->v3: * Rebased on v5.14-rc2 which made the patch "dt-bindings: arm: Convert optee binding to json-schema" from the V2 patch set obsolete. * Applied Ard's Acked-by on "optee: add asynchronous notifications" v1->v2: * Added documentation * Converted optee bindings to json-schema and added interrupt property * Configure notification interrupt from DT instead of getting it from secure world, suggested by Ard Biesheuvel . Thanks, Jens Jens Wiklander (6): docs: staging/tee.rst: add a section on OP-TEE notifications dt-bindings: arm: optee: add interrupt property tee: fix put order in teedev_close_context() tee: export teedev_open() and teedev_close_context() optee: separate notification functions optee: add asynchronous notifications .../arm/firmware/linaro,optee-tz.yaml | 8 + Documentation/staging/tee.rst | 30 +++ drivers/tee/optee/Makefile | 1 + drivers/tee/optee/core.c | 2 +- drivers/tee/optee/ffa_abi.c | 6 +- drivers/tee/optee/notif.c | 125 +++++++++ drivers/tee/optee/optee_msg.h | 9 + drivers/tee/optee/optee_private.h | 28 +- drivers/tee/optee/optee_rpc_cmd.h | 31 ++- drivers/tee/optee/optee_smc.h | 75 +++++- drivers/tee/optee/rpc.c | 71 +----- drivers/tee/optee/smc_abi.c | 241 +++++++++++++++--- drivers/tee/tee_core.c | 10 +- include/linux/tee_drv.h | 14 + 14 files changed, 525 insertions(+), 126 deletions(-) create mode 100644 drivers/tee/optee/notif.c -- 2.31.1