mbox series

[v2,0/2] Fix y2038 issues for security/keys subsystem

Message ID cover.1505960744.git.baolin.wang@linaro.org
Headers show
Series Fix y2038 issues for security/keys subsystem | expand

Message

(Exiting) Baolin Wang Sept. 21, 2017, 2:32 a.m. UTC
Since 'time_t', 'timeval' and 'timespec' types are not year 2038 safe on
32 bits system, this patchset tries to fix this issues for security/keys
subsystem.

Changes since v1:
 - Add reviewed tag from Arnd.
 - Drop Patch 3 which had been merged into kernel 4.14 by David.

Baolin Wang (2):
  security: keys: Replace time_t/timespec with time64_t
  security: keys: Replace time_t with time64_t for struct
    key_preparsed_payload

 include/linux/key-type.h     |    2 +-
 include/linux/key.h          |    7 ++++---
 security/keys/gc.c           |   20 ++++++++++----------
 security/keys/internal.h     |    8 ++++----
 security/keys/key.c          |   27 ++++++++++-----------------
 security/keys/keyring.c      |   18 +++++++++---------
 security/keys/permission.c   |    3 +--
 security/keys/proc.c         |   20 ++++++++++----------
 security/keys/process_keys.c |    2 +-
 9 files changed, 50 insertions(+), 57 deletions(-)

-- 
1.7.9.5

Comments

James Morris Sept. 28, 2017, 9:11 a.m. UTC | #1
On Thu, 21 Sep 2017, Baolin Wang wrote:

> Since 'time_t', 'timeval' and 'timespec' types are not year 2038 safe on

> 32 bits system, this patchset tries to fix this issues for security/keys

> subsystem.

> 

> Changes since v1:

>  - Add reviewed tag from Arnd.

>  - Drop Patch 3 which had been merged into kernel 4.14 by David.

> 

> Baolin Wang (2):

>   security: keys: Replace time_t/timespec with time64_t

>   security: keys: Replace time_t with time64_t for struct

>     key_preparsed_payload

> 

>  include/linux/key-type.h     |    2 +-

>  include/linux/key.h          |    7 ++++---

>  security/keys/gc.c           |   20 ++++++++++----------

>  security/keys/internal.h     |    8 ++++----

>  security/keys/key.c          |   27 ++++++++++-----------------

>  security/keys/keyring.c      |   18 +++++++++---------

>  security/keys/permission.c   |    3 +--

>  security/keys/proc.c         |   20 ++++++++++----------

>  security/keys/process_keys.c |    2 +-

>  9 files changed, 50 insertions(+), 57 deletions(-)


David, have you taken these into your tree?  I can apply them to mine if 
needed.


-- 
James Morris
<jmorris@namei.org>
David Howells Sept. 28, 2017, 9:26 a.m. UTC | #2
James Morris <jmorris@namei.org> wrote:

> David, have you taken these into your tree?  I can apply them to mine if 

> needed.


I was intending to add them to my next tree for security/next.

David
James Morris Sept. 28, 2017, 9:48 a.m. UTC | #3
On Thu, 28 Sep 2017, David Howells wrote:

> James Morris <jmorris@namei.org> wrote:

> 

> > David, have you taken these into your tree?  I can apply them to mine if 

> > needed.

> 

> I was intending to add them to my next tree for security/next.


Ok, please add
Reviewed-by: James Morris <james.l.morris@oracle.com>


to these.

Also, please use the new next-general branch for tracking & pull requests 
for the next kernel.



-- 
James Morris
<jmorris@namei.org>
(Exiting) Baolin Wang Sept. 28, 2017, 10:05 p.m. UTC | #4
On 28 September 2017 at 17:48, James Morris <jmorris@namei.org> wrote:
> On Thu, 28 Sep 2017, David Howells wrote:

>

>> James Morris <jmorris@namei.org> wrote:

>>

>> > David, have you taken these into your tree?  I can apply them to mine if

>> > needed.

>>

>> I was intending to add them to my next tree for security/next.

>

> Ok, please add

> Reviewed-by: James Morris <james.l.morris@oracle.com>

>

> to these.

>

> Also, please use the new next-general branch for tracking & pull requests

> for the next kernel.


Thanks James and David.

-- 
Baolin.wang
Best Regards