From patchwork Thu May 12 23:02:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 1469 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:52:13 -0000 Delivered-To: patches@linaro.org Received: by 10.224.61.3 with SMTP id r3cs126742qah; Thu, 12 May 2011 16:03:04 -0700 (PDT) Received: by 10.150.159.17 with SMTP id h17mr861928ybe.235.1305241383575; Thu, 12 May 2011 16:03:03 -0700 (PDT) Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx.google.com with ESMTPS id k3si112710ybe.3.2011.05.12.16.03.02 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 May 2011 16:03:02 -0700 (PDT) Received-SPF: pass (google.com: domain of jstultz@us.ibm.com designates 32.97.110.159 as permitted sender) client-ip=32.97.110.159; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jstultz@us.ibm.com designates 32.97.110.159 as permitted sender) smtp.mail=jstultz@us.ibm.com Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e38.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4CMswVZ007572; Thu, 12 May 2011 16:54:58 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4CN4AM2143928; Thu, 12 May 2011 17:04:10 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4CH2tre002543; Thu, 12 May 2011 11:02:56 -0600 Received: from kernel.beaverton.ibm.com (kernel.beaverton.ibm.com [9.47.67.96]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p4CH2tLA002527; Thu, 12 May 2011 11:02:55 -0600 Received: by kernel.beaverton.ibm.com (Postfix, from userid 1056) id 98BB51E7511; Thu, 12 May 2011 16:02:54 -0700 (PDT) From: John Stultz To: LKML Cc: John Stultz , "Ted Ts'o" , KOSAKI Motohiro , David Rientjes , Dave Hansen , Andrew Morton , linux-mm@kvack.org Subject: [PATCH 3/3] checkpatch.pl: Add check for current->comm references Date: Thu, 12 May 2011 16:02:51 -0700 Message-Id: <1305241371-25276-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.7.3.2.146.gca209 In-Reply-To: <1305241371-25276-1-git-send-email-john.stultz@linaro.org> References: <1305241371-25276-1-git-send-email-john.stultz@linaro.org> Now that accessing current->comm needs to be protected, avoid new current->comm usage by adding a warning to checkpatch.pl. Fair warning: I know zero perl, so this was written in the style of "monkey see, monkey do". It does appear to work in my testing though. Close review and feedback would be appreciated. CC: Ted Ts'o CC: KOSAKI Motohiro CC: David Rientjes CC: Dave Hansen CC: Andrew Morton CC: linux-mm@kvack.org Signed-off-by: John Stultz --- scripts/checkpatch.pl | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d867081..9d2eab5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2868,6 +2868,10 @@ sub process { WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr); } +# check for current->comm usage + if ($line =~ /current->comm/) { + WARN("comm access needs to be protected. Use get_task_comm, or printk's \%ptc formatting.\n" . $herecurr); + } # check for %L{u,d,i} in strings my $string; while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {