From patchwork Tue Feb 21 17:58:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 6866 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 1F38923E01 for ; Tue, 21 Feb 2012 17:59:02 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id D4C5CA184CD for ; Tue, 21 Feb 2012 17:59:01 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id z7so12842627iab.11 for ; Tue, 21 Feb 2012 09:59:01 -0800 (PST) Received: from mr.google.com ([10.43.52.74]) by 10.43.52.74 with SMTP id vl10mr28362616icb.55.1329847141713 (num_hops = 1); Tue, 21 Feb 2012 09:59:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.43.52.74 with SMTP id vl10mr22638734icb.55.1329847141500; Tue, 21 Feb 2012 09:59:01 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.11.10 with SMTP id r10csp104262ibr; Tue, 21 Feb 2012 09:59:00 -0800 (PST) Received: by 10.68.219.130 with SMTP id po2mr58347850pbc.140.1329847139794; Tue, 21 Feb 2012 09:58:59 -0800 (PST) Received: from e34.co.us.ibm.com (e34.co.us.ibm.com. [32.97.110.152]) by mx.google.com with ESMTPS id q7si25432100pbf.87.2012.02.21.09.58.59 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Feb 2012 09:58:59 -0800 (PST) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.152 as permitted sender) client-ip=32.97.110.152; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.110.152 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Feb 2012 10:58:58 -0700 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 21 Feb 2012 10:58:58 -0700 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 22B6719D8053 for ; Tue, 21 Feb 2012 10:58:53 -0700 (MST) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q1LHwtxq158134 for ; Tue, 21 Feb 2012 10:58:55 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q1LHwYP0012972 for ; Tue, 21 Feb 2012 10:58:51 -0700 Received: from paulmck-ThinkPad-W500 ([9.47.24.149]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q1LHwWwQ012633; Tue, 21 Feb 2012 10:58:33 -0700 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id F092AE51EF; Tue, 21 Feb 2012 09:58:31 -0800 (PST) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, patches@linaro.org, Hugh Dickins , "Paul E. McKenney" Subject: [PATCH tip/core/rcu 3/4] rcu: stop spurious warnings from synchronize_sched_expedited Date: Tue, 21 Feb 2012 09:58:28 -0800 Message-Id: <1329847110-10897-3-git-send-email-paulmck@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1329847110-10897-1-git-send-email-paulmck@linux.vnet.ibm.com> References: <20120221175810.GA10708@linux.vnet.ibm.com> <1329847110-10897-1-git-send-email-paulmck@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12022117-1780-0000-0000-00000358E30A X-IBM-ISS-SpamDetectors: X-IBM-ISS-DetailInfo: BY=3.00000248; HX=3.00000183; KW=3.00000007; PH=3.00000001; SC=3.00000001; SDB=6.00115693; UDB=6.00028316; UTC=2012-02-21 17:58:58 X-Gm-Message-State: ALoCoQnCv8pQZrn3+R0wlgWuXH+KLf7Ggd9i2Bt167/gcemFAzYK086HROw+zCmjinLDyFgF9tHx From: Hugh Dickins synchronize_sched_expedited() is spamming CONFIG_DEBUG_PREEMPT=y users with an unintended warning from the cpu_is_offline() check: use raw_smp_processor_id() instead of smp_processor_id() there. Signed-off-by: Hugh Dickins Signed-off-by: Paul E. McKenney --- kernel/rcutree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/rcutree.c b/kernel/rcutree.c index eacc10b..1050d6d 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c @@ -2014,7 +2014,7 @@ void synchronize_sched_expedited(void) /* Note that atomic_inc_return() implies full memory barrier. */ firstsnap = snap = atomic_inc_return(&sync_sched_expedited_started); get_online_cpus(); - WARN_ON_ONCE(cpu_is_offline(smp_processor_id())); + WARN_ON_ONCE(cpu_is_offline(raw_smp_processor_id())); /* * Each pass through the following loop attempts to force a