From patchwork Wed May 23 11:17:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 8902 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 9EFF323E63 for ; Wed, 23 May 2012 11:27:59 +0000 (UTC) Received: from mail-gg0-f180.google.com (mail-gg0-f180.google.com [209.85.161.180]) by fiordland.canonical.com (Postfix) with ESMTP id 63844A18346 for ; Wed, 23 May 2012 11:27:59 +0000 (UTC) Received: by ggnf1 with SMTP id f1so7844063ggn.11 for ; Wed, 23 May 2012 04:27:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=zJ+S37xjQyUkzTvX/5B0nKIPvoOU4GYtFBetpUgs+E8=; b=RGnIjOgJT40rgENoYqV8TqHjJZmpQWJwWcAqP1MjLU6reJKM6yi9SmSpoAAF7f2xPm DCYD+onv46Mc4N9S0/rA1dmbEI6WrKrlLXyj4i2mV6pprx45srbD4UEJp1sQ4/9QSBJ3 L88HINNGLqd8K4T6M1w8cURtycsckWeZBHKx6HPbzqujbIMcveKeW6ZHBnJo0W5Lxm34 L8ImjHgV6LEX7vs0LefQSQlP65mjCGIc4PzwwvaG5Tu4uc1fHNIkddCxh6os8zquvBbV Kj2LIx6oYlsSlY2nUTK7AnPDyRtU2gx8Pid7uhKv3QG671e7alRLYlE8O50HiBeXPzGs hd3w== Received: by 10.50.195.234 with SMTP id ih10mr12708870igc.0.1337772478672; Wed, 23 May 2012 04:27:58 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.35.72 with SMTP id o8csp436667ibd; Wed, 23 May 2012 04:27:57 -0700 (PDT) Received: by 10.68.217.138 with SMTP id oy10mr9537650pbc.30.1337772477438; Wed, 23 May 2012 04:27:57 -0700 (PDT) Received: from mail-pz0-f50.google.com (mail-pz0-f50.google.com [209.85.210.50]) by mx.google.com with ESMTPS id ny9si1905296pbb.57.2012.05.23.04.27.57 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 May 2012 04:27:57 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.210.50 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) client-ip=209.85.210.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.50 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) smtp.mail=tushar.behera@linaro.org Received: by danh15 with SMTP id h15so11460129dan.37 for ; Wed, 23 May 2012 04:27:57 -0700 (PDT) Received: by 10.68.225.69 with SMTP id ri5mr9268219pbc.147.1337772477161; Wed, 23 May 2012 04:27:57 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id qt8sm1563201pbb.32.2012.05.23.04.27.54 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 May 2012 04:27:56 -0700 (PDT) From: Tushar Behera To: linux-kernel@vger.kernel.org Cc: vinod.koul@intel.com, dan.j.williams@intel.com, patches@linaro.org Subject: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma Date: Wed, 23 May 2012 16:47:31 +0530 Message-Id: <1337771851-3431-1-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQmO5b5fAL2Q0kyFy68o+AGDUAJwmdIZycrFzRi4Hssi0xhut3Ceb8l0kvLL2hJrSLkbdHdZ Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for cyclic dma") wrongly completes descriptor for cyclic dma, hence following BUG_ON is still hit with cyclic DMA operations. kernel BUG at drivers/dma/dmaengine.h:53! Signed-off-by: Tushar Behera Acked-by: Jassi Brar --- drivers/dma/pl330.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index fa3fb21..8c44f17 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2322,7 +2322,7 @@ static void pl330_tasklet(unsigned long data) /* Pick up ripe tomatoes */ list_for_each_entry_safe(desc, _dt, &pch->work_list, node) if (desc->status == DONE) { - if (pch->cyclic) + if (!pch->cyclic) dma_cookie_complete(&desc->txd); list_move_tail(&desc->node, &list); }