From patchwork Thu Sep 13 15:03:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 11393 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id AD10523EB4 for ; Thu, 13 Sep 2012 15:06:34 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id DB5ACA2674F for ; Thu, 13 Sep 2012 15:06:33 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id k11so4928223iea.11 for ; Thu, 13 Sep 2012 08:06:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=p/kWpoIxbmOilCPgdtlfnLwScRjWGa1PsfxvN1ORpo0=; b=CThPYbNudddeIOIu7X89PLsqkv2PMo/T127j23/5M1eBi7iodm95Qw9xeu59RXMk3j q+MSq6wpkNxj2CufIgjhkOKn72/nd/Cuv8OZiMX97Vr17Icq4MUYYUtRbRgmKi/734zn APqn6HfNb/Dd31cUUOK5daAzbN8HMbDPbXYw5nib8ZwVWBnZjYxtX5abvJefn2a4MW2f l0XYcYkPxiL1z4e+1ikjyngAi2f3WpZN+T32H5S/B37d6l8i6FVhYIGSGg5IybOMuCaw qc2hqcqnnAnOis5PPx6VfSwklVYT5tULdLGndbo9pBxmWOsKNtTDLg2ibGNpnX3HgqfG bvsQ== Received: by 10.50.237.41 with SMTP id uz9mr2827965igc.43.1347548793681; Thu, 13 Sep 2012 08:06:33 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp137326igc; Thu, 13 Sep 2012 08:06:33 -0700 (PDT) Received: by 10.66.78.195 with SMTP id d3mr3839857pax.17.1347548792293; Thu, 13 Sep 2012 08:06:32 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id qt3si34570000pbc.143.2012.09.13.08.06.32 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 13 Sep 2012 08:06:32 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) smtp.mail=anton.vorontsov@linaro.org Received: by mail-pb0-f50.google.com with SMTP id md12so4678736pbc.37 for ; Thu, 13 Sep 2012 08:06:32 -0700 (PDT) Received: by 10.68.224.70 with SMTP id ra6mr94613pbc.11.1347548791898; Thu, 13 Sep 2012 08:06:31 -0700 (PDT) Received: from localhost (c-71-204-165-222.hsd1.ca.comcast.net. [71.204.165.222]) by mx.google.com with ESMTPS id qw6sm13214626pbc.26.2012.09.13.08.06.30 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 13 Sep 2012 08:06:31 -0700 (PDT) From: Anton Vorontsov To: Andrew Morton , Russell King , Jason Wessel , Greg Kroah-Hartman , Alan Cox Cc: =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Colin Cross , Brian Swetland , John Stultz , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com, kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org Subject: [PATCH 03/11] kdb: Turn KGDB_KDB=n stubs into static inlines Date: Thu, 13 Sep 2012 08:03:27 -0700 Message-Id: <1347548615-18227-3-git-send-email-anton.vorontsov@linaro.org> X-Mailer: git-send-email 1.7.11.5 In-Reply-To: <20120913150133.GA16238@lizard> References: <20120913150133.GA16238@lizard> X-Gm-Message-State: ALoCoQlDN6z9i+YA9a4iNtRalc7PHluu7FiYV1rnHXTaWNIRXC2pI6cJTNKXQiX69ZgyJ5AUvECI This makes the stubs actually usable, since e.g. 'foo = kdb_register();' leads to build errors in !KGDB_KDB case. Plus, with static inlines we do type checking. Signed-off-by: Anton Vorontsov --- include/linux/kdb.h | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/include/linux/kdb.h b/include/linux/kdb.h index 42d9e86..7f6fe6e 100644 --- a/include/linux/kdb.h +++ b/include/linux/kdb.h @@ -13,6 +13,14 @@ * Copyright (C) 2009 Jason Wessel */ +typedef enum { + KDB_REPEAT_NONE = 0, /* Do not repeat this command */ + KDB_REPEAT_NO_ARGS, /* Repeat the command without arguments */ + KDB_REPEAT_WITH_ARGS, /* Repeat the command including its arguments */ +} kdb_repeat_t; + +typedef int (*kdb_func_t)(int, const char **); + #ifdef CONFIG_KGDB_KDB #include #include @@ -32,14 +40,6 @@ extern atomic_t kdb_event; #define KDB_MAXARGS 16 /* Maximum number of arguments to a function */ -typedef enum { - KDB_REPEAT_NONE = 0, /* Do not repeat this command */ - KDB_REPEAT_NO_ARGS, /* Repeat the command without arguments */ - KDB_REPEAT_WITH_ARGS, /* Repeat the command including its arguments */ -} kdb_repeat_t; - -typedef int (*kdb_func_t)(int, const char **); - /* KDB return codes from a command or internal kdb function */ #define KDB_NOTFOUND (-1) #define KDB_ARGCOUNT (-2) @@ -149,11 +149,14 @@ extern int kdb_register_repeat(char *, kdb_func_t, char *, char *, short, kdb_repeat_t); extern int kdb_unregister(char *); #else /* ! CONFIG_KGDB_KDB */ -#define kdb_printf(...) -#define kdb_init(x) -#define kdb_register(...) -#define kdb_register_repeat(...) -#define kdb_uregister(x) +static inline __printf(1, 2) int kdb_printf(const char *fmt, ...) { return 0; } +static inline void kdb_init(int level) {} +static inline int kdb_register(char *cmd, kdb_func_t func, char *usage, + char *help, short minlen) { return 0; } +static inline int kdb_register_repeat(char *cmd, kdb_func_t func, char *usage, + char *help, short minlen, + kdb_repeat_t repeat) { return 0; } +static inline int kdb_unregister(char *cmd) { return 0; } #endif /* CONFIG_KGDB_KDB */ enum { KDB_NOT_INITIALIZED,