From patchwork Fri Nov 16 06:50:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 12888 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id CA1BB23E13 for ; Fri, 16 Nov 2012 06:57:14 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 7DDD2A18287 for ; Fri, 16 Nov 2012 06:57:14 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so3064408iej.11 for ; Thu, 15 Nov 2012 22:57:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=yAf1cjl9fbYvOYv76XSmGQ9rzRPAb+ZhgOID8AouvIA=; b=l9JaOqCYSTouuUHnM3H3nD6UnLUU7K+t7EeCY32JMDocFhOAOn7R8lzu2/JCMRu7qK 4ZVqDNIZsBtgzy1soKpdCBqlBGyvNPxq957gcHP+49M9GxfezCmgbaHHR3eGnoUJZHr6 DVzpltpiYcpGC0CcK8IlPvHT6B3RbmxcQqiZ2g0cIrWTMA7mbDbrbEiLoBJF2El8PJ/a Eok2YnkuJb7Rd1McNUU6RXeQn3qZOrmEmh7MYSlYga47/ZYgT4qAp15Qt0Daded5X+x5 WsXr/+haZlluZ0OgXRDn0GxKPry9zPk8bNqgUcvnJvoKJDNxnegPz/X7HbRkNpXRnAJP YNCw== Received: by 10.50.152.137 with SMTP id uy9mr2201334igb.62.1353049034244; Thu, 15 Nov 2012 22:57:14 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp23341igt; Thu, 15 Nov 2012 22:57:13 -0800 (PST) Received: by 10.68.203.72 with SMTP id ko8mr6422283pbc.78.1353049033750; Thu, 15 Nov 2012 22:57:13 -0800 (PST) Received: from mail-da0-f46.google.com (mail-da0-f46.google.com [209.85.210.46]) by mx.google.com with ESMTPS id bf10si1129199pab.224.2012.11.15.22.57.13 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 22:57:13 -0800 (PST) Received-SPF: neutral (google.com: 209.85.210.46 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) client-ip=209.85.210.46; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.46 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) smtp.mail=tushar.behera@linaro.org Received: by mail-da0-f46.google.com with SMTP id n41so1021430dak.19 for ; Thu, 15 Nov 2012 22:57:13 -0800 (PST) Received: by 10.68.243.10 with SMTP id wu10mr12274722pbc.85.1353049033521; Thu, 15 Nov 2012 22:57:13 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id mz10sm753915pbc.37.2012.11.15.22.57.10 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 22:57:12 -0800 (PST) From: Tushar Behera To: linux-kernel@vger.kernel.org Cc: patches@linaro.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables Date: Fri, 16 Nov 2012 12:20:37 +0530 Message-Id: <1353048646-10935-6-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org> References: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org> X-Gm-Message-State: ALoCoQmeAs/mCrzse3CFLouatKLMpnmrWl5dfLoG/FP4T+nNGgHOmST0ADhdjoFbekINYkIxImTZ Checking '< 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/platform/soc_camera/atmel-isi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c index 6274a91..5bd65df 100644 --- a/drivers/media/platform/soc_camera/atmel-isi.c +++ b/drivers/media/platform/soc_camera/atmel-isi.c @@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct platform_device *pdev) isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS); irq = platform_get_irq(pdev, 0); - if (irq < 0) { + if (IS_ERR_VALUE(irq)) { ret = irq; goto err_req_irq; }