From patchwork Tue Feb 18 10:40:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 24821 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f199.google.com (mail-pd0-f199.google.com [209.85.192.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E66C8203C5 for ; Tue, 18 Feb 2014 10:47:08 +0000 (UTC) Received: by mail-pd0-f199.google.com with SMTP id fp1sf36072982pdb.6 for ; Tue, 18 Feb 2014 02:47:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=NCZ6PCiuKONpTTZy7VJYQm/5TxCoEXix70bhbWM36bU=; b=Mz74yj8VomZ7mzltnFZWrOs4mUkBvf5I1+Q0uxQIq6HnY7fMpARH5LcJzcpLigWYdq fn5XuEmvMYvnslWwwqdhvBtHs7ZccLDUFw8g/SLo6SQ8DdsRgA6tKH4Hf+EneQqN1cqJ 0GZhdOY26yyZ0QTMh0GfuYH4mou2e6pn9Zu+uMnhSrTaGgQpafoRkoOb0hdDz99m6xr6 jxufC1eUsLbKkUx2s/d1jkXYAqs0lLLYr+H3IPPYLQI6SL7cZe0XsfjUUUYS4EXYzHXq bBZio4YrHbzP339KpMpeDbE6Tf5neuiZiouaQk5/DkI1ysVbRArnNuaFCXbRPPoMsxOi SueA== X-Gm-Message-State: ALoCoQlFHNf5jwO2R8QDZ+GwTuyAqVPidpOUssyepRHFoG+8MUphDo2CxXd/wnz43PiXiwPRZ4fV X-Received: by 10.66.189.228 with SMTP id gl4mr12766314pac.26.1392720428154; Tue, 18 Feb 2014 02:47:08 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.30.201 with SMTP id d67ls1223411qgd.62.gmail; Tue, 18 Feb 2014 02:47:08 -0800 (PST) X-Received: by 10.52.164.137 with SMTP id yq9mr13843759vdb.33.1392720428025; Tue, 18 Feb 2014 02:47:08 -0800 (PST) Received: from mail-ve0-f171.google.com (mail-ve0-f171.google.com [209.85.128.171]) by mx.google.com with ESMTPS id g4si5380573vch.73.2014.02.18.02.47.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Feb 2014 02:47:07 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.171; Received: by mail-ve0-f171.google.com with SMTP id pa12so13153455veb.2 for ; Tue, 18 Feb 2014 02:47:07 -0800 (PST) X-Received: by 10.220.106.84 with SMTP id w20mr20683645vco.18.1392720427874; Tue, 18 Feb 2014 02:47:07 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp207184vcz; Tue, 18 Feb 2014 02:47:07 -0800 (PST) X-Received: by 10.68.89.162 with SMTP id bp2mr9045966pbb.151.1392720427015; Tue, 18 Feb 2014 02:47:07 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id if4si17894589pbc.136.2014.02.18.02.47.06; Tue, 18 Feb 2014 02:47:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754968AbaBRKqv (ORCPT + 27 others); Tue, 18 Feb 2014 05:46:51 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:52601 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754908AbaBRKqq (ORCPT ); Tue, 18 Feb 2014 05:46:46 -0500 Received: by mail-pa0-f53.google.com with SMTP id lj1so16558336pab.12 for ; Tue, 18 Feb 2014 02:46:45 -0800 (PST) X-Received: by 10.68.164.4 with SMTP id ym4mr32621870pbb.53.1392720405738; Tue, 18 Feb 2014 02:46:45 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id gj9sm5442084pbc.7.2014.02.18.02.46.42 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Feb 2014 02:46:44 -0800 (PST) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: broonie@kernel.org, lgirdwood@gmail.com, sachin.kamat@linaro.org Subject: [PATCH 02/15] regulator: ti-abb: Do not hardcode return value Date: Tue, 18 Feb 2014 16:10:58 +0530 Message-Id: <1392720071-13503-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1392720071-13503-1-git-send-email-sachin.kamat@linaro.org> References: <1392720071-13503-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Propagate the error value returned by the function instead. Signed-off-by: Sachin Kamat --- drivers/regulator/ti-abb-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb-regulator.c index 804c83a31d69..75fa64769b4b 100644 --- a/drivers/regulator/ti-abb-regulator.c +++ b/drivers/regulator/ti-abb-regulator.c @@ -522,7 +522,7 @@ static int ti_abb_init_table(struct device *dev, struct ti_abb *abb, num_entries = of_property_count_u32_elems(dev->of_node, pname); if (num_entries < 0) { dev_err(dev, "No '%s' property?\n", pname); - return -ENODEV; + return num_entries; } if (!num_entries || (num_entries % num_values)) {