From patchwork Wed Apr 30 13:39:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dietmar Eggemann X-Patchwork-Id: 29424 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f197.google.com (mail-vc0-f197.google.com [209.85.220.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 16AA3203F3 for ; Wed, 30 Apr 2014 13:39:54 +0000 (UTC) Received: by mail-vc0-f197.google.com with SMTP id lc6sf5604445vcb.8 for ; Wed, 30 Apr 2014 06:39:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=9EJyi7cnS0gLlkqQ9yZes407q3WhgFiqTde+e8dJ6a0=; b=XOy7c+O0OsVMJrhdwryw7b41EMo4yTdZnDOu7wPyAn/YO1xlW07igVNQIemM2Z3C3R mqZg2WUb9x8qOW76t9uZF5Q9eH7Bn5R67llydQhIhLB/QmFtd0509R543iJJbyzx8Rsg SqWjhgtNKQbw8C6nOFW5zgNBhduLIuLhx1rPPsvY53N9IkBU9ohLWwLY/sv98WtMLkWa WTSe7AEXG53ZjpEPuMcrB5JxRCKMqaV+wWgh+g4FDVGfVlKikHCVF/skRHpDfHdDQ6gX 10wtdTM2Ci98aeGKB5ry/b08hUphkZJ0Ol3asCLqeSm/CCEwW/JVJXtALiuCcP3ExIIb WR9A== X-Gm-Message-State: ALoCoQm/SLajn7Nut8ZXBlC/18aMB+0eNRQ52S8u7n5lGS9wEcr+yUivP+sLgFCsdgqeQ23VXxpq X-Received: by 10.58.154.228 with SMTP id vr4mr2490186veb.0.1398865194688; Wed, 30 Apr 2014 06:39:54 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.50.81 with SMTP id r75ls609200qga.71.gmail; Wed, 30 Apr 2014 06:39:54 -0700 (PDT) X-Received: by 10.52.1.200 with SMTP id 8mr81078vdo.76.1398865194476; Wed, 30 Apr 2014 06:39:54 -0700 (PDT) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx.google.com with ESMTPS id kj3si5306479vdb.78.2014.04.30.06.39.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 06:39:54 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.128.169; Received: by mail-ve0-f169.google.com with SMTP id jx11so2178716veb.0 for ; Wed, 30 Apr 2014 06:39:54 -0700 (PDT) X-Received: by 10.53.7.67 with SMTP id da3mr75478vdd.84.1398865194413; Wed, 30 Apr 2014 06:39:54 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp279813vcb; Wed, 30 Apr 2014 06:39:53 -0700 (PDT) X-Received: by 10.51.15.195 with SMTP id fq3mr4646567igd.5.1398865193630; Wed, 30 Apr 2014 06:39:53 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6si1495460igg.12.2014.04.30.06.39.52; Wed, 30 Apr 2014 06:39:52 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933643AbaD3Njk (ORCPT + 28 others); Wed, 30 Apr 2014 09:39:40 -0400 Received: from service87.mimecast.com ([91.220.42.44]:45506 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbaD3Nji (ORCPT ); Wed, 30 Apr 2014 09:39:38 -0400 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 30 Apr 2014 14:39:37 +0100 Received: from e103711-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 30 Apr 2014 14:39:50 +0100 From: Dietmar Eggemann To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Dietmar Eggemann Subject: [PATCH] sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups Date: Wed, 30 Apr 2014 14:39:38 +0100 Message-Id: <1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com> X-Mailer: git-send-email 1.7.9.5 X-OriginalArrivalTime: 30 Apr 2014 13:39:50.0691 (UTC) FILETIME=[A90AC730:01CF6479] X-MC-Unique: 114043014393700501 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: dietmar.eggemann@arm.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Dietmar Eggemann There is no need to zero struct sched_group member cpumask and struct sched_group_power member power since both structures are already allocated as zeroed memory in __sdt_alloc(). This patch has been tested with BUG_ON(!cpumask_empty(sched_group_cpus(sg))); and BUG_ON(sg->sgp->power); in build_sched_groups() on ARM TC2 and INTEL i5 M520 platform including CPU hotplug scenarios. Signed-off-by: Dietmar Eggemann --- kernel/sched/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 9cae286824bb..6bc51aebbf1b 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5807,8 +5807,6 @@ build_sched_groups(struct sched_domain *sd, int cpu) continue; group = get_group(i, sdd, &sg); - cpumask_clear(sched_group_cpus(sg)); - sg->sgp->power = 0; cpumask_setall(sched_group_mask(sg)); for_each_cpu(j, span) {