From patchwork Thu Jul 3 16:26:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Morten Rasmussen X-Patchwork-Id: 33044 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f69.google.com (mail-oa0-f69.google.com [209.85.219.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6B620203AC for ; Thu, 3 Jul 2014 16:28:38 +0000 (UTC) Received: by mail-oa0-f69.google.com with SMTP id j17sf1953603oag.4 for ; Thu, 03 Jul 2014 09:28:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=Cv0U4Wf6bWeKfhK64XPsXeYLpgRPT7FZokxxZpqwMb0=; b=WGhI1PyTi5MSOKPj6ka1YfIA1BL56eAW/Wlx5gSKb7QnjWqkNzWprGkZr/nH1749/2 wdMubHBvIMtnv+0dR+sQfF8HpldazXu1h6xrgicfTVl5HF+JFQgjoNfP/Xtt0l1QsZ9M GEeDh/L4LpBT+W0K2im66gACmLDV4yCLlVoTRr6ys9JlDnkzb4o+aAZ71lVco+vkZCzw 6Ysff7uTpQYGrxmLK6XT7+oqKlA4MoSRNordAVuU0E/6eEEwQiqxrXxW/r55KvylRimF VutoTKcIctTndCMDOeWsoKKJj5KKRYr+BHb15g3zQAEWYppFm5kkhg9ZVQH2WWXdItDp 7ZBQ== X-Gm-Message-State: ALoCoQnjIwop3TClfQKdNXAASPPfjK7p3wyBFwIk9GPT1uz2M67RXq/ccs34ApFFJx3ZN9GTBhzs X-Received: by 10.50.98.69 with SMTP id eg5mr5779497igb.7.1404404918002; Thu, 03 Jul 2014 09:28:38 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.48.112 with SMTP id n103ls505028qga.86.gmail; Thu, 03 Jul 2014 09:28:37 -0700 (PDT) X-Received: by 10.220.250.203 with SMTP id mp11mr4808612vcb.2.1404404917904; Thu, 03 Jul 2014 09:28:37 -0700 (PDT) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by mx.google.com with ESMTPS id g6si12338170vcn.29.2014.07.03.09.28.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 03 Jul 2014 09:28:37 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.181 as permitted sender) client-ip=209.85.128.181; Received: by mail-ve0-f181.google.com with SMTP id db11so489650veb.12 for ; Thu, 03 Jul 2014 09:28:37 -0700 (PDT) X-Received: by 10.221.20.199 with SMTP id qp7mr4841643vcb.24.1404404917836; Thu, 03 Jul 2014 09:28:37 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp390474vcb; Thu, 3 Jul 2014 09:28:37 -0700 (PDT) X-Received: by 10.66.227.4 with SMTP id rw4mr5888499pac.18.1404404917027; Thu, 03 Jul 2014 09:28:37 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ry2si5806900pbc.106.2014.07.03.09.28.36; Thu, 03 Jul 2014 09:28:36 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758784AbaGCQ2e (ORCPT + 13 others); Thu, 3 Jul 2014 12:28:34 -0400 Received: from service87.mimecast.com ([91.220.42.44]:53542 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758067AbaGCQ2d (ORCPT ); Thu, 3 Jul 2014 12:28:33 -0400 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 03 Jul 2014 17:26:22 +0100 Received: from e103034-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 3 Jul 2014 17:26:22 +0100 From: Morten Rasmussen To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, peterz@infradead.org, mingo@kernel.org Cc: rjw@rjwysocki.net, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, preeti@linux.vnet.ibm.com, Dietmar.Eggemann@arm.com, pjt@google.com Subject: [RFCv2 PATCH 20/23] sched: Take task wakeups into account in energy estimates Date: Thu, 3 Jul 2014 17:26:07 +0100 Message-Id: <1404404770-323-21-git-send-email-morten.rasmussen@arm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1404404770-323-1-git-send-email-morten.rasmussen@arm.com> References: <1404404770-323-1-git-send-email-morten.rasmussen@arm.com> X-OriginalArrivalTime: 03 Jul 2014 16:26:22.0865 (UTC) FILETIME=[87478810:01CF96DB] X-MC-Unique: 114070317262209401 Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: morten.rasmussen@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The energy cost of waking a cpu and sending it back to sleep can be quite significant for short running frequently waking tasks if placed on an idle cpu in a deep sleep state. By factoring task wakeups in such tasks can be placed on cpus where the wakeup energy cost is lower. For example, partly utilized cpus in a shallower idle state, or cpus in a cluster/die that is already awake. Current cpu utilization of the target cpu is factored in to guess how many task wakeups translate into cpu wakeups (idle exits). It is a very naive approach, but it is virtually impossible to get an accurate estimate. wake_energy(task) = unused_util(cpu) * wakeups(task) * wakeup_energy(cpu) There is no per cpu wakeup tracking, so we can't estimate the energy savings when removing tasks from a cpu. It is also nearly impossible to figure out which task is the cause of cpu wakeups if multiple tasks are scheduled on the same cpu. wakeup_energy for each idle-state is obtained from the idle_states array. A prediction of the most likely idle-state is needed. cpuidle is best placed to provide that. It is not implemented yet. Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6da8e2b..aebf3e2 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4367,11 +4367,13 @@ static inline unsigned long get_curr_capacity(int cpu); * + (1-curr_util(sg)) * idle_power(sg) * energy_after = new_util(sg) * busy_power(sg) * + (1-new_util(sg)) * idle_power(sg) + * + (1-new_util(sg)) * task_wakeups + * * wakeup_energy(sg) * energy_diff += energy_before - energy_after * } * */ -static int energy_diff_util(int cpu, int util) +static int energy_diff_util(int cpu, int util, int wakeups) { struct sched_domain *sd; int i; @@ -4476,7 +4478,8 @@ static int energy_diff_util(int cpu, int util) * The utilization change has no impact at this level (or any * parent level). */ - if (aff_util_bef == aff_util_aft && curr_cap_idx == new_cap_idx) + if (aff_util_bef == aff_util_aft && curr_cap_idx == new_cap_idx + && unused_util_aft < 100) goto unlock; /* Energy before */ @@ -4486,6 +4489,14 @@ static int energy_diff_util(int cpu, int util) /* Energy after */ nrg_diff += (aff_util_aft*new_state->power)/new_state->cap; nrg_diff += (unused_util_aft * is->power)/new_state->cap; + + /* + * Estimate how many of the wakeups that happens while cpu is + * idle assuming they are uniformly distributed. Ignoring + * wakeups caused by other tasks. + */ + nrg_diff += (wakeups * is->wu_energy >> 10) + * unused_util_aft/new_state->cap; } /* @@ -4516,6 +4527,8 @@ static int energy_diff_util(int cpu, int util) /* Energy after */ nrg_diff += (aff_util_aft*new_state->power)/new_state->cap; nrg_diff += (unused_util_aft * is->power)/new_state->cap; + nrg_diff += (wakeups * is->wu_energy >> 10) + * unused_util_aft/new_state->cap; } unlock: @@ -4532,8 +4545,8 @@ static int energy_diff_task(int cpu, struct task_struct *p) if (!cpumask_test_cpu(cpu, tsk_cpus_allowed(p))) return INT_MAX; - return energy_diff_util(cpu, p->se.avg.uw_load_avg_contrib); - + return energy_diff_util(cpu, p->se.avg.uw_load_avg_contrib, + p->se.avg.wakeup_avg_sum); } static int wake_wide(struct task_struct *p)