From patchwork Mon Jul 21 13:02:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 33963 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oi0-f71.google.com (mail-oi0-f71.google.com [209.85.218.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id BFBB920672 for ; Mon, 21 Jul 2014 13:03:39 +0000 (UTC) Received: by mail-oi0-f71.google.com with SMTP id e131sf14404176oig.10 for ; Mon, 21 Jul 2014 06:03:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=3JOjrCssYUoudvRdVoBB3jwIewkQU4OrfzkPh3bcLGs=; b=lSiWUwwTU/otmWDbZc+rGMMHwsZKEg49FDzO5JLsA5QN2cw2U03qdxjv6KPkhxGGAR EAgEP0DQFZ+dmUWu5BA6umSPB7DzFAnTHD102qUEwj1ZIc2jkZerUmg1qMgQxM0GN+X6 KdK5V8rNnjz7kKp9PDYg6y2fUp7YEAE3A0wT9/OaeEIfJwop4zEGn5VO/h3u3Sq/Dpwb 5xEZZeFn5E40OZNwHE5TmQ2HthsHEJpFM3rUuiSjIQyQ1awiGs9dWySd/RCzLYVck9zT ZwNzLdXBtmtEFANCr2YmldpfbY7FeabHB6++c+uCNyvI51mBxza+h6zhcEqg87A2fXm9 bHlA== X-Gm-Message-State: ALoCoQlizgvIUh4cK1gnY443VpXFmvy/uWZUA2UvaUlnky7m9qnx4Pu51KE2E3koCyNQdmrRd8Dh X-Received: by 10.182.134.225 with SMTP id pn1mr12940752obb.31.1405947818556; Mon, 21 Jul 2014 06:03:38 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.18.194 with SMTP id 60ls1821253qgf.7.gmail; Mon, 21 Jul 2014 06:03:38 -0700 (PDT) X-Received: by 10.220.46.5 with SMTP id h5mr2329119vcf.55.1405947818357; Mon, 21 Jul 2014 06:03:38 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id ve5si11253795vcb.57.2014.07.21.06.03.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Jul 2014 06:03:34 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id hy4so11935138vcb.41 for ; Mon, 21 Jul 2014 06:03:34 -0700 (PDT) X-Received: by 10.221.47.9 with SMTP id uq9mr11682542vcb.48.1405947814110; Mon, 21 Jul 2014 06:03:34 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp110379vcb; Mon, 21 Jul 2014 06:03:33 -0700 (PDT) X-Received: by 10.68.171.37 with SMTP id ar5mr14366396pbc.61.1405947813101; Mon, 21 Jul 2014 06:03:33 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si7113202pdm.193.2014.07.21.06.03.32 for ; Mon, 21 Jul 2014 06:03:32 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932393AbaGUNDb (ORCPT + 13 others); Mon, 21 Jul 2014 09:03:31 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:42488 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932285AbaGUNCo (ORCPT ); Mon, 21 Jul 2014 09:02:44 -0400 Received: by mail-ie0-f172.google.com with SMTP id lx4so6759868iec.17 for ; Mon, 21 Jul 2014 06:02:44 -0700 (PDT) X-Received: by 10.42.38.137 with SMTP id c9mr4896416ice.94.1405947764014; Mon, 21 Jul 2014 06:02:44 -0700 (PDT) Received: from localhost.localdomain (c-24-245-18-91.hsd1.mn.comcast.net. [24.245.18.91]) by mx.google.com with ESMTPSA id ri8sm38580163igc.0.2014.07.21.06.02.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Jul 2014 06:02:43 -0700 (PDT) From: Alex Elder To: akpm@linux-foundation.org Cc: kay@vrfy.org, pmladek@suse.cz, bp@suse.de, john.stultz@linaro.org, jack@suse.cz, linux-kernel@vger.kernel.org Subject: [PATCH v5 6/7] printk: honor LOG_PREFIX in msg_print_text() Date: Mon, 21 Jul 2014 08:02:40 -0500 Message-Id: <1405947761-26004-7-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1405947761-26004-1-git-send-email-elder@linaro.org> References: <1405947761-26004-1-git-send-email-elder@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: elder@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch fixes a problem similar to what was addressed in the previous patch. All paths that read and format log records (for consoles, and for reading via syslog and /dev/kmsg) go through msg_print_text(). That function starts with some logic to determine whether the given log record when formatted should begin with a "prefix" string, and whether it should end with a newline. That logic has a bug. The LOG_PREFIX flag in a log record indicates that when it's formatted, a log record should include a prefix. This is used to force a record to begin a new line--even if its preceding log record contained LOG_CONT (indicating its content should be combined with the next record). Like the previous patch, the problem occurs when these flags are all set: prev & LOG_CONT msg->flags & LOG_PREFIX msg->flags & LOG_CONT In that case, "prefix" should be true but it is not. The fix involves checking LOG_PREFIX when a message has its LOG_CONT flag set, and in that case allowing "prefix" to become false only if LOG_PREFIX is not set. I.e., the logic for "prefix" would become: if (prev & LOG_CONT && !(msg->flags & LOG_PREFIX)) prefix = false; if (msg->flags & LOG_CONT) if (prev & LOG_CONT && !(msg->flags & LOG_PREFIX)) prefix = false; However, note that this makes the (msg->flags & LOG_CONT) block redunant--it's handled by the test just above it. The result becomes quite a bit simpler than before. The following table concisely defines the problem: prev | msg | msg || CONT |PREFIX| CONT ||prefix ------+------+------++------ clear| clear| clear|| true clear| clear| set || true clear| set | clear|| true clear| set | set || true set | clear| clear|| false set | clear| set || false set | set | clear|| true set | set | set || false <-- should be true Signed-off-by: Alex Elder Reviewed-by: Petr Mládek --- kernel/printk/printk.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index e9e5104..cbcfb20 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -1010,11 +1010,8 @@ static size_t msg_print_text(const struct printk_log *msg, enum log_flags prev, if ((prev & LOG_CONT) && !(msg->flags & LOG_PREFIX)) prefix = false; - if (msg->flags & LOG_CONT) { - if (prev & LOG_CONT) - prefix = false; + if (msg->flags & LOG_CONT) newline = false; - } if ((prev & LOG_CONT) && (msg->flags & LOG_PREFIX) && len < size) { if (buf)