From patchwork Mon Sep 15 17:55:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 37422 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f69.google.com (mail-ee0-f69.google.com [74.125.83.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5D0A8206A5 for ; Mon, 15 Sep 2014 17:57:01 +0000 (UTC) Received: by mail-ee0-f69.google.com with SMTP id t10sf2504050eei.8 for ; Mon, 15 Sep 2014 10:57:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type; bh=2t9shLkbJZ6XDkVLTzRD5ivP2jyklSHwR9JniW1RyXU=; b=lz5l2AqebQqZZwpBtiFpjjUx9KVRstw0AyEMids+sFh1F8gqDk1ULa0DoTPNVaxfaw tjDrJZjaaPmAluVa/NMqAAZdiYX1SJMsZHApXRndcr6z3/bpYxtfNoO8IDNqnotr5L34 ctKMtZbAZRjjySTSvRAZyEuPbRZzPl1M1Ec4Co5T9feY7Pqqd2npBzhYKM6r+t3WZh78 DxasfCFbuWmsSXkfXz5IcOWboX9B/0810pmfTTbzFscu9OCA8Za+W9/IhA1/JDNqllfR F8ZLuBUd1UT2vUnhv4EPZJroulXhSMvgKLEn2ny3A4ba4fNbfKF3hfWyMktKyci1SyIZ gAJg== X-Gm-Message-State: ALoCoQmqx7kAlG+tpRbKfakmLr9iqlpkpTYNBfF13bEIkSCTNeyi26hVbN41rFvUyq8yidaWAwDp X-Received: by 10.112.50.47 with SMTP id z15mr4176lbn.19.1410803819247; Mon, 15 Sep 2014 10:56:59 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.120.227 with SMTP id lf3ls413268lab.101.gmail; Mon, 15 Sep 2014 10:56:58 -0700 (PDT) X-Received: by 10.152.36.101 with SMTP id p5mr30401179laj.31.1410803818845; Mon, 15 Sep 2014 10:56:58 -0700 (PDT) Received: from mail-la0-f48.google.com (mail-la0-f48.google.com [209.85.215.48]) by mx.google.com with ESMTPS id wr3si20354669lac.3.2014.09.15.10.56.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 15 Sep 2014 10:56:58 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) client-ip=209.85.215.48; Received: by mail-la0-f48.google.com with SMTP id ty20so5119963lab.21 for ; Mon, 15 Sep 2014 10:56:56 -0700 (PDT) X-Received: by 10.112.75.233 with SMTP id f9mr4845868lbw.102.1410803816809; Mon, 15 Sep 2014 10:56:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp259218lbb; Mon, 15 Sep 2014 10:56:56 -0700 (PDT) X-Received: by 10.68.179.66 with SMTP id de2mr41863379pbc.31.1410803815357; Mon, 15 Sep 2014 10:56:55 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id tl10si1921895pac.46.2014.09.15.10.56.54 for ; Mon, 15 Sep 2014 10:56:55 -0700 (PDT) Received-SPF: none (google.com: linux-input-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754040AbaIOR4x (ORCPT ); Mon, 15 Sep 2014 13:56:53 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:57125 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753348AbaIOR4w (ORCPT ); Mon, 15 Sep 2014 13:56:52 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s8FHuGO7002005; Mon, 15 Sep 2014 12:56:16 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8FHuGI2020373; Mon, 15 Sep 2014 12:56:16 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Mon, 15 Sep 2014 12:56:15 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8FHuFP6008070; Mon, 15 Sep 2014 12:56:15 -0500 From: Nishanth Menon To: Dmitry Torokhov CC: , , , , , Nishanth Menon , Julia Lawal , Dan Carpenter Subject: [PATCH] Input: palmas-pwrbutton: Fix IRQ flags for using threaded handler alone. Date: Mon, 15 Sep 2014 12:55:58 -0500 Message-ID: <1410803758-26906-1-git-send-email-nm@ti.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: nm@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , make C=2 CHECK="scripts/coccicheck" MODE=report COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci ./drivers/input/misc/palmas-pwrbutton.o Reports: drivers/input/misc/palmas-pwrbutton.c:213:9-29: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Palmas powerbutton just needs threaded IRQ handler since I2C operations are involved and there is nothing in non-threaded primary handler we could do. So mark the request with ONESHOT as it should have been done in these cases. Cc: Julia Lawal Cc: Dan Carpenter Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton") Reported-by: kbuild test robot Signed-off-by: Nishanth Menon --- drivers/input/misc/palmas-pwrbutton.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c index 4ed6f78..c0c4636 100644 --- a/drivers/input/misc/palmas-pwrbutton.c +++ b/drivers/input/misc/palmas-pwrbutton.c @@ -211,8 +211,8 @@ static int palmas_pwron_probe(struct platform_device *pdev) pwron->irq = platform_get_irq(pdev, 0); error = request_threaded_irq(pwron->irq, NULL, pwron_irq, - IRQF_TRIGGER_HIGH | IRQF_TRIGGER_LOW, - dev_name(dev), pwron); + IRQF_TRIGGER_HIGH | IRQF_TRIGGER_LOW | + IRQF_ONESHOT, dev_name(dev), pwron); if (error) { dev_err(dev, "Can't get IRQ for pwron: %d\n", error); goto err_free_input;