From patchwork Thu Sep 25 03:14:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wangyijing X-Patchwork-Id: 37905 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f72.google.com (mail-ee0-f72.google.com [74.125.83.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6529120063 for ; Thu, 25 Sep 2014 02:56:53 +0000 (UTC) Received: by mail-ee0-f72.google.com with SMTP id c13sf4508108eek.3 for ; Wed, 24 Sep 2014 19:56:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=mdCvL/Icn3yClUXAga5FWvASZ1ICagoGHKFMgzu6js4=; b=f3Jci1O8vBtWPpMmcGszwO9Laa1y3mbd7iiOAOImSkdMfx+CDs9OIyDEnQUM+OksZ1 PqBc3C5dCcLMe6XIPawAttXyyPI4n1A81es76O6RTRR9og9Zgt7Wfij6KS094v4otyJo fOuyrCOTl54rY0wLYsQiK38rLeqB0LMGYWRuWUuIkNZmuIWHzNquTMaIaCkOWzDnfj+k hrEKJLrjETyZj/vyTs6vekJyOLnfgOt/nz4hGwoKRSjAJZqbMZJZXwsTZQvrZYvLpOz2 BUxQrw0KofbQRu65vq/jFtZx1F569KFcfZrVYiL6oPu2iyUx2hvtJJPQuQhhkPQMCBZN 8S+w== X-Gm-Message-State: ALoCoQldNqTuxHOE7pYQdAnoAqh7LaNeQNlyOCXMA77vnXJgb60+roCL8HsTY0gVT/VZyYDDFiDB X-Received: by 10.194.121.72 with SMTP id li8mr1606035wjb.1.1411613812523; Wed, 24 Sep 2014 19:56:52 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.27.201 with SMTP id v9ls231702lag.40.gmail; Wed, 24 Sep 2014 19:56:52 -0700 (PDT) X-Received: by 10.152.4.97 with SMTP id j1mr9980986laj.73.1411613812254; Wed, 24 Sep 2014 19:56:52 -0700 (PDT) Received: from mail-la0-f46.google.com (mail-la0-f46.google.com [209.85.215.46]) by mx.google.com with ESMTPS id ba3si1056322lbc.92.2014.09.24.19.56.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Sep 2014 19:56:52 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) client-ip=209.85.215.46; Received: by mail-la0-f46.google.com with SMTP id gi9so1487460lab.33 for ; Wed, 24 Sep 2014 19:56:52 -0700 (PDT) X-Received: by 10.152.197.35 with SMTP id ir3mr10395917lac.82.1411613812155; Wed, 24 Sep 2014 19:56:52 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp683655lbb; Wed, 24 Sep 2014 19:56:51 -0700 (PDT) X-Received: by 10.66.244.107 with SMTP id xf11mr1887179pac.36.1411613810627; Wed, 24 Sep 2014 19:56:50 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gy2si1225112pbb.106.2014.09.24.19.56.49 for ; Wed, 24 Sep 2014 19:56:50 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbaIYCzl (ORCPT + 27 others); Wed, 24 Sep 2014 22:55:41 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:41591 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbaIYCux (ORCPT ); Wed, 24 Sep 2014 22:50:53 -0400 Received: from 172.24.2.119 (EHLO szxeml409-hub.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BZX30346; Thu, 25 Sep 2014 10:50:36 +0800 (CST) Received: from localhost.localdomain (10.175.100.166) by szxeml409-hub.china.huawei.com (10.82.67.136) with Microsoft SMTP Server id 14.3.158.1; Thu, 25 Sep 2014 10:50:23 +0800 From: Yijing Wang To: Bjorn Helgaas CC: , , Xinwei Hu , Wuyun , , Russell King , , , , , Arnd Bergmann , Thomas Gleixner , "Konrad Rzeszutek Wilk" , , Joerg Roedel , , , Benjamin Herrenschmidt , , , Sebastian Ott , "Tony Luck" , , "David S. Miller" , , Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , "Sergei Shtylyov" , Michael Ellerman , Thierry Reding , "Thomas Petazzoni" , Yijing Wang Subject: [PATCH v2 03/22] MSI: Remove the redundant irq_set_chip_data() Date: Thu, 25 Sep 2014 11:14:13 +0800 Message-ID: <1411614872-4009-4-git-send-email-wangyijing@huawei.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.166] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: wangyijing@huawei.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Currently, pcie-designware, pcie-rcar, pci-tegra drivers use irq chip_data to save the msi_chip pointer. They already call irq_set_chip_data() in their own MSI irq map functions. So irq_set_chip_data() in arch_setup_msi_irq() is useless. Signed-off-by: Yijing Wang Reviewed-by: Thierry Reding --- drivers/pci/msi.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 51d7e62..50f67a3 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -41,14 +41,13 @@ int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc) if (err < 0) return err; - irq_set_chip_data(desc->irq, chip); - return 0; } void __weak arch_teardown_msi_irq(unsigned int irq) { - struct msi_chip *chip = irq_get_chip_data(irq); + struct msi_desc *entry = irq_get_msi_desc(irq); + struct msi_chip *chip = entry->dev->bus->msi; if (!chip || !chip->teardown_irq) return;