From patchwork Sun Oct 25 23:21:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 55517 Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp896717lbq; Sun, 25 Oct 2015 16:22:19 -0700 (PDT) X-Received: by 10.68.234.230 with SMTP id uh6mr18857303pbc.19.1445815338272; Sun, 25 Oct 2015 16:22:18 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id sd5si48635854pbc.26.2015.10.25.16.22.18; Sun, 25 Oct 2015 16:22:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752598AbbJYXWH (ORCPT + 28 others); Sun, 25 Oct 2015 19:22:07 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37899 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485AbbJYXVz (ORCPT ); Sun, 25 Oct 2015 19:21:55 -0400 Received: by wicll6 with SMTP id ll6so92028752wic.1 for ; Sun, 25 Oct 2015 16:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fs7dByT0spA/DtsdNxo2iVfgSqzanjM1H7hmjV41xew=; b=04E6hxvNGg8Rquxb/IIzqdNFKe+5bj6EVWPJ/pESQz4qfREFy2rCUlYHLuaARtO8Mc m5SdqNm9EGB59JkmVDDAvFs6Ln7lr4qPvQ73MRsGPCz0Wq9dyWzTu5QUbqQTwtOrdOVQ 7mE7nXL8H+F8EemVwuwfSu0JfJqHZC6PO/te7/hYn4xUhQAXXbfGep7v1R8wb6u7nJik Q7isyJJFiFTegp2FSQl+uql1rOu+BzuUk+ALkceDJC4JS24m4iVpYnl1VSL3SkX4wvFW hXktuYNj/l6keiMY23uhqrpgixdSL1WGy8cJXvrjP1vhWckvOAwZRQsSdVAPsf/l39mP lGxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fs7dByT0spA/DtsdNxo2iVfgSqzanjM1H7hmjV41xew=; b=KNzy/i6cJvITdXD0mH/YBgnfWicLHCpo9yiAuv0CpQYaxRNW4PgCYJDZZ5h6Ngy490 Nixx+h69P2/lNY+AQPf9eI9+hJN9WxzHrM/u5hM2oFWfcZp1Y2Omwmss8EKFfRkBtTo3 8qoXe7FJwibJgQKj8tXNwED7FHiaPX+ZlGcFhhaSOELBf+lYp+SYA9IFW4jbtiIO+Upu wTMDWaW7smoi3pc03BdmpBFG6lV6nSm+S6QaI/JvfyQY3BLYehN0WxIuXjOZ2qSkAZRB BngnJwl8mTWM8+VAtqNFjdp8ivMbo8URsxU2nBTGH6/PGiuhdmG8odvOVdbTh6icz8QU PErw== X-Gm-Message-State: ALoCoQmhNShZXn2MzW0AEALldz+Xl+QpPBrTb1BTOboEf8PWljp0A/z7qjN796QW4MoYrmWGm7cz X-Received: by 10.194.76.178 with SMTP id l18mr16888877wjw.75.1445815313919; Sun, 25 Oct 2015 16:21:53 -0700 (PDT) Received: from mtux.lan (host-2-101-188-230.as13285.net. [2.101.188.230]) by smtp.gmail.com with ESMTPSA id jj8sm11712633wid.2.2015.10.25.16.21.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 25 Oct 2015 16:21:53 -0700 (PDT) From: Alexey Klimov To: daniel.lezcano@linaro.org, matthias.bgg@gmail.com, linux-kernel@vger.kernel.org, joe@perches.com Cc: linux-mediatek@lists.infradead.org, yingjoe.chen@mediatek.com, tglx@linutronix.de, klimov.linux@gmail.com, Alexey Klimov Subject: [PATCH v3 2/3] clocksource: mtk_timer: fix pr_warn() messages in mtk_timer_init Date: Sun, 25 Oct 2015 23:21:23 +0000 Message-Id: <1445815284-10425-2-git-send-email-alexey.klimov@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1445815284-10425-1-git-send-email-alexey.klimov@linaro.org> References: <1445815284-10425-1-git-send-email-alexey.klimov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 1) Change pr_warn()s to pr_err()s. These messages are actually errors and not warnings. 2) Add missing \n. 3) Error message for kzalloc() failure is removed per suggestion by Joe Perches. There is generic stack_dump() for allocation issues. Signed-off-by: Alexey Klimov --- Changes in v3: -- small cleanup Changes in v2: -- remove message on allocation failure drivers/clocksource/mtk_timer.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c index ca5ea9e..4ddddf4 100644 --- a/drivers/clocksource/mtk_timer.c +++ b/drivers/clocksource/mtk_timer.c @@ -183,10 +183,8 @@ static void __init mtk_timer_init(struct device_node *node) struct clk *clk; evt = kzalloc(sizeof(*evt), GFP_KERNEL); - if (!evt) { - pr_warn("Can't allocate mtk clock event driver struct"); + if (!evt) return; - } evt->dev.name = "mtk_tick"; evt->dev.rating = 300; @@ -200,24 +198,24 @@ static void __init mtk_timer_init(struct device_node *node) evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer"); if (IS_ERR(evt->gpt_base)) { - pr_warn("Can't get resource\n"); + pr_err("Can't get resource\n"); return; } evt->dev.irq = irq_of_parse_and_map(node, 0); if (evt->dev.irq <= 0) { - pr_warn("Can't parse IRQ"); + pr_err("Can't parse IRQ\n"); goto err_mem; } clk = of_clk_get(node, 0); if (IS_ERR(clk)) { - pr_warn("Can't get timer clock"); + pr_err("Can't get timer clock\n"); goto err_irq; } if (clk_prepare_enable(clk)) { - pr_warn("Can't prepare clock"); + pr_err("Can't prepare clock\n"); goto err_clk_put; } rate = clk_get_rate(clk); @@ -226,7 +224,7 @@ static void __init mtk_timer_init(struct device_node *node) if (request_irq(evt->dev.irq, mtk_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL, "mtk_timer", evt)) { - pr_warn("failed to setup irq %d\n", evt->dev.irq); + pr_err("failed to setup irq %d\n", evt->dev.irq); goto err_clk_disable; }