From patchwork Tue Jan 12 14:24:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 59630 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp2768878lbb; Tue, 12 Jan 2016 06:26:35 -0800 (PST) X-Received: by 10.98.89.139 with SMTP id k11mr34835740pfj.82.1452608795511; Tue, 12 Jan 2016 06:26:35 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id lp4si27317709pab.205.2016.01.12.06.26.35; Tue, 12 Jan 2016 06:26:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762417AbcALO0d (ORCPT + 29 others); Tue, 12 Jan 2016 09:26:33 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:33372 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761157AbcALO0c (ORCPT ); Tue, 12 Jan 2016 09:26:32 -0500 Received: by mail-wm0-f54.google.com with SMTP id f206so256153184wmf.0 for ; Tue, 12 Jan 2016 06:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=wswmnIhjgqdoDgmrZAYSsykhAu8yUz6wrwVrF9ZINEU=; b=kDZN8ooRTJeEEqlYPX7ULtM45BtY3LTGKgY5HGob1hrLR9tboKd0x91NYmrcIigF0D kXeEKOuFpOMoODA/npTVBSsNbqRcOfZRgzZYxrxFRw+Xofzxs3hgK+cwruuvvDYRUKGJ KeMXVL0Mmyl3sDpDDXi9VYDKBSg610WSmF1eg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wswmnIhjgqdoDgmrZAYSsykhAu8yUz6wrwVrF9ZINEU=; b=HwYXDAsx1yQ/n18ezB6v7fBXWG8lK/ASJt44kFOgFUIYTxvy/CoehfqZF36fYf+1Sr +6P+6uSwHUuao5/OkorMQ7IFsWSDmaNgnCrTKQ0nCeR1ouii4NbxCtVWN/rO7aopzqfA uAAJwg/rGFvrXM/teDGTfJhw1Mv1XcG9ZaBu9WVowl3fDeXYFqXKjyje3Qzz57gGAnkk B4+iVUioLoGhVci4zp4jj6DRGM2JUG5oCDaWbspuRBmbUVU3KVuz97wdXg0q5njPEE8p CzH+XFU+PwrtoA8GIkqda+nGecpgl/zYPSqcGGt8pF2Hc5M35qXOHNULUNm/vbTZqsrP ocjQ== X-Gm-Message-State: ALoCoQmBM8VjmZI0DdSUNL6h1E/kSpY14HqlsbNJiPcynxOqK3lLgo2Jycg6k+o1XiHP4AcoVjtlej3H8j81iCHzuFCalvAIAw== X-Received: by 10.28.145.204 with SMTP id t195mr20623609wmd.91.1452608790843; Tue, 12 Jan 2016 06:26:30 -0800 (PST) Received: from localhost.localdomain ([217.46.108.250]) by smtp.gmail.com with ESMTPSA id lh1sm2492606wjb.20.2016.01.12.06.26.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jan 2016 06:26:30 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@stlinux.com, maxime.coquelin@st.com, mmarek@suse.com, linux-kbuild@vger.kernel.org, arnd@arndb.de, Lee Jones Subject: [PATCH] kbuild: Demote 'sign-compare' warning to W=2 Date: Tue, 12 Jan 2016 14:24:18 +0000 Message-Id: <1452608658-28190-1-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ideally, a kernel compile with W=1 enabled should complete cleanly; however, when we run one currently we are presented with ~25k warnings. 'sign-compare' accounts for ~22k of those ~25k. In this patch we're demoting 'sign-compare' warnings to W=2, with a view to fixing the remaining 3k W=1 warnings required for a clean build. Arnd adds: "As per our discussion, I'd add that this was inadvertedly introduced by Behan when he moved the clang specific warnings into an ifdef block and did not notice that -Wsign-compare was interpreted by both gcc and clang. Earlier, it was introduced in just the same way by Jan-Simon as part of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation with clang")." Acked-by: Arnd Bergmann Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3") Signed-off-by: Lee Jones --- scripts/Makefile.extrawarn | 2 ++ 1 file changed, 2 insertions(+) -- 1.9.1 diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 4efedcb..f9e47a7 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -25,6 +25,7 @@ warning-1 += -Wold-style-definition warning-1 += $(call cc-option, -Wmissing-include-dirs) warning-1 += $(call cc-option, -Wunused-but-set-variable) warning-1 += $(call cc-disable-warning, missing-field-initializers) +warning-1 += $(call cc-disable-warning, sign-compare) warning-2 := -Waggregate-return warning-2 += -Wcast-align @@ -33,6 +34,7 @@ warning-2 += -Wnested-externs warning-2 += -Wshadow warning-2 += $(call cc-option, -Wlogical-op) warning-2 += $(call cc-option, -Wmissing-field-initializers) +warning-2 += $(call cc-option, -Wsign-compare) warning-3 := -Wbad-function-cast warning-3 += -Wcast-qual