From patchwork Mon Feb 1 17:27:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 60944 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp169785lbb; Mon, 1 Feb 2016 09:28:11 -0800 (PST) X-Received: by 10.98.1.203 with SMTP id 194mr40505481pfb.10.1454347691789; Mon, 01 Feb 2016 09:28:11 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id lm9si25369567pab.142.2016.02.01.09.28.11; Mon, 01 Feb 2016 09:28:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754354AbcBAR2J (ORCPT + 30 others); Mon, 1 Feb 2016 12:28:09 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38066 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754317AbcBAR2E (ORCPT ); Mon, 1 Feb 2016 12:28:04 -0500 Received: by mail-wm0-f41.google.com with SMTP id p63so82086094wmp.1 for ; Mon, 01 Feb 2016 09:28:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oVvMNmHaoraL9nFS5VsUETlKiNQsDxKVMFJ9DsKm/3Q=; b=EHcg8upk7Et0AyLUBvNDlJpP8wCE7/QMUwdQZCCqhCk1EuQsUk1jET8qJmSfEjBgAP RUS3k3DlfcjyBiKk29BuCIw9rcRMlWcl624nsCFafgPgbO2+QOtse4WZmn8irMILl1Ut YWRjT4/gHXIpQ9JcI/OLfCqK0aMvR5Q0aHuns= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oVvMNmHaoraL9nFS5VsUETlKiNQsDxKVMFJ9DsKm/3Q=; b=A+Ra5Ms0bHh36IPuO+0O4zcakDfFsl57EgVZy3mBj2JFXc1vF0rTkE2Z3uCtu37xFN a2WkqBbyzAObtfsm41jkN2owKwjC+PJxQcTpEXrzV2g5/M57IzAZ/l91CoE8iDAAwdca XbWLwWbeIvBP1kvEVK/YHNqsjPhKc/pgMGb2LP3EOS1yXnhD63HvkZxGvuu9vwSt8wNO TUOccX7m4pHC3TTnzfG3ADe2Xv+3Gna7i1ze67K5IQMjoL9xriR8qZQ/mvmEMzod69sy RAbAEpH8mD8OE20t717ekAn61lBWLVKgpBrBm9li3RMfN+HHEEuqUMZKTnm2syvc38Cz x+wQ== X-Gm-Message-State: AG10YOQzVXurnpdNB079wBsU3l0a+wjqj8wuc8d5S//ScyzpLf55LbmNxitwb+KaC+8QQL30 X-Received: by 10.195.11.35 with SMTP id ef3mr23500842wjd.35.1454347683398; Mon, 01 Feb 2016 09:28:03 -0800 (PST) Received: from localhost.localdomain (host-92-13-246-184.as43234.net. [92.13.246.184]) by smtp.gmail.com with ESMTPSA id u4sm30126419wjz.4.2016.02.01.09.28.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Feb 2016 09:28:02 -0800 (PST) From: Srinivas Kandagatla To: Patrick Lai , alsa-devel@alsa-project.org Cc: Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH RFC 01/15] ASoC: qcom: use snd_dma_alloc/free* apis Date: Mon, 1 Feb 2016 17:27:59 +0000 Message-Id: <1454347680-10307-1-git-send-email-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1454347622-9970-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1454347622-9970-1-git-send-email-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no point in having local allocation functions when the driver can use snd_dma_alloc/free() apis. This patch replaces the local versions of the dma allocation apis with the snd_dma_alloc/free() apis. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/lpass-platform.c | 41 +++++------------------------------------ 1 file changed, 5 insertions(+), 36 deletions(-) -- 1.9.1 diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c index 4aeb8e1..a6dce1b 100644 --- a/sound/soc/qcom/lpass-platform.c +++ b/sound/soc/qcom/lpass-platform.c @@ -439,39 +439,6 @@ static irqreturn_t lpass_platform_lpaif_irq(int irq, void *data) return IRQ_HANDLED; } -static int lpass_platform_alloc_buffer(struct snd_pcm_substream *substream, - struct snd_soc_pcm_runtime *rt) -{ - struct snd_dma_buffer *buf = &substream->dma_buffer; - size_t size = lpass_platform_pcm_hardware.buffer_bytes_max; - - buf->dev.type = SNDRV_DMA_TYPE_DEV; - buf->dev.dev = rt->platform->dev; - buf->private_data = NULL; - buf->area = dma_alloc_coherent(rt->platform->dev, size, &buf->addr, - GFP_KERNEL); - if (!buf->area) { - dev_err(rt->platform->dev, "%s: Could not allocate DMA buffer\n", - __func__); - return -ENOMEM; - } - buf->bytes = size; - - return 0; -} - -static void lpass_platform_free_buffer(struct snd_pcm_substream *substream, - struct snd_soc_pcm_runtime *rt) -{ - struct snd_dma_buffer *buf = &substream->dma_buffer; - - if (buf->area) { - dma_free_coherent(rt->dev, buf->bytes, buf->area, - buf->addr); - } - buf->area = NULL; -} - static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime) { struct snd_pcm *pcm = soc_runtime->pcm; @@ -483,6 +450,7 @@ static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime) struct lpass_variant *v = drvdata->variant; int ret; struct lpass_pcm_data *data; + size_t size = lpass_platform_pcm_hardware.buffer_bytes_max; data = devm_kzalloc(soc_runtime->dev, sizeof(*data), GFP_KERNEL); if (!data) @@ -499,7 +467,8 @@ static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime) snd_soc_pcm_set_drvdata(soc_runtime, data); - ret = lpass_platform_alloc_buffer(substream, soc_runtime); + ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV, pcm->card->dev, + size, &substream->dma_buffer); if (ret) return ret; @@ -514,7 +483,7 @@ static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime) return 0; err_buf: - lpass_platform_free_buffer(substream, soc_runtime); + snd_dma_free_pages(&substream->dma_buffer); return ret; } @@ -533,7 +502,7 @@ static void lpass_platform_pcm_free(struct snd_pcm *pcm) if (v->free_dma_channel) v->free_dma_channel(drvdata, data->rdma_ch); - lpass_platform_free_buffer(substream, soc_runtime); + snd_dma_free_pages(&substream->dma_buffer); } static struct snd_soc_platform_driver lpass_platform_driver = {