From patchwork Thu Feb 11 14:23:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102812 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp222596lbl; Thu, 11 Feb 2016 06:25:08 -0800 (PST) X-Received: by 10.66.162.9 with SMTP id xw9mr66785379pab.46.1455200703487; Thu, 11 Feb 2016 06:25:03 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bs10si12923927pad.73.2016.02.11.06.25.03; Thu, 11 Feb 2016 06:25:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442AbcBKOZA (ORCPT + 30 others); Thu, 11 Feb 2016 09:25:00 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:52077 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378AbcBKOYr (ORCPT ); Thu, 11 Feb 2016 09:24:47 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0M580s-1a52Hn0pP4-00zGKh; Thu, 11 Feb 2016 15:24:17 +0100 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Gabriel Somlo , linux-kernel@vger.kernel.org Subject: [PATCH] firmware: qemu config needs I/O ports Date: Thu, 11 Feb 2016 15:23:51 +0100 Message-Id: <1455200650-4030091-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:eCwEZtDOdf7MWQk4mdlcQyaFa7P+4tRQ/lBsK+vDdJjVqEgbS/+ S5h87By/lGd4uSqfT179XbFbKSkV4AGh2uSY6iSkm3Bu9r0UmPO3hGs+EKKaKyb6nZ7B8/E 6q2OAuuNXlFg6/aTH067htnHshI728lRv66+/Hmdj9+X1QnPqeU6xz2cOcIU18xkOQRRbm6 Z/v/V9QeWWF+48JcsGfkQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:X/fsgEUll58=:oWnOY05I9xSz/CVq06k67+ BfMFUArU7I+ncgcB+9/W2aWK3islpQvewIwUWheq0cUxZwIC8/GuDmqoSduwbAsucmBiaUbkC pmKsnrWshx+ESvZBbu3kilr4svnDkDnITzPLed9LgVjrq2c3cLN7dpwokLG3mTWelKEFLvPU0 l95t+j6lTG94/oq4WGEzUxcD8ewmUlJXehtuHs7Y4sbrLhQNfoGoeu73v7OaPRwFZ0VEA/I7q T0wWwjgTt/KdxVNva7p5Qm8XvGHbfS/zQeNAhYUzSbxVNPhJpuX68e0ZskcvAPa4grbxUvl+T 2Dwnz2lIkRYgdpJLjoVMLYCHTjahbnOuNKT9TLbxADLQ3ZDmwixQjSTaxY4Y0fFA9nRN3AmE2 /bFTG7FBY+pKjyt3qaW4LdLn4Go0DxOyChMFMlwwtZBhKGW/ZH1spBQzTFWyqcJxN/oEW2Cys 4kjF62VHl0bN68mTheUSf8q0zC2JZy/fm05L2PyxZ4j0d5Rd9fiEvAJfUe/3lObxLyRe9I48e ta3Bt0Euv0kRnc8fFbPTsXtM0OpUzkbqBqtY4dZ7aCh3yuBFLhjV3musJnulwzll/bw9xPzjD BVCIAxkMOv4/dBBAZHv8IiSA3FwujP4tx857nPm+JlCY83MOnUozioZPJ1XBO6+UES/X9HdfX rOH15v1k87nQuEHqKehVxP6NgqkoBYh6ZcHreY+oHJM/3G/iM4m7y1dXXZWFYfUoAbjw= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Not all machines have PCI style I/O port memory, or they do not allow mapping it using the ioport_map() function, whcih results in a build error with the newly added qemu firmware code: drivers/firmware/built-in.o: In function `fw_cfg_io_cleanup': qemu_fw_cfg.c:(.text+0x144): undefined reference to `ioport_unmap' drivers/firmware/built-in.o: In function `fw_cfg_sysfs_probe': qemu_fw_cfg.c:(.text+0xb18): undefined reference to `ioport_map' This adds a Kconfig dependency to ensure the driver can only be built on platforms that support it. Signed-off-by: Arnd Bergmann Fixes: 75f3e8e47f38 ("firmware: introduce sysfs driver for QEMU's fw_cfg device") --- drivers/firmware/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.7.0 diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 5130f74ae3bd..6664f1108c7c 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -164,6 +164,7 @@ config RASPBERRYPI_FIRMWARE config FW_CFG_SYSFS tristate "QEMU fw_cfg device support in sysfs" depends on SYSFS && (ARM || ARM64 || PPC_PMAC || SPARC || X86) + depends on HAS_IOPORT_MAP default n help Say Y or M here to enable the exporting of the QEMU firmware