From patchwork Mon Mar 14 14:07:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102598 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp57529lbc; Mon, 14 Mar 2016 07:08:28 -0700 (PDT) X-Received: by 10.98.10.147 with SMTP id 19mr30272133pfk.87.1457964507339; Mon, 14 Mar 2016 07:08:27 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g29si24892012pfj.135.2016.03.14.07.08.27; Mon, 14 Mar 2016 07:08:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755676AbcCNOIP (ORCPT + 31 others); Mon, 14 Mar 2016 10:08:15 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:60943 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755505AbcCNOIL (ORCPT ); Mon, 14 Mar 2016 10:08:11 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue103) with ESMTPA (Nemesis) id 0Ld3z6-1ZxMtZ0BA8-00iBai; Mon, 14 Mar 2016 15:07:33 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Felix Fietkau , John Crispin , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] net: mediatek: check device_reset return code Date: Mon, 14 Mar 2016 15:07:12 +0100 Message-Id: <1457964435-2945038-3-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1457964435-2945038-1-git-send-email-arnd@arndb.de> References: <1457964435-2945038-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:moborJx9hta0ILrsffUY+DVapFVFp/NaPy9gpF0FQt1+Z87p9mo yXXiTxTtuuzquPPEjqEcgP63r74AYR+ZFhy5OWoQOkrLM9ATe3MIzWfUwtIv4igY3H4ue0V Bf3uW2wOyQJgERf3ROBA10Jeye7ORlt1ueyEA7DJXMqaJp+PBSHTYDVumqbAOPT0NB/sguO EXzgUoW3UKEgeMF2ObzDw== X-UI-Out-Filterresults: notjunk:1; V01:K0:trQ9PG6JotM=:0t8B34YwZMHkN18Xo6L+dO 9SZip44JvLowf8lzNKgNQnoVi9euTNwnxH36tqiPdJps5ijub5e78GSNsBE5W1YtxYmMLsHp+ y7CfUcPbs6o6iCmdx5N1VZ4vDRa2dsCcz7Z0oPFEEBqA27vT+F6F7vI80z73UKb4N76A6mfGC /aWCMraQkl9xJtagdx/82HPlTVrKF2MpUwWwKKkw/48c88FvnOVFNgHkLNy8hG2H9V87QDevq BnD8K5PCRAr7ZuJkD8ne1DGt0vD79b23uZz4MvqDmcEzbCJ39oA3by/x/jvQFXjIxfk7LuSL5 efk3WgUWmtIhQaG5yMcdy96CrzVj1tMCeVVBM+Y6M4Bb5KnSJ4uY8voI4lSi5EgZwJP+CamZN AJdcHfz05NDN+kqGY/7TeJArwTwIc4CeS92dZLT+FFkioJfAwRukBR9/gt22SdEirP93gsIdp 5Zxx7KGbPk6OILw/XrF3pSdsdrqu89mNKpGVZZs2gCWX+9kXuK1Ys3vioeCS5k54TzdvP0ixu SFBm7gSDlM6tz/YwMDRgN0NCd7/ZsRedVFOerUq+lIRFNz7CTyJiM+v70v7AkSt6V61cx9yWx one53RERQNqE2ra0Yy266eWCZYR5yu3BRdwJ32H3Wse+OejzyQaKBnUscPPNtkvHviL0lYIUe qhvRAkTM7d6+mPzUqDkE0wgU6Rv2xptB690AZM8S3qMXLThGCdHkvRAtc9UOfP/KB9lA= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device_reset() function may fail, so we have to check its return value, e.g. to make deferred probing work correctly. gcc warns about it because of the warn_unused_result attribute: drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_probe': drivers/net/ethernet/mediatek/mtk_eth_soc.c:1679:2: error: ignoring return value of 'device_reset', declared with attribute warn_unused_result [-Werror=unused-result] This adds the trivial error check to propagate the return value to the generic platform device probe code. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.7.0 diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 87f417712da0..1e6c5498bba9 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1676,7 +1676,9 @@ static int mtk_probe(struct platform_device *pdev) struct mtk_eth *eth; int err; - device_reset(&pdev->dev); + err = device_reset(&pdev->dev); + if (err) + return err; match = of_match_device(of_mtk_match, &pdev->dev); soc = (struct mtk_soc_data *)match->data;