From patchwork Mon Mar 14 14:21:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102595 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp65431lbc; Mon, 14 Mar 2016 07:22:03 -0700 (PDT) X-Received: by 10.66.102.8 with SMTP id fk8mr38504238pab.12.1457965322914; Mon, 14 Mar 2016 07:22:02 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g78si24095838pfd.130.2016.03.14.07.22.02; Mon, 14 Mar 2016 07:22:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965347AbcCNOWA (ORCPT + 31 others); Mon, 14 Mar 2016 10:22:00 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:51141 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934109AbcCNOV5 (ORCPT ); Mon, 14 Mar 2016 10:21:57 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue003) with ESMTPA (Nemesis) id 0MHtl3-1agqQ615Kf-003bLO; Mon, 14 Mar 2016 15:21:51 +0100 From: Arnd Bergmann To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Arnd Bergmann , Ralf Baechle , Paul Walmsley , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: [PATCH] Firmware: broadcom sprom: clarifiy SSB dependency Date: Mon, 14 Mar 2016 15:21:32 +0100 Message-Id: <1457965305-3258441-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:x0pDF1Js8HPOOfBa7kW7FOXb/xOHPIBTjfqcrzQkQUaNFUdB3/G tqsEQB87ei2KuuLXdnr/PznkVcgXBJFotEyoL6noz1wvshnHsewkFqZM+aeoATsFH1OQYVA qxS7bxLoK4YQixS43fvUeJNHHMSG1+1AnXslFyHHdCi4+JpPFtzUh3nOYmxVptJJ5+7r8kG yqEBaWWwBFgu5VrAvmk3w== X-UI-Out-Filterresults: notjunk:1; V01:K0:KcRIr5zMXAY=:zNAZhzWgi/tEklZ6mLy5Sq I2SjZf4hlDbOpaNIjWwqdjVMNfPt+jKOUPBSuzMoBmVqP21QuPrNUFJ8fC5+RiS41LrgdLbck LlFhzRieGznDa6qfkkk0HXRu7U8hpALAgxBp+YUBxy2YYJurv+/GnKSoCSXEvtmgfGSQy/wcc eFZXBZgSPugY3Wpw1hjTOy+uU0r9ZIHdcxcLWOgyKuaOQmRM1NUv27brbYDMGm6wgl21quvJ+ zXn7XVlGk5xH81wldaegkGQfehgsYdnkRWTMSnt9apjj0IrMHoBB4R2j29XbwL4UdDh9oNWKt hPykGoZltIA67ShZue+Ja21DxHIqHYr56ZCge5tIHTXbyXDfSqQn+W0Xb1VsrnZbAvxaeNxkA 8ZRMhWPChZJH3ICM4irPeaYcYWQRdfarJkUlGwVMVgfztiLwYyrwKCSvn5hZsEi6B78+eeXGq Rs/nNyDnVNO3kMYMVo/yrgU7oOXElM3H0fg1FhhnGrIX4AeewrHPr6hwB2z2nEh8ttqVi8+B+ KWqLJmEsIlCArvI3mFfRKQ+jrMuvq+F05lwKIFHolDfA6iLJCyplpMLsDTMu7v0e3ukt5yUZh nlY5Dc1ZjrPPQZZcfnpXPWMQSqyVqBwGHyisB1S78fW6Gl48eRIhxaz1rkSY9bRj5Wk3KLBeU x/Pb3FLgNOQDEqhl4Ur6fZ7ksaG75H8CtYWOcm++tQnkovP10QEm/aeZl6YhCNs2pSQQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The broadcom firmware drvier calls into the ssb SPROM code if that is enabled, but it fails if the SSB code is in a loadable module because the bcm47xx firmware is always built-in: drivers/firmware/built-in.o: In function `bcm47xx_sprom_register_fallbacks': bcm47xx_sprom.c:(.text+0x11c4): undefined reference to `ssb_arch_register_fallback_sprom' This adds a Kconfig dependency to ensure that we cannot turn on the generic sprom support if the ssb sprom is in a module. Signed-off-by: Arnd Bergmann --- drivers/firmware/broadcom/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.7.0 diff --git a/drivers/firmware/broadcom/Kconfig b/drivers/firmware/broadcom/Kconfig index 3c7e5b741e37..42f7d9bfb148 100644 --- a/drivers/firmware/broadcom/Kconfig +++ b/drivers/firmware/broadcom/Kconfig @@ -13,6 +13,7 @@ config BCM47XX_NVRAM config BCM47XX_SPROM bool "Broadcom SPROM driver" depends on BCM47XX_NVRAM + depends on SSB=y || SSB=n help Broadcom devices store configuration data in SPROM. Accessing it is specific to the bus host type, e.g. PCI(e) devices have it mapped in