From patchwork Tue Apr 26 22:10:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 66747 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp1858660qge; Tue, 26 Apr 2016 15:13:03 -0700 (PDT) X-Received: by 10.66.34.68 with SMTP id x4mr7052249pai.57.1461708783626; Tue, 26 Apr 2016 15:13:03 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j186si972602pfb.136.2016.04.26.15.13.03; Tue, 26 Apr 2016 15:13:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753429AbcDZWMv (ORCPT + 29 others); Tue, 26 Apr 2016 18:12:51 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:33081 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753018AbcDZWLA (ORCPT ); Tue, 26 Apr 2016 18:11:00 -0400 Received: by mail-io0-f182.google.com with SMTP id f89so29949866ioi.0 for ; Tue, 26 Apr 2016 15:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EtNcBxXXLFSqSbQKgS51h0atPqXBwWKubHky3jr9AIc=; b=EB+1ZhYeRbYKzGI3VODywvpJRzw47ArZbYN7ZPqm11m6H33HCtPCvjE6hAILN1tOvQ YdnhiosHE5m4pmVMzkEenpWZynqcb8Jn8vVP2A44iKslGD0cu33ZK5IQdLmDIxOOF/Wh KXGDDbZPhsXXN5eF6qHl3FMYZemQWOnX8V5CI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EtNcBxXXLFSqSbQKgS51h0atPqXBwWKubHky3jr9AIc=; b=d5WFm88nj7lRmOrXsWxmenZx+YfCrmS9KXiCAkFVCL6jC1i967kifNEUTuOhRe9J6W G7QZ1VMBzrrFnP+cEuKd2vTlsYLdRGbnTE4GHt+PTWoRxWeIMbQ4+87sCIfrqfFF0BMT ai2+yyFzkrZh1yXpAvCtYCEp6hudBCGd5aTb2Q8Z9lbLmUBuU9YkGfVwSnzPpNHEhGCF lflV16Wfi6rXwhKzkwtxmQgE8iLv6A1FmNSVYWpdzXNs3DyVtil63YMDJalNzsG5En/I RyOfZYLpu+sc5GPI0aJ6T+/rak16oBMLw6ks+2dHiKODhfp9JZ24n8ACd0FMhKK6Tr2O sEaA== X-Gm-Message-State: AOPr4FWw+E9KpbSEzUQvWEiUdjUp5xaypjkOS6Ac2DQAuPTffrKGgpeOGr2Dt7t8lMnRFhkc X-Received: by 10.107.46.158 with SMTP id u30mr6565952iou.162.1461708659420; Tue, 26 Apr 2016 15:10:59 -0700 (PDT) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id zd17sm2684818igc.8.2016.04.26.15.10.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Apr 2016 15:10:57 -0700 (PDT) From: Mathieu Poirier To: linux-arm-kernel@lists.infradead.org, Suzuki.Poulose@arm.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH V4 12/18] coresight: tmc: dump system memory content only when needed Date: Tue, 26 Apr 2016 16:10:28 -0600 Message-Id: <1461708634-6327-13-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1461708634-6327-1-git-send-email-mathieu.poirier@linaro.org> References: <1461708634-6327-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Calling tmc_etf/etr_dump_hw() is required only when operating from sysFS. When working from Perf, the system memory is harvested from the AUX trace API. Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-tmc-etf.c | 7 ++++++- drivers/hwtracing/coresight/coresight-tmc-etr.c | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) -- 2.5.0 diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c index bc0efc1e5b49..b5e5e6ac67eb 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c @@ -74,7 +74,12 @@ static void tmc_etb_disable_hw(struct tmc_drvdata *drvdata) CS_UNLOCK(drvdata->base); tmc_flush_and_stop(drvdata); - tmc_etb_dump_hw(drvdata); + /* + * When operating in sysFS mode the content of the buffer needs to be + * read before the TMC is disabled. + */ + if (local_read(&drvdata->mode) == CS_MODE_SYSFS) + tmc_etb_dump_hw(drvdata); tmc_disable_hw(drvdata); CS_LOCK(drvdata->base); diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c index 0c107811a232..7208584d0da7 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -76,7 +76,12 @@ static void tmc_etr_disable_hw(struct tmc_drvdata *drvdata) CS_UNLOCK(drvdata->base); tmc_flush_and_stop(drvdata); - tmc_etr_dump_hw(drvdata); + /* + * When operating in sysFS mode the content of the buffer needs to be + * read before the TMC is disabled. + */ + if (local_read(&drvdata->mode) == CS_MODE_SYSFS) + tmc_etr_dump_hw(drvdata); tmc_disable_hw(drvdata); CS_LOCK(drvdata->base);