From patchwork Wed May 4 09:50:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102386 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp82524qge; Wed, 4 May 2016 02:51:03 -0700 (PDT) X-Received: by 10.98.16.150 with SMTP id 22mr10660870pfq.165.1462355463671; Wed, 04 May 2016 02:51:03 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si3963167pfb.234.2016.05.04.02.51.03; Wed, 04 May 2016 02:51:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757439AbcEDJvA (ORCPT + 29 others); Wed, 4 May 2016 05:51:00 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:65088 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbcEDJu7 (ORCPT ); Wed, 4 May 2016 05:50:59 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue002) with ESMTPA (Nemesis) id 0M007w-1bnO4c2TtM-00uKT5; Wed, 04 May 2016 11:50:34 +0200 From: Arnd Bergmann To: Alessandro Zummo , Alexandre Belloni Cc: Arnd Bergmann , Michael Buesch , Mylene JOSSERAND , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH] rtc: rv3029: hide unused i2c device table Date: Wed, 4 May 2016 11:50:02 +0200 Message-Id: <1462355432-473635-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:TFu1NpshCJHGX2jIFLjHbOj/N0zh0fvc80fKov5BhxOyqgqY367 wR0A/QfIhvXN/Y/IhMNE1g+qeby9Kw2Nya8AWIdNIU+vcI+FLXGgFpFxWu/mxEAdNo3r/v7 GDWs2JSgv6kX0VjRQUJFeIL5Paq5gzisPuV7xQE3AW1OPEzSxgfl7PNRgKmMeF1YamJDwvo HeBOcIOOCEUcEYPslTiTQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Otaz3UplrQE=:NYf7jzDINl9MMFFbWiNooM a2Lt77p4uI43XRMh3XcLMNn8Iv2b5+Yl6e03DV/PZYaHPIdRMC4heKnEg59ggAj3vutfWmESH Jpp9WoWlPk1oq9HyIh+9IB3WEpkrVS57K13TdMk/0GF3shaPtzD0yfCGoebgTUf4ZfzHz/pz1 Q2OYhVv66z4CV+ZsljoOcvjAhG415QSpwc263WcZEY/rtqP5GggTC3h8nED5Yo8YZT4aZlGgI WkokoxwTBgY8KIRQ9TleXlIF9H+IHhLTB7Ljcp3Xuv3MHNG3yO/UZW8hsrk5618XyRkgrTDpM 35o1sQtzDtASsOrQjVwFM0IxvxZFHe04+QMdIIide+C6fsLw03oEvkBrPp3O6Epq/XUfpZdfD NjgOi2u5fDuKHXWCva/egs70UGHOVKR9dWJAnvL12Pfv2SmzJDdlYxZOjf8ZO/ax7LuPo/59b ywMOLExti/GIO72Bu/u4WmXiXeapfgSkDvWSdtA3WxXb6XY3ZZco3mLwmzmEXYTmIH2G1ZGh2 a6zurBz4Sxn47vF9jij5gqbmorVvwPxQS3EpZRX6TYpJtX0kHtPeuoZJwSwezFbQnjJDGx2AC /bZBT6rsJ3bR6OIQma0B3GgCFBsUTu/hbmZn79rH7Q7YSsdZ3EYiHV0+UvfORTYrd6KMWjzEa Q8KW+jNw1u5EMF7Xl5Dd26rk4Hq4Ypifrzy+FSdvKhkzh1Ei8GoVUBbB0qaQEqqd/pLw= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The added support for SPI mode made it possible to configure the driver when I2C is disabled, leaving an unused device table: drivers/rtc/rtc-rv3029c2.c:794:29: error: 'rv3029_id' defined but not used [-Werror=unused-variable] This moves the table inside of the #ifdef section that has the only user, to avoid the harmless warning. Signed-off-by: Arnd Bergmann Fixes: d08f50dd0afc ("rtc: rv3029: Add support of RV3049") --- drivers/rtc/rtc-rv3029c2.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.7.0 diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c index c2ef64fb4757..1f9f7b4bf3fb 100644 --- a/drivers/rtc/rtc-rv3029c2.c +++ b/drivers/rtc/rtc-rv3029c2.c @@ -791,13 +791,6 @@ static struct rtc_class_ops rv3029_rtc_ops = { .set_time = rv3029_set_time, }; -static struct i2c_device_id rv3029_id[] = { - { "rv3029", 0 }, - { "rv3029c2", 0 }, - { } -}; -MODULE_DEVICE_TABLE(i2c, rv3029_id); - static int rv3029_probe(struct device *dev, struct regmap *regmap, int irq, const char *name) { @@ -875,6 +868,13 @@ static int rv3029_i2c_probe(struct i2c_client *client, return rv3029_probe(&client->dev, regmap, client->irq, client->name); } +static struct i2c_device_id rv3029_id[] = { + { "rv3029", 0 }, + { "rv3029c2", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, rv3029_id); + static struct i2c_driver rv3029_driver = { .driver = { .name = "rtc-rv3029c2",