From patchwork Wed May 11 13:42:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102358 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp232976qge; Wed, 11 May 2016 06:42:51 -0700 (PDT) X-Received: by 10.66.47.196 with SMTP id f4mr4963481pan.126.1462974171335; Wed, 11 May 2016 06:42:51 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q11si9750948pfi.106.2016.05.11.06.42.50; Wed, 11 May 2016 06:42:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932691AbcEKNmt (ORCPT + 29 others); Wed, 11 May 2016 09:42:49 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:59101 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbcEKNmr (ORCPT ); Wed, 11 May 2016 09:42:47 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue102) with ESMTPA (Nemesis) id 0Lecso-1bPKFO36FS-00qQzZ; Wed, 11 May 2016 15:42:36 +0200 From: Arnd Bergmann To: Tejun Heo Cc: Arnd Bergmann , Mans Rullgard , Andy Shevchenko , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] ata: dwc: add DMADEVICES dependency Date: Wed, 11 May 2016 15:42:08 +0200 Message-Id: <1462974151-1467200-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:2bXS873x+5g2DxdOZgQFbNrjEeVdcM49dcVJhgmjS4+j8iZUc9P eb18WlW24i3Nfk645NqFCaHuiwa5Rvxhf3pQWybtzO8/2vVByuLqLpxEMWhXc4Aemw0UK39 9Wo9L1wVJifs6J6RhJkjgq+MsfnduBmuWOySetTqECWEMLFxSvpJqsvWdmLGuCWBNNSWyWj z1be7SFjjhKvZ7uD5BCBg== X-UI-Out-Filterresults: notjunk:1; V01:K0:GBgbv/AN1fw=:ExtpdHObiKqgrhZBJn3kIm cIcSefoTIzaz434CjzuVeaQEL7UcP9vcG4hOYpJAusPKMW3qM2plH5ap4kQ3qbYc6rj2AgU5l 3sGtNQ9K7xHfuDbhUFOugGxTfsUq5+yYfQNxMlcMJJft/co7uM7qS9lu+PrvVvsUBjQmcV8f2 5YF30agjMzepqmcKidMtmEQ2N/1t62STpyIbWhmYTKrcETXwrq8vG83wZLMjNWE4w3SULMa8r Xwngbv9QpvG2yF7Y69t0cZCRXdr+0MH5epZGN6kzRHK/V/fwQy1P0nGW4uZcgaaihmrpXiMhF p24gXGHsog9YYUHr0Zjdk5aW/Kuc+7TPInxg+62KTW4wYZ6T4URVb3i43eB9vRs13ibZSYJDX CdbFPDDODrCb9lA8eDmGg7E/KefV31R4zbElTAqFqF8hFWby36IQVK8MxYQ9fKATof/mCnBzC m4TCsylEhKdQmhAYe4ek5hAdRKiygX3xCldQycCv8jiAFlpgPDAvCPEieaMDk5CheMTOpFbW/ 0W50I/BkX38q9bcdjX8vLxTCL12SLbm/v6TOJN5xHueRlkdGvjJGVs7xTYeGaL+ghYGJMj+s5 h1FCpWPwCUNqfuPTKQQhxvjhXmGcmXJ00UPCH8InuySUwqVaxy6AJ9Uw0KBaQt73eC6ru+xpn X6QAOqt3wQ3AnrM0LhzLWD453GEgFyZRLzkPGFWzAHjhDzVFor1DgLVEQfoln7aI0STQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dwc_460ex SATA driver has become available on non-powerpc architectures and may cause randconfig build errors when CONFIG_DMADEVICES is not set and SATA_DWC_OLD_DMA is enabled: warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES) ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined! ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined! This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we cannot run into broken configurations. While it would also be possible to build the driver with both CONFIG_DMADEVICES and SATA_DWC_OLD_DMA disabled, that case is not useful because there is no fallback to PIO mode when the DMA engine is not usable. Signed-off-by: Arnd Bergmann Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel") --- drivers/ata/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.7.0 diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 41b0725e58ad..e2dc4c045146 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -313,6 +313,7 @@ config ATA_PIIX config SATA_DWC tristate "DesignWare Cores SATA support" + depends on DMADEVICES select GENERIC_PHY help This option enables support for the on-chip SATA controller of the