From patchwork Thu Aug 11 16:21:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 73796 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp192010qga; Thu, 11 Aug 2016 09:22:48 -0700 (PDT) X-Received: by 10.98.35.145 with SMTP id q17mr18761018pfj.42.1470932567840; Thu, 11 Aug 2016 09:22:47 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 80si3863952pfo.201.2016.08.11.09.22.47; Thu, 11 Aug 2016 09:22:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932941AbcHKQWi (ORCPT + 27 others); Thu, 11 Aug 2016 12:22:38 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:50310 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932504AbcHKQWc (ORCPT ); Thu, 11 Aug 2016 12:22:32 -0400 Received: from grover.sesame (FL1-119-242-215-193.osk.mesh.ad.jp [119.242.215.193]) (authenticated) by conuserg-09.nifty.com with ESMTP id u7BGM0x3020719; Fri, 12 Aug 2016 01:22:03 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com u7BGM0x3020719 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1470932524; bh=PJ8JuoTf2tm6vm9xm3MJYiTlIwqe16J+vuyC3LtVu2A=; h=From:To:Cc:Subject:Date:From; b=kcyap0fRbZ4ht/Yn8O2WiFtHCU1XxGWn2dbA7VPkeabEiICHuhJ3DjV53uS0w6IeM kYMYgtCB+wOVIulHrnxs+nAVAhKmgVFnEtUR5nkZE4IK5G/kjxY+DrQCNf6ojEWH7s z9ipO5DdE81E7VGOjH6Lo0h+viKM8clX7D/Phq9HDIXyHn53fTwCGFe5uUdXvSZLlS ImJhODpcPJbgylqBUDG1Z2yvCeY6eOcbbGE9jHwi1sAXxTXDwDh24lh7j1uakjwjEh hW6Bh0LFAL4tQgsJGfHUfzyHMPWguWt14drEcTIPI2bWoFDiaAhTJ7s/FuaEPc1JtB gb7V73BztYFPw== X-Nifty-SrcIP: [119.242.215.193] From: Masahiro Yamada To: linux-gpio@vger.kernel.org Cc: Masahiro Yamada , Linus Walleij , Alexandre Courbot , linux-kernel@vger.kernel.org Subject: [PATCH] gpio: refactor gpiochip_find() slightly Date: Fri, 12 Aug 2016 01:21:58 +0900 Message-Id: <1470932518-8748-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The if...else... block after the loop can be dropped with a slight refactoring. Signed-off-by: Masahiro Yamada --- drivers/gpio/gpiolib.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) -- 1.9.1 diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 53ff25a..deaf4d4 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1363,19 +1363,15 @@ struct gpio_chip *gpiochip_find(void *data, void *data)) { struct gpio_device *gdev; - struct gpio_chip *chip; + struct gpio_chip *chip = NULL; unsigned long flags; spin_lock_irqsave(&gpio_lock, flags); list_for_each_entry(gdev, &gpio_devices, list) - if (gdev->chip && match(gdev->chip, data)) + if (gdev->chip && match(gdev->chip, data)) { + chip = gdev->chip; break; - - /* No match? */ - if (&gdev->list == &gpio_devices) - chip = NULL; - else - chip = gdev->chip; + } spin_unlock_irqrestore(&gpio_lock, flags);