From patchwork Fri Aug 19 08:25:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Shi X-Patchwork-Id: 74214 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp195713qga; Fri, 19 Aug 2016 01:25:23 -0700 (PDT) X-Received: by 10.98.159.73 with SMTP id g70mr12031663pfe.121.1471595123813; Fri, 19 Aug 2016 01:25:23 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s25si3960581pfj.297.2016.08.19.01.25.23; Fri, 19 Aug 2016 01:25:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754158AbcHSIZV (ORCPT + 27 others); Fri, 19 Aug 2016 04:25:21 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34906 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbcHSIZT (ORCPT ); Fri, 19 Aug 2016 04:25:19 -0400 Received: by mail-pf0-f170.google.com with SMTP id x72so7331606pfd.2 for ; Fri, 19 Aug 2016 01:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=ST8TiD9N5E705sz2Vv6dwZTa9APm962IsJ4dY4xQRCY=; b=PQ1B8jbk+8UrH3IJ8D79JLd0alfHdvSu7I7y1n07mTU1ooxOWL2nJiVpGlCE75GVya fB96SfHWbLGvDl1fQm3kY0kIP1JpxjrPrMWEvPgxaEIjsg42zUuV9jtFIWoj8jKo9hIF ap20kLHdbu+yOfuon5v80/6MZeOTbqbleJhfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ST8TiD9N5E705sz2Vv6dwZTa9APm962IsJ4dY4xQRCY=; b=k9VFgQkj+KdVX1DZuf5h1viYDj+ribPEFPDKeEeIW3nqdhsDajs9/wGeIa5gIJDb5A g9ps/ZVbTWoXL4PWxP8/yKPVAMQXbKNMVa+jWPmidl/H2St4nghPEgZvvARI38FaOy7U 5qSzHAqCqYB5Uxyhc/aiN645iNBA8VQDSP/MPtr0cd9gOWPXZf/Q/WpN9fwf8k1n0Eap LnzMjEcD77cSVTBZe9Wgu3Zzqa8yx7CTu30FKJ1B7Obk8b3arErWtHBUtuk8UMVsC9hm Fpin+Lo85uWomYvMuG7B1e88RHbj2IuySLHGKdKTzbttawodT1JLG9/kJUEV16Sd8+/O kqzw== X-Gm-Message-State: AEkooutvp7cZDR+egqbPqrxx1uAhWIO8LkRpt2ElceKRpcv8iJ4Pgi+BuXOTNJM19d3FGTDx X-Received: by 10.98.68.1 with SMTP id r1mr12149043pfa.161.1471595119177; Fri, 19 Aug 2016 01:25:19 -0700 (PDT) Received: from localhost.localdomain ([139.59.249.186]) by smtp.gmail.com with ESMTPSA id p4sm4290183pfp.60.2016.08.19.01.25.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Aug 2016 01:25:18 -0700 (PDT) From: Alex Shi Cc: Daniel Lezcano , Greg Kroah-Hartman , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/4] cpu: clean up register_cpu func Date: Fri, 19 Aug 2016 16:25:11 +0800 Message-Id: <1471595114-1688-1-git-send-email-alex.shi@linaro.org> X-Mailer: git-send-email 2.8.1.101.g72d917a To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch could reduce one branch in this function. Also make the code more readble. Signed-off-by: Alex Shi To: linux-kernel@vger.kernel.org To: Greg Kroah-Hartman Cc: Daniel Lezcano --- drivers/base/cpu.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.8.1.101.g72d917a Acked-by: Daniel Lezcano diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c index 691eeea..4c28e1a 100644 --- a/drivers/base/cpu.c +++ b/drivers/base/cpu.c @@ -371,12 +371,13 @@ int register_cpu(struct cpu *cpu, int num) if (cpu->hotpluggable) cpu->dev.groups = hotplugable_cpu_attr_groups; error = device_register(&cpu->dev); - if (!error) - per_cpu(cpu_sys_devices, num) = &cpu->dev; - if (!error) - register_cpu_under_node(num, cpu_to_node(num)); + if (error) + return error; - return error; + per_cpu(cpu_sys_devices, num) = &cpu->dev; + register_cpu_under_node(num, cpu_to_node(num)); + + return 0; } struct device *get_cpu_device(unsigned cpu)