From patchwork Sat Aug 27 16:14:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 74860 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp885969qga; Sat, 27 Aug 2016 09:15:16 -0700 (PDT) X-Received: by 10.66.155.129 with SMTP id vw1mr16441779pab.148.1472314516341; Sat, 27 Aug 2016 09:15:16 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si28082201pfa.134.2016.08.27.09.15.15; Sat, 27 Aug 2016 09:15:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754696AbcH0QPM (ORCPT + 27 others); Sat, 27 Aug 2016 12:15:12 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:34157 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754146AbcH0QPK (ORCPT ); Sat, 27 Aug 2016 12:15:10 -0400 Received: by mail-pf0-f174.google.com with SMTP id p64so38042132pfb.1 for ; Sat, 27 Aug 2016 09:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=FJ20+mlfSjRnyrayWK396jKbOInrM241wC18u/71PeM=; b=LO+nzu7/Td/GK9Qd+8eyiWrI47wO2592l/2F1rsYdsRMGLoK0dB0062qnbiQr80CPP rhzvrlmiTDD60qHGdfNcIcG/wyGG3+bes3jBsPJ5kvx3J3CkYGipfNQ7Tsj289jyNO1T h3Wd/wKbBzKePgwwdoeHOaWIeIlZAX+QWbUF0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FJ20+mlfSjRnyrayWK396jKbOInrM241wC18u/71PeM=; b=L3QQmUEjWqAyqT3zW2MAuvrJzqPxJZxLzzHrAi0DZx933zmOT86k92ipodgCY3SJ4a 5f+rQ57anPvI04Oin4/yKRxCatWAybnFEGBX+ExmIAPWp1CYwplKhEjFtQreYvkEuNHX Y/F11bffy0nCegxJb/oaRjKVz7BKwC77BeNTxjKsuTR0KFqerT3bgtoDe8eqYvusJ2Im KmYAe9cCjmGyKwjtdkvTM6aNV+r3Eu30ynYT5LlkMpMrEYl8gz5pl6JL423WsCnjwiZ/ SsXiGbinbilYmcmO0WRx5kOYQ1RzxyFQSBdfm4a08tVD5tiAWwRCJcLUb5k9zmL2p2aI iWQg== X-Gm-Message-State: AE9vXwOOfuiTCHfydqcgvnQJlHAyqslmDSE7N3jQo2gzvUuXnyWSpe36YZrDPPpfZCcDaycj X-Received: by 10.98.66.209 with SMTP id h78mr16588621pfd.11.1472314510147; Sat, 27 Aug 2016 09:15:10 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.142]) by smtp.gmail.com with ESMTPSA id g24sm37195418pfk.56.2016.08.27.09.15.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 27 Aug 2016 09:15:09 -0700 (PDT) From: Baoyou Xie To: Jes.Sorensen@redhat.com, kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@linaro.org, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] fix:rtl8xxxu_core: mark symbols static where possible Date: Sun, 28 Aug 2016 00:14:36 +0800 Message-Id: <1472314476-23351-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 1 warning about global functions without a declaration in the rtl8xxxu rtl8xxxu_core.c when building with W=1: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks it 'static'. Signed-off-by: Baoyou Xie --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 77048db..95b54b8 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -894,7 +894,7 @@ int rtl8xxxu_write_rfreg(struct rtl8xxxu_priv *priv, return retval; } -int +static int rtl8xxxu_gen1_h2c_cmd(struct rtl8xxxu_priv *priv, struct h2c_cmd *h2c, int len) { struct device *dev = &priv->udev->dev;