From patchwork Sat Aug 27 17:15:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 74863 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp903230qga; Sat, 27 Aug 2016 10:16:21 -0700 (PDT) X-Received: by 10.98.58.149 with SMTP id v21mr16592031pfj.19.1472318181311; Sat, 27 Aug 2016 10:16:21 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dw1si28375754pab.5.2016.08.27.10.16.20; Sat, 27 Aug 2016 10:16:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754705AbcH0RQJ (ORCPT + 27 others); Sat, 27 Aug 2016 13:16:09 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33722 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbcH0RQH (ORCPT ); Sat, 27 Aug 2016 13:16:07 -0400 Received: by mail-pa0-f49.google.com with SMTP id cy9so15631190pac.0 for ; Sat, 27 Aug 2016 10:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=85FVTGdrkrKKBUTTO7mvM+FcWIv+mYA5PbRwMmYBEz4=; b=Bjuuhw1A5g/eMmrOykV2Siua/ELsndIvjJ6I/SnxqCYV23S5hGdVEdPpA2ukRU84Ds u1h3pvLPVyqyoNx4uSQJ0+WuzKki4JhLOeUFPGoGVJr6lZFh9qG9JIjLGaXMS/aUBObD wypy3xr92CVrz6TsR9l8oaxRH6CbXjSfx6DJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=85FVTGdrkrKKBUTTO7mvM+FcWIv+mYA5PbRwMmYBEz4=; b=LmO5fsuFEHCbZ/37XVVWJGE5pAvYrDaA1Esi8mzTRmWMxLB1ZhmCIbWpaKpwsBHTQ+ 4q6Bzd0CVHkT1G+guTMuzAQUwmY/nEGbrr0t37o8GgtbucrS9Jq/zy6lUcYyimHgzduO H+XdGeKLpyMsFjEBuESOPGA4kPB8QrdJXY/xdBDl/jAEHeBUJE+/sWiPeKvyO3fnDFP8 HAfMlejwY1FvgU6DFVax9TF28yQ3ZxAdvmozxWr1+bhjjnvOV3H8sTyqGf1SN6cR8PNY RTdquNHZ+m8Wf0Pkk7PgV7G/jBERwF37CXYGV8GI51UFg2o+/CYlsePgBSg1XLeRBuaY uzfQ== X-Gm-Message-State: AE9vXwMCWoJx02eb1ldW6cvxkB7eZ1Uf0MMGhigxUlXyIvc3kWAb4u9gRB61rIp9pj6F+mqd X-Received: by 10.66.82.42 with SMTP id f10mr16910399pay.17.1472318167205; Sat, 27 Aug 2016 10:16:07 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.142]) by smtp.gmail.com with ESMTPSA id yv9sm37536631pab.0.2016.08.27.10.16.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 27 Aug 2016 10:16:06 -0700 (PDT) From: Baoyou Xie To: jassisinghbrar@gmail.com Cc: linux-kernel@vger.kernel.org, arnd@linaro.org, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible Date: Sun, 28 Aug 2016 01:15:24 +0800 Message-Id: <1472318124-25541-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when biuld kernel with W=1: drivers/mailbox/bcm-pdc-mailbox.c:472:6: warning: no previous prototype for 'pdc_setup_debugfs' [-Wmissing-prototypes] drivers/mailbox/bcm-pdc-mailbox.c:488:6: warning: no previous prototype for 'pdc_free_debugfs' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/mailbox/bcm-pdc-mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 Acked-by: Arnd Bergmann diff --git a/drivers/mailbox/bcm-pdc-mailbox.c b/drivers/mailbox/bcm-pdc-mailbox.c index cbe0c1e..cb019ad 100644 --- a/drivers/mailbox/bcm-pdc-mailbox.c +++ b/drivers/mailbox/bcm-pdc-mailbox.c @@ -469,7 +469,7 @@ static const struct file_operations pdc_debugfs_stats = { * this directory for a SPU. * @pdcs: PDC state structure */ -void pdc_setup_debugfs(struct pdc_state *pdcs) +static void pdc_setup_debugfs(struct pdc_state *pdcs) { char spu_stats_name[16]; @@ -485,7 +485,7 @@ void pdc_setup_debugfs(struct pdc_state *pdcs) &pdc_debugfs_stats); } -void pdc_free_debugfs(void) +static void pdc_free_debugfs(void) { if (debugfs_dir && simple_empty(debugfs_dir)) { debugfs_remove_recursive(debugfs_dir);