From patchwork Sun Aug 28 06:19:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 74869 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1078872qga; Sat, 27 Aug 2016 23:20:11 -0700 (PDT) X-Received: by 10.66.132.38 with SMTP id or6mr20767373pab.84.1472365211198; Sat, 27 Aug 2016 23:20:11 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3si31569402pao.156.2016.08.27.23.20.10; Sat, 27 Aug 2016 23:20:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932289AbcH1GUH (ORCPT + 27 others); Sun, 28 Aug 2016 02:20:07 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34397 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932174AbcH1GUG (ORCPT ); Sun, 28 Aug 2016 02:20:06 -0400 Received: by mail-pa0-f41.google.com with SMTP id fi15so39362514pac.1 for ; Sat, 27 Aug 2016 23:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=LF83suRc5RIU2FoFnlpbSWO3j/LR2OxDvI44MOHGgvo=; b=ZNvRtZ8jeadhtl+ZABJZeO64muuZW8G+UwGeGe/CN2H4KYWyexjnEKQAV+hCaHZ579 QO4qQ0lDngjTtadU4rC3i7vkjjVeyvIcX6tRdfKU2Z0Bi3Gz9jOCeUD6Cz2DtXx8iESL je6rldkXvQj1zE0TmYCX37CmvgfE0+0cAu8Co= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LF83suRc5RIU2FoFnlpbSWO3j/LR2OxDvI44MOHGgvo=; b=VHdM7Ylrwb5isH0dMnltmVoeBdAYenBAU+Z9eH7SioAC/pGndI5CzHymsDrK5mYnww Ruw15x9HN0EWzYD7JgdOlb8MycPnDGFULZ0pJ5awbk6vWoUuIzoit3MdUHSKBkqhcKV1 oNKGq4Jb/WQMlSkDzT2q0oBXi4SQol7fOt+ZiUKADj/U5PXnJ8i+CpMSyVe+UFwFtXvE 12bF31IUPAykdx4ma4s6bbjynl6QK8On+zGD66g64W5a92uU9kP8XM35oCJXYXtG44h+ q3WZSwQGOTa3wk6bCiXkWleHhrNB8wAl1vHTIrhVbCvzslURqTFe2dQzT0R5t+2ND/xx 4QZA== X-Gm-Message-State: AE9vXwNwdMXpbrkQPkP953zcaTPU9hl4KMlPYJ9ZhjeeUHVtksTMqfOHHvwTliscz/ArL+HD X-Received: by 10.66.139.227 with SMTP id rb3mr20555116pab.26.1472365205704; Sat, 27 Aug 2016 23:20:05 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.142]) by smtp.gmail.com with ESMTPSA id vy9sm39885189pab.22.2016.08.27.23.19.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 27 Aug 2016 23:20:05 -0700 (PDT) From: Baoyou Xie To: maximlevitsky@gmail.com Cc: linux-kernel@vger.kernel.org, arnd@linaro.org, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] memstick: r592: add missing declaration in r592.h Date: Sun, 28 Aug 2016 14:19:37 +0800 Message-Id: <1472365177-23712-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 1 warning when build kernel with W=1: drivers/memstick/host/r592.c:50:13: warning: no previous prototype for 'memstick_debug_get_tpc_name' [-Wmissing-prototypes] in fact, function memstick_debug_get_tpc_name is implemented in r592.c and exported but need to be declared in header file. so this patch add its declaration in r592.h in addition, this function don't check if the parameter tpc is valid, it will cause a panic and incur attack. but this need another patch to fix it. Signed-off-by: Baoyou Xie --- drivers/memstick/host/r592.h | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 diff --git a/drivers/memstick/host/r592.h b/drivers/memstick/host/r592.h index c5726c1..8f69fc1 100644 --- a/drivers/memstick/host/r592.h +++ b/drivers/memstick/host/r592.h @@ -172,4 +172,5 @@ struct r592_device { #define dbg_verbose(format, ...) __dbg(2, format, ## __VA_ARGS__) #define dbg_reg(format, ...) __dbg(3, format, ## __VA_ARGS__) +const char *memstick_debug_get_tpc_name(int tpc); #endif