From patchwork Sun Aug 28 07:28:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 74873 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1097496qga; Sun, 28 Aug 2016 00:30:28 -0700 (PDT) X-Received: by 10.98.88.131 with SMTP id m125mr20910125pfb.63.1472369428539; Sun, 28 Aug 2016 00:30:28 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dd7si31890980pad.158.2016.08.28.00.30.28; Sun, 28 Aug 2016 00:30:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932424AbcH1HaZ (ORCPT + 27 others); Sun, 28 Aug 2016 03:30:25 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33175 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932306AbcH1HaY (ORCPT ); Sun, 28 Aug 2016 03:30:24 -0400 Received: by mail-pf0-f175.google.com with SMTP id y134so41608926pfg.0 for ; Sun, 28 Aug 2016 00:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=koznw2emRgBCL3lFRy1J9MKGPTDBvu+dqOBDWEwltQM=; b=AyeHh0W/cjMsY0k5qgmTZQni3V/Gv8zbSebPMPbkMRxoOtdGqDvl84Jyf3ivrvbBdn flNreIEVi+noKYbVNlntwjG5ZJHWqU4HjFkGwfMR+tDPtXQy54KtGrO2CAkoDrIPIptY bwVYvD0HG+p75e4mwWbIwwF8B0O4e2QLzJjU4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=koznw2emRgBCL3lFRy1J9MKGPTDBvu+dqOBDWEwltQM=; b=iw+wODQBiPlLrelrmnNbr/pUD2gqsQNVm99hHnWPv0C+KJTS3bLK9FpU4lFHjv/UGx quBcI7BfcTCRx/WHn+CM3Rwy6Gs4dxwQNH09fnPS41sFYFS8omsa37hSwECUxHAO4vN1 4Ruh//OvGb/sdX4bZeOYQ+Dldoi2/pz32T3Ya4QbH+2Q7cjYPXpkAhi/NmvxuYbUaiRg aFUjqx3OYxw6nJywqZlN+Bnb23cAgicmOg5akB9EK7uRKr3frsNjKJrYPegLlB7CyN4w kLEyPblBJBClSa/XndCmyMZ6j2m0iF995O96FngzI3yYMhFCigOhtWJ+n1PYhg8TxoKr j1QQ== X-Gm-Message-State: AE9vXwME/nV85qDDlaUhe7BO2a+uGGBhjvlMWJpK336MpULdN7SDjsFTLLuziSu3UMLgrULK X-Received: by 10.98.205.6 with SMTP id o6mr20913240pfg.37.1472369423355; Sun, 28 Aug 2016 00:30:23 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.142]) by smtp.gmail.com with ESMTPSA id y3sm40165727pfd.65.2016.08.28.00.30.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 28 Aug 2016 00:30:22 -0700 (PDT) From: Baoyou Xie To: bskeggs@redhat.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@linaro.org, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] fix:nouveau_display: mark symbols static where possible Date: Sun, 28 Aug 2016 15:28:46 +0800 Message-Id: <1472369326-19561-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 1 warning about global functions without a declaration in the nouveau nouveau_display driver when building with W=1: drivers/gpu/drm/nouveau/nouveau_display.c:96:1: warning: no previous prototype for 'nouveau_display_scanoutpos_head' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks it 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index afbf557..b60ee21 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c @@ -92,7 +92,7 @@ calc(int blanks, int blanke, int total, int line) return line; } -int +static int nouveau_display_scanoutpos_head(struct drm_crtc *crtc, int *vpos, int *hpos, ktime_t *stime, ktime_t *etime) {