From patchwork Mon Aug 29 10:46:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 74890 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1564230qga; Mon, 29 Aug 2016 03:47:36 -0700 (PDT) X-Received: by 10.66.76.132 with SMTP id k4mr31533074paw.22.1472467656556; Mon, 29 Aug 2016 03:47:36 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k4si38657597pfj.91.2016.08.29.03.47.36; Mon, 29 Aug 2016 03:47:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757113AbcH2KrU (ORCPT + 27 others); Mon, 29 Aug 2016 06:47:20 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:36334 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757060AbcH2KrR (ORCPT ); Mon, 29 Aug 2016 06:47:17 -0400 Received: by mail-pf0-f176.google.com with SMTP id h186so50938730pfg.3 for ; Mon, 29 Aug 2016 03:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=pQJTBT6BChcrzZPYDoN+lfm5DyM4xK6ATinP9y5Ls6M=; b=UaMWCLWxVAPdP5UJiRcXDR8d6VcS+Ucn9leYqYMNHMKYAhO7ac4CLTJ5ke4mk+YT98 AX0Q0ttx/r1iXvrNIiiEXHANQuWhYjSCHyTuRTFz6vMZ0iEY5rwgQd+Is6H5EkpDEwpd zgNqYMy65IsBeCNv2rovKtfVGqpgaGhVRbR1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pQJTBT6BChcrzZPYDoN+lfm5DyM4xK6ATinP9y5Ls6M=; b=IPfcr4NDmYkMvH/RM5BZFqzHpem1s178jW8k/TdnpYk7YALmGxo/RIxDcTuLctSwhD kQwaeIBm4mBscjn9+B4H95LKeGSgHIWLVx5y7n6fDATTKJOfxBXL9RMM9yz3XBrSwMUQ dwSqE5akfaSUHc9JmhMZQjy8wlp8mlP96VvqSnKjGyFJ2hFGGeTpLFddij8W8qm8MukG gz4tJnqlU2ZMUQa7kwwbOzmxfvyrYGkphgpSRYwWCsrw7s1b/kV2ozc5rREpEnh8vzIK rkIEfDTUAJQoooXijlQkrWiA6GlclJbXpcLSlNb+CAQsR8B/vLTNBeRZWzW0JsdZaxyc E6tw== X-Gm-Message-State: AE9vXwPqIQIWkKk93GWuSnBgtL6txt4b5G2ss454uLxewkHo13bJ5gclsWFZlX+SR5K0fbib X-Received: by 10.98.204.216 with SMTP id j85mr31450806pfk.147.1472467637140; Mon, 29 Aug 2016 03:47:17 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.36]) by smtp.gmail.com with ESMTPSA id 9sm48282696pfo.74.2016.08.29.03.47.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Aug 2016 03:47:16 -0700 (PDT) From: Baoyou Xie To: QLogic-Storage-Upstream@qlogic.com, jejb@linux.vnet.ibm.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@linaro.org, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] [SCSI] qla4xxx: mark symbols static where possible Date: Mon, 29 Aug 2016 18:46:51 +0800 Message-Id: <1472467611-8574-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 1 warning when build kernel with W=1: drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous prototype for 'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by: Baoyou Xie --- drivers/scsi/qla4xxx/ql4_nx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c index ae87d6c..06ddd13 100644 --- a/drivers/scsi/qla4xxx/ql4_nx.c +++ b/drivers/scsi/qla4xxx/ql4_nx.c @@ -1843,7 +1843,7 @@ static uint32_t ql4_84xx_poll_wait_for_ready(struct scsi_qla_host *ha, return rval; } -uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1, +static uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1, uint32_t addr3, uint32_t mask, uint32_t addr, uint32_t *data_ptr) {