From patchwork Mon Aug 29 12:31:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 74904 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1607890qga; Mon, 29 Aug 2016 05:32:06 -0700 (PDT) X-Received: by 10.98.210.69 with SMTP id c66mr32154178pfg.71.1472473926037; Mon, 29 Aug 2016 05:32:06 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id mu1si38956666pab.286.2016.08.29.05.32.05; Mon, 29 Aug 2016 05:32:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757589AbcH2Mbx (ORCPT + 27 others); Mon, 29 Aug 2016 08:31:53 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33523 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757412AbcH2Mbu (ORCPT ); Mon, 29 Aug 2016 08:31:50 -0400 Received: by mail-pa0-f42.google.com with SMTP id cy9so28576214pac.0 for ; Mon, 29 Aug 2016 05:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=bYzvO7MioR0TOxdyx2fydlms8nps6o9ITrHf8RIN9XQ=; b=CZ1OodQYK35mbCdopyM2zdEDhQBW3imIzPJzV0K/kv/+b94pUOIF8FNB3SK3ekHVwR Q2aRpu+780VnflhvHmtrDkmyRoph0kXHCTC50ewEbgGoARDOaZXnUaWVyTglwH+oR9/K KwhmcDTdyiJyhoE9W+fQBq82StNLrL6jN95QQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bYzvO7MioR0TOxdyx2fydlms8nps6o9ITrHf8RIN9XQ=; b=KgIthMPBUsUy6SWpok/BV1FgMHmJTvLihwXZ/kyaR51AIe44h/GicAFJhGnH1023YY /mIZIqP7lxnlIyWEY3eCM3Ue8cLHmMfpXR59CmgJu1lt3NxG2V6T83qngp3yd1W+1NjK Auc8Nkutpy5Jvyz7iT/ZJqMSaoeQTBfUqlRbNGA1G1P/4zh2tqejB0n8uzBvu2JmDPiu l8UUMaEc52b2DreJGYO6pygOPQW3pXQS1nz3vWjLoiwGlx8foP591tpHGybZqq6qME5A Nit/6xgLLvVztRkMr9uFfBu1qv9FNCjbKkfFGBGn64U/o6JXtZEjXIdsUFsL2ftDrks6 jGHA== X-Gm-Message-State: AE9vXwPxFohtX7PxMy+gKDg88PmKEtK8S3lhUQboC9/N2QhQhTgIPbe9yMuxwXt5kykhIRCB X-Received: by 10.66.191.199 with SMTP id ha7mr32284256pac.21.1472473909545; Mon, 29 Aug 2016 05:31:49 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.36]) by smtp.gmail.com with ESMTPSA id p64sm49181629pfd.11.2016.08.29.05.31.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Aug 2016 05:31:49 -0700 (PDT) From: Baoyou Xie To: isdn@linux-pingi.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] mISDN: mark symbols static where possible Date: Mon, 29 Aug 2016 20:31:11 +0800 Message-Id: <1472473871-16207-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 3 warnings when build kernel with W=1: drivers/isdn/hardware/mISDN/avmfritz.c:288:1: warning: no previous prototype for 'write_ctrl' [-Wmissing-prototypes] drivers/isdn/hardware/mISDN/avmfritz.c:745:1: warning: no previous prototype for 'clear_pending_hdlc_ints' [-Wmissing-prototypes] drivers/isdn/hardware/mISDN/avmfritz.c:966:1: warning: no previous prototype for 'setup_fritz' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/isdn/hardware/mISDN/avmfritz.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/isdn/hardware/mISDN/avmfritz.c b/drivers/isdn/hardware/mISDN/avmfritz.c index 292991c..e3fa1cd 100644 --- a/drivers/isdn/hardware/mISDN/avmfritz.c +++ b/drivers/isdn/hardware/mISDN/avmfritz.c @@ -284,7 +284,7 @@ __write_ctrl_pciv2(struct fritzcard *fc, struct hdlc_hw *hdlc, u32 channel) { AVM_HDLC_STATUS_1)); } -void +static void write_ctrl(struct bchannel *bch, int which) { struct fritzcard *fc = bch->hw; struct hdlc_hw *hdlc; @@ -741,7 +741,7 @@ inithdlc(struct fritzcard *fc) modehdlc(&fc->bch[1], -1); } -void +static void clear_pending_hdlc_ints(struct fritzcard *fc) { u32 val; @@ -962,7 +962,7 @@ avm_dctrl(struct mISDNchannel *ch, u32 cmd, void *arg) return err; } -int +static int setup_fritz(struct fritzcard *fc) { u32 val, ver;