From patchwork Tue Sep 6 07:23:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 75468 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp407356qgf; Tue, 6 Sep 2016 00:27:11 -0700 (PDT) X-Received: by 10.98.17.83 with SMTP id z80mr70593143pfi.38.1473146831256; Tue, 06 Sep 2016 00:27:11 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s126si34027023pfb.16.2016.09.06.00.27.10; Tue, 06 Sep 2016 00:27:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933081AbcIFH1I (ORCPT + 27 others); Tue, 6 Sep 2016 03:27:08 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35726 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbcIFH1G (ORCPT ); Tue, 6 Sep 2016 03:27:06 -0400 Received: by mail-pf0-f170.google.com with SMTP id w87so13693211pfk.2 for ; Tue, 06 Sep 2016 00:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=95Ob2b4LZ6ucCyGjFi8D9nWUeLmSVqvcTht9fSUt6Jk=; b=Nmkf68Y/cJ10wrqdnWqIYhRoR17n3g+GndvYgxEwljcfr87mf8xhG+AhPiAvQ2abBq bYDsErpYyhhizRzQgARgAEC+Xt94dwMp/tau4t7Xjvuw4NUs3MMnaaCo1WMf28b9TlZV zMWOQmeHf/U/KCAuzY93lkyyyARnGOZtBy+IM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=95Ob2b4LZ6ucCyGjFi8D9nWUeLmSVqvcTht9fSUt6Jk=; b=LyMe8fwaomiO3AF14yj11E9LgrPDdv042AkdaUPIjULMk7JaqXVU+uZKPHGPCds3lY uqkfDYXxXQaf048tq5LLRzWHyQbT2W9JDbYLmmouok3Oh1FicyByGSLkkRZccHKYbkaL YxTkg9ADr9NBxc22iXzrYTWaScx5ZcvbOU2Q+dxqR7Cqh3IcpBQabTFAhnxW0mMVByDw SFOCHvhF2InywYqWbrVl2lgUHNc8s1zJpCdu7c2AtwwHPK0lFb+GDVBXaNoHfojSdIRM v1c0fRHoQWnv3dI8pZxT4lucJxwmg5TEODUVirBGzl/i7QC4riHOLnhytoeb7BnGJuDT QjVw== X-Gm-Message-State: AE9vXwPklS2ZdSoge/wsPGZgvEbnwkchtL3xhs5kzTP7pNEKHcLZ5JU2CeWASkWPCuK6s20Z X-Received: by 10.98.208.198 with SMTP id p189mr9163399pfg.71.1473146826170; Tue, 06 Sep 2016 00:27:06 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.17]) by smtp.gmail.com with ESMTPSA id us6sm38315734pac.20.2016.09.06.00.27.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Sep 2016 00:27:05 -0700 (PDT) From: Baoyou Xie To: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/arm: mark symbols static where possible Date: Tue, 6 Sep 2016 15:23:28 +0800 Message-Id: <1473146608-23718-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for 'malidp_duplicate_plane_state' [-Wmissing-prototypes] drivers/gpu/drm/arm/malidp_planes.c:66:6: warning: no previous prototype for 'malidp_destroy_plane_state' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/arm/malidp_planes.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index 725098d..5f8bece 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -46,7 +46,8 @@ static void malidp_de_plane_destroy(struct drm_plane *plane) devm_kfree(plane->dev->dev, mp); } -struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) +static struct +drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) { struct malidp_plane_state *state, *m_state; @@ -63,7 +64,7 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) return &state->base; } -void malidp_destroy_plane_state(struct drm_plane *plane, +static void malidp_destroy_plane_state(struct drm_plane *plane, struct drm_plane_state *state) { struct malidp_plane_state *m_state = to_malidp_plane_state(state);