From patchwork Wed Sep 7 11:05:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 75632 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp265211qgf; Wed, 7 Sep 2016 04:05:25 -0700 (PDT) X-Received: by 10.66.50.164 with SMTP id d4mr80447406pao.96.1473246325734; Wed, 07 Sep 2016 04:05:25 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id db4si29420337pad.90.2016.09.07.04.05.25; Wed, 07 Sep 2016 04:05:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964863AbcIGLFX (ORCPT + 27 others); Wed, 7 Sep 2016 07:05:23 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33584 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbcIGLFV (ORCPT ); Wed, 7 Sep 2016 07:05:21 -0400 Received: by mail-pf0-f173.google.com with SMTP id g202so5779175pfb.0 for ; Wed, 07 Sep 2016 04:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=n8BMsPp62CC5u5sUjCfnLMxki4YZSbe/kEZ9u3Yf4jA=; b=ReQFnUYSjRco7wqUPFtRLDIvn3eTJhqOk7FrGYLkz1Er2dZsjdC5OAVyCJv780HFfI 1SljNH/+4Z346XmL8p8G5DI0sgWk+q6x1ObwCEt25nzPOnLMeth6yrPQz1dEfBDyz1Ok Hx5FRDjWWoPfSPH61tRKomN6Yyxdfs4Mer0yY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=n8BMsPp62CC5u5sUjCfnLMxki4YZSbe/kEZ9u3Yf4jA=; b=Ynm2kRLeykBIsod1jOs8u0+vnJYxSexcybpph34Drzno35b3dperj/LW03DKsWkJWi IUyspFPrYqU4tXstvVbaM6mI1YA0A00T09ZODUZ5UgWt1rwl/8B/7drzCEnSCtoBSujS VUFXVg04AYqG4+1G0kfr/b+4+TYvwiN/EzIovYxUooVyRfnfkiVEmsW8Pi2Gr7jBJ2RC vkLd7Cf3sC/w0c0VqQtAFEmtHlwqkZpL1ARUHVZixYeb4QYPYn/eI1N7dNkGj1a1bDfx /Fa8YUEJfhiMo/MDxntUFiUgwhBLr4+cn+aC9cxlu/PPne+3JpVyc2AoKm6Ts+S/e8dc H1jQ== X-Gm-Message-State: AE9vXwNZJloH8VGhFmdOeF9kbVWHW9W6U2ln6gzo/99mEX96uq9yP2vzl9cnxL0hPihrv07d X-Received: by 10.98.7.80 with SMTP id b77mr81381183pfd.136.1473246321172; Wed, 07 Sep 2016 04:05:21 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.64]) by smtp.gmail.com with ESMTPSA id ty6sm48144072pac.18.2016.09.07.04.05.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Sep 2016 04:05:20 -0700 (PDT) From: Baoyou Xie To: benjamin.gaignard@linaro.org, vincent.abriou@st.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/sti: mark symbols static where possible Date: Wed, 7 Sep 2016 19:05:07 +0800 Message-Id: <1473246307-889-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/sti/sti_mixer.c:361:6: warning: no previous prototype for 'sti_mixer_set_matrix' [-Wmissing-prototypes] drivers/gpu/drm/sti/sti_dvo.c:109:5: warning: no previous prototype for 'dvo_awg_generate_code' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/sti/sti_dvo.c | 3 ++- drivers/gpu/drm/sti/sti_mixer.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c index 00881eb..4545ad0 100644 --- a/drivers/gpu/drm/sti/sti_dvo.c +++ b/drivers/gpu/drm/sti/sti_dvo.c @@ -106,7 +106,8 @@ struct sti_dvo_connector { container_of(x, struct sti_dvo_connector, drm_connector) #define BLANKING_LEVEL 16 -int dvo_awg_generate_code(struct sti_dvo *dvo, u8 *ram_size, u32 *ram_code) +static int +dvo_awg_generate_code(struct sti_dvo *dvo, u8 *ram_size, u32 *ram_code) { struct drm_display_mode *mode = &dvo->mode; struct dvo_config *config = dvo->config; diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c index 7d9aea8..b78cec5 100644 --- a/drivers/gpu/drm/sti/sti_mixer.c +++ b/drivers/gpu/drm/sti/sti_mixer.c @@ -358,7 +358,7 @@ int sti_mixer_set_plane_status(struct sti_mixer *mixer, return 0; } -void sti_mixer_set_matrix(struct sti_mixer *mixer) +static void sti_mixer_set_matrix(struct sti_mixer *mixer) { unsigned int i;