From patchwork Wed Sep 14 06:10:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76141 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp1709976qgf; Tue, 13 Sep 2016 23:11:48 -0700 (PDT) X-Received: by 10.98.29.8 with SMTP id d8mr1484829pfd.142.1473833508197; Tue, 13 Sep 2016 23:11:48 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f7si3013515pax.93.2016.09.13.23.11.47; Tue, 13 Sep 2016 23:11:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754527AbcINGLn (ORCPT + 27 others); Wed, 14 Sep 2016 02:11:43 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:34173 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbcINGLl (ORCPT ); Wed, 14 Sep 2016 02:11:41 -0400 Received: by mail-pa0-f54.google.com with SMTP id wk8so2122202pab.1 for ; Tue, 13 Sep 2016 23:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=y5KX2fb1OOwhX5xFmiBDazR7TZ0I7bKWpmXCOHFnlC4=; b=SEesv9Z/Ea25vXIJh9HdLiz3esOq4u22cOnMk8Ag8wNs89lODKQl/ya/eZDiyjTimf 4tfg3qo6f0JL7jgAuQ2ELtq/OOyUyDmk7xLPU6C0jVnic7CB6b9j++NGFRuzKvvCsIbZ NLIxVCdKlg88fuiSZtl6r66Ohi9kaPtPEFOTQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=y5KX2fb1OOwhX5xFmiBDazR7TZ0I7bKWpmXCOHFnlC4=; b=IYtlyR0KJHrvONsVknC11PYeXzUYUJzgvUUdZyDwf2d0lMt7qlHI4cAG4nGgj9pw+P 1mWatgOxsMEyqoJlC5Cx8V95XguOygo8vigNkGWNoXVKbOGtnh0QdaFh28zvRI9h1XtJ 3rSa6WEPR5+d6u/qu2mxdIinw6a2bsEf3p4FjoujjXQUyaB8wMWgEHnHFe2PzVAC0b9s HhOXtOCYn0hJzbHTD/3mtlntEVhqnrwlT7mUtJVT82kYG9dvF9YEKu1PQ81USNm6lqUA PINoQeDJeJXKsAshahGdLLzRgevkrgLXXvWJdehzN7zKpXetUTjqy2fijsFGtRxrEsWD j51Q== X-Gm-Message-State: AE9vXwML+64EYvh/EN7sxpemsNMjX+siichNaSQdDHDdoSV6eON60tyK7AUufzGVyT0ncnu8 X-Received: by 10.66.144.164 with SMTP id sn4mr1542171pab.0.1473833500308; Tue, 13 Sep 2016 23:11:40 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.21]) by smtp.gmail.com with ESMTPSA id e71sm9236317pfc.75.2016.09.13.23.11.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Sep 2016 23:11:39 -0700 (PDT) From: Baoyou Xie To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/radeon/radeon_device: clean function declarations in radeon_device.c up Date: Wed, 14 Sep 2016 14:10:57 +0800 Message-Id: <1473833457-1729-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/radeon/radeon_device.c:1961:5: warning: no previous prototype for 'radeon_debugfs_init' [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_device.c:1966:6: warning: no previous prototype for 'radeon_debugfs_cleanup' [-Wmissing-prototypes] In fact, both functions are declared in drivers/gpu/drm/radeon/radeon_drv.c, but should be declared in a header file, thus can be recognized in other file. So this patch moves the declarations into drivers/gpu/drm/radeon/radeon.h. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/radeon/radeon_device.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 5 ----- drivers/gpu/drm/radeon/radeon_drv.h | 5 +++++ 3 files changed, 6 insertions(+), 5 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index a00dd2f..811abde 100644 --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/drivers/gpu/drm/radeon/radeon_device.c @@ -36,6 +36,7 @@ #include #include "radeon_reg.h" #include "radeon.h" +#include "radeon_drv.h" #include "atom.h" static const char radeon_family_name[][16] = { diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index 07e4493..6cc4a9e 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -156,11 +156,6 @@ void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); extern long radeon_kms_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); -#if defined(CONFIG_DEBUG_FS) -int radeon_debugfs_init(struct drm_minor *minor); -void radeon_debugfs_cleanup(struct drm_minor *minor); -#endif - /* atpx handler */ #if defined(CONFIG_VGA_SWITCHEROO) void radeon_register_atpx_handler(void); diff --git a/drivers/gpu/drm/radeon/radeon_drv.h b/drivers/gpu/drm/radeon/radeon_drv.h index afef2d9..3d35e0e 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.h +++ b/drivers/gpu/drm/radeon/radeon_drv.h @@ -119,4 +119,9 @@ long radeon_drm_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); +#if defined(CONFIG_DEBUG_FS) +int radeon_debugfs_init(struct drm_minor *minor); +void radeon_debugfs_cleanup(struct drm_minor *minor); +#endif + #endif /* __RADEON_DRV_H__ */