From patchwork Thu Sep 15 11:39:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76298 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp2391023qgf; Thu, 15 Sep 2016 04:39:22 -0700 (PDT) X-Received: by 10.98.93.204 with SMTP id n73mr13748880pfj.87.1473939562271; Thu, 15 Sep 2016 04:39:22 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pz3si3926640pac.95.2016.09.15.04.39.21; Thu, 15 Sep 2016 04:39:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763076AbcIOLjT (ORCPT + 27 others); Thu, 15 Sep 2016 07:39:19 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34379 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbcIOLjS (ORCPT ); Thu, 15 Sep 2016 07:39:18 -0400 Received: by mail-pf0-f179.google.com with SMTP id p64so16106169pfb.1 for ; Thu, 15 Sep 2016 04:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=yTFigjYSc5g771iwfPsFzkTisokyawJ2YYxV/UhmNtw=; b=SYx0Vh8VnrgTbur9p7fzlB1KH1G22rPZLGojQSIyIKUveTR9enFGIx2Z9LN53cbP2M NgEC3raXn1/AoUkJ0iCHDJH7KtIcZBpCTTcEMAzE1gv3L9IPJJiT1i8ooclLcEqGoVNS XEP5eny7W7Gby/c+K5uAOoVpi0M5FJHNY2bnw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yTFigjYSc5g771iwfPsFzkTisokyawJ2YYxV/UhmNtw=; b=L0WbV+gMdaaS8h9QUjgyiYMTMcVTMB33UlkDF9MPeSYcS2XGaSQWt6gTSpz3haaafy 5gDXd3Ri3Bt+HO7KZxmEdX7Pc7o+Z5RC1KCxMoH2F1X3d7skN6Hj47SAXC4loupeCDod 47wCwOjrdOKSlWpNKOCf1YKXjj84gkAFJp7L9kRyLFMx6Keb9TaSF5a0nJdreut9B0yW 9YcchjXQGGmNwu6t/UjqdhooVctqWsasb91kcxKNVvqkYRZvfNwBneobKIJmZyrkvc17 30/GMhWpQH6YIfezB5wO8p3cnEvImwmbzGvSswiqJFqOteZodxtG3Wo7VM4as6svM2ok dO9g== X-Gm-Message-State: AE9vXwNNM8bTs+lmfmmgyUVEnlfuhpwKYNUh+SziIZEsMqQ9QfuYzGl6gejAoTH1deVAqofh X-Received: by 10.98.37.130 with SMTP id l124mr13801054pfl.60.1473939557810; Thu, 15 Sep 2016 04:39:17 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.172]) by smtp.gmail.com with ESMTPSA id y3sm44755413pfy.36.2016.09.15.04.39.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Sep 2016 04:39:17 -0700 (PDT) From: Baoyou Xie To: benjamin.gaignard@linaro.org, vincent.abriou@st.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/sti: mark symbols static where possible Date: Thu, 15 Sep 2016 19:39:00 +0800 Message-Id: <1473939540-2597-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 4 warnings when building kernel with W=1: drivers/gpu/drm/sti/sti_gdp.c:476:5: warning: no previous prototype for 'sti_gdp_field_cb' [-Wmissing-prototypes] drivers/gpu/drm/sti/sti_hqvdp.c:786:5: warning: no previous prototype for 'sti_hqvdp_vtg_cb' [-Wmissing-prototypes] drivers/gpu/drm/sti/sti_hqvdp.c:1292:5: warning: no previous prototype for 'sti_hqvdp_bind' [-Wmissing-prototypes] drivers/gpu/drm/sti/sti_drv.c:143:6: warning: no previous prototype for 'sti_drm_dbg_cleanup' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/sti/sti_drv.c | 2 +- drivers/gpu/drm/sti/sti_gdp.c | 2 +- drivers/gpu/drm/sti/sti_hqvdp.c | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index 7cd3804..e6f0706 100644 --- a/drivers/gpu/drm/sti/sti_drv.c +++ b/drivers/gpu/drm/sti/sti_drv.c @@ -140,7 +140,7 @@ err: return ret; } -void sti_drm_dbg_cleanup(struct drm_minor *minor) +static void sti_drm_dbg_cleanup(struct drm_minor *minor) { drm_debugfs_remove_files(sti_drm_dbg_list, ARRAY_SIZE(sti_drm_dbg_list), minor); diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c index b8d942c..4648d1b 100644 --- a/drivers/gpu/drm/sti/sti_gdp.c +++ b/drivers/gpu/drm/sti/sti_gdp.c @@ -473,7 +473,7 @@ static void sti_gdp_disable(struct sti_gdp *gdp) * RETURNS: * 0 on success. */ -int sti_gdp_field_cb(struct notifier_block *nb, +static int sti_gdp_field_cb(struct notifier_block *nb, unsigned long event, void *data) { struct sti_gdp *gdp = container_of(nb, struct sti_gdp, vtg_field_nb); diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c index b5ee783..7f0dea8 100644 --- a/drivers/gpu/drm/sti/sti_hqvdp.c +++ b/drivers/gpu/drm/sti/sti_hqvdp.c @@ -783,7 +783,8 @@ static void sti_hqvdp_disable(struct sti_hqvdp *hqvdp) * RETURNS: * 0 on success. */ -int sti_hqvdp_vtg_cb(struct notifier_block *nb, unsigned long evt, void *data) +static int +sti_hqvdp_vtg_cb(struct notifier_block *nb, unsigned long evt, void *data) { struct sti_hqvdp *hqvdp = container_of(nb, struct sti_hqvdp, vtg_nb); int btm_cmd_offset, top_cmd_offest; @@ -1289,7 +1290,7 @@ static struct drm_plane *sti_hqvdp_create(struct drm_device *drm_dev, return &hqvdp->plane.drm_plane; } -int sti_hqvdp_bind(struct device *dev, struct device *master, void *data) +static int sti_hqvdp_bind(struct device *dev, struct device *master, void *data) { struct sti_hqvdp *hqvdp = dev_get_drvdata(dev); struct drm_device *drm_dev = data;