From patchwork Thu Sep 15 13:51:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76319 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp2454887qgf; Thu, 15 Sep 2016 06:52:19 -0700 (PDT) X-Received: by 10.66.164.227 with SMTP id yt3mr14796234pab.117.1473947539678; Thu, 15 Sep 2016 06:52:19 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si4349726pab.271.2016.09.15.06.52.19; Thu, 15 Sep 2016 06:52:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758836AbcIONwO (ORCPT + 27 others); Thu, 15 Sep 2016 09:52:14 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:35343 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934770AbcIONv5 (ORCPT ); Thu, 15 Sep 2016 09:51:57 -0400 Received: by mail-pf0-f169.google.com with SMTP id z123so17036148pfz.2 for ; Thu, 15 Sep 2016 06:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=nlzR9KLQKOoK4WSXdOaGaXfM4bKsmnno4l54bcItm/E=; b=LKV+nLyGfNvxOvW2hFdq+Aiez8kGRZ5AfjLBCib/yFriO7P/GELgjY28NPvRvRfprN 6XrOaxAXXxdi0zP09H2GwW0s80xPXDYeHhEVcHyg8ym3bkUSUOSVEg1W28DSfyo1ehn6 1f+LphHeffZfa6qFYwJDCRIg6OnrRwalMl/6E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nlzR9KLQKOoK4WSXdOaGaXfM4bKsmnno4l54bcItm/E=; b=RTuU+Z8v3ph57i/BpX8cMH7wtSxSmJXdPgGf6yijxnydoaQEikXWQQsWGA/umIRFif xGuDvZMQfH1WAAJVLwaNU2TD7CkdJI4r5b+/9qKdI2ll0b4icYXsMZn79fUeynrpQCtl ndubO25PE7uN/aDjWsXPYXLYJAZb6gNdTmU1v7NQoTkytR1SHPfVyndO6JX3aSw25vsF +G7VxmPexIA5ObgiZctrkrgcEAXNV37DaF4VKiNGW0znfyWlJDAFdmZeW8yxkVY3iEPy GudbvU3eSkYpP8//P8EIjvFgAYYRq6+EOnyZZOTSNZth4gKABGCNr37BTd/nyDNDOdkf xrMQ== X-Gm-Message-State: AE9vXwN+GZEOAtnPkAd/0GsZfx3yhuQibtEwqQYyJoSy5OKlTS0deQiRYqToE6+cNCve0+GA X-Received: by 10.98.110.4 with SMTP id j4mr14812939pfc.56.1473947516724; Thu, 15 Sep 2016 06:51:56 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.172]) by smtp.gmail.com with ESMTPSA id si8sm5537160pab.8.2016.09.15.06.51.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Sep 2016 06:51:56 -0700 (PDT) From: Baoyou Xie To: oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, john.hammond@intel.com, shraddha.6596@gmail.com, di.wang@intel.com, ksenija.stanojevic@gmail.com, mike.rapoport@gmail.com, andrew.perepechko@seagate.com, kirill.shutemov@linux.intel.com, lustre-devel@lists.lustre.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] staging: lustre: clean function declarations in class_obd.c up Date: Thu, 15 Sep 2016 21:51:27 +0800 Message-Id: <1473947487-25514-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes] drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for 'class_procfs_clean' [-Wmissing-prototypes] In fact, both functions are declared in drivers/staging/lustre/lustre/obdclass/class_obd.c,but should be declared in a header file, thus can be recognized in other file. So this patch moves the declarations into drivers/staging/lustre/lustre/include/obd_class.h. Signed-off-by: Baoyou Xie --- drivers/staging/lustre/lustre/include/obd_class.h | 4 ++++ drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h index 9702ad4..9965a01 100644 --- a/drivers/staging/lustre/lustre/include/obd_class.h +++ b/drivers/staging/lustre/lustre/include/obd_class.h @@ -1712,6 +1712,10 @@ int class_check_uuid(struct obd_uuid *uuid, __u64 nid); void class_init_uuidlist(void); void class_exit_uuidlist(void); +/*linux-module.c*/ +int class_procfs_init(void); +int class_procfs_clean(void); + /* class_obd.c */ extern char obd_jobid_node[]; extern struct miscdevice obd_psdev; diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c index 6700167..397929a 100644 --- a/drivers/staging/lustre/lustre/obdclass/class_obd.c +++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c @@ -446,8 +446,6 @@ static int obd_init_checks(void) return ret; } -extern int class_procfs_init(void); -extern int class_procfs_clean(void); static int __init obdclass_init(void) {