From patchwork Thu Sep 15 14:13:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76322 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp2468094qgf; Thu, 15 Sep 2016 07:14:39 -0700 (PDT) X-Received: by 10.66.161.225 with SMTP id xv1mr14905387pab.20.1473948878932; Thu, 15 Sep 2016 07:14:38 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si4442047pau.218.2016.09.15.07.14.38; Thu, 15 Sep 2016 07:14:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933002AbcIOOO3 (ORCPT + 27 others); Thu, 15 Sep 2016 10:14:29 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:35622 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757079AbcIOOOU (ORCPT ); Thu, 15 Sep 2016 10:14:20 -0400 Received: by mail-pf0-f177.google.com with SMTP id z123so17205117pfz.2 for ; Thu, 15 Sep 2016 07:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=RJpc2HGTSmes+6eOLmp0zvw1bC3rlesd6Lx2KYsXaD8=; b=EI1JiIPK5OghUJhXwqeZtvuThf0DQxuVMchuM7S8QI/400DNZYVOEDczAdaCPiNKO9 t14/3aoAoShBOlMiN48NIPbMjhC1Sp8S27rM3W1v9INNO5jvFkl5uwQkEypazv6sw/Ys JxxLr64pvyPtycyA9jYNHaICDsJcamOuk2358= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RJpc2HGTSmes+6eOLmp0zvw1bC3rlesd6Lx2KYsXaD8=; b=A/5ZueKsQ54DkLzKsF/zYNGYb7bD3jqbknekPPdQqpir7sqNiLgQyF+C3wrOodiIxv Hzwt8WW5JiNE246Y+bhBdti7pm8y9IPOVEADoMm6LtId9QIvyMnIV3v6HQaC/183UKMh 5iKFEc5p3HNV/dMGN0vqZLN+NG6y9vg1mpf/LIUnlFTxHAKDWntbbq6DzGSIBcUjkssk VoMVwtTq7rcRvNYYeaXZ3ZuYrp0hNCvt1Evv589l2p4ZbIo2/rpPhIEK6z3xb/S3z5RG PQCxMWSERaf3B2vG6K1fDR1CpBBj/6ZlbXB/uQTEBWNuVMCCdQCZyha2Q2QW0m68++yd xgVA== X-Gm-Message-State: AE9vXwPYM0KQ8+yITStKXk702du0daxcw3qAUtdOomGFlrLmv/enA+tgKwB5FtwhPukRcK4S X-Received: by 10.98.59.146 with SMTP id w18mr8730767pfj.153.1473948859772; Thu, 15 Sep 2016 07:14:19 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.172]) by smtp.gmail.com with ESMTPSA id ae7sm5630103pac.19.2016.09.15.07.14.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Sep 2016 07:14:19 -0700 (PDT) From: Baoyou Xie To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/radeon/radeon_device: remove unused function Date: Thu, 15 Sep 2016 22:13:51 +0800 Message-Id: <1473948831-27667-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/radeon/radeon_device.c:1961:5: warning: no previous prototype for 'radeon_debugfs_init' [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_device.c:1966:6: warning: no previous prototype for 'radeon_debugfs_cleanup' [-Wmissing-prototypes] In fact, these functions are dummy, but can be removed, so this patch removes them. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/radeon/radeon_device.c | 11 ----------- drivers/gpu/drm/radeon/radeon_drv.c | 9 --------- 2 files changed, 20 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index a00dd2f..63447f1 100644 --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/drivers/gpu/drm/radeon/radeon_device.c @@ -1956,14 +1956,3 @@ static void radeon_debugfs_remove_files(struct radeon_device *rdev) } #endif } - -#if defined(CONFIG_DEBUG_FS) -int radeon_debugfs_init(struct drm_minor *minor) -{ - return 0; -} - -void radeon_debugfs_cleanup(struct drm_minor *minor) -{ -} -#endif diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index 07e4493..86bab2e 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -156,11 +156,6 @@ void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); extern long radeon_kms_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); -#if defined(CONFIG_DEBUG_FS) -int radeon_debugfs_init(struct drm_minor *minor); -void radeon_debugfs_cleanup(struct drm_minor *minor); -#endif - /* atpx handler */ #if defined(CONFIG_VGA_SWITCHEROO) void radeon_register_atpx_handler(void); @@ -531,10 +526,6 @@ static struct drm_driver kms_driver = { .disable_vblank = radeon_disable_vblank_kms, .get_vblank_timestamp = radeon_get_vblank_timestamp_kms, .get_scanout_position = radeon_get_crtc_scanoutpos, -#if defined(CONFIG_DEBUG_FS) - .debugfs_init = radeon_debugfs_init, - .debugfs_cleanup = radeon_debugfs_cleanup, -#endif .irq_preinstall = radeon_driver_irq_preinstall_kms, .irq_postinstall = radeon_driver_irq_postinstall_kms, .irq_uninstall = radeon_driver_irq_uninstall_kms,