From patchwork Thu Sep 15 15:45:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76328 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp21415qgf; Thu, 15 Sep 2016 08:46:11 -0700 (PDT) X-Received: by 10.66.156.196 with SMTP id wg4mr15392435pab.153.1473954371495; Thu, 15 Sep 2016 08:46:11 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y13si39877797pfb.154.2016.09.15.08.46.11; Thu, 15 Sep 2016 08:46:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754478AbcIOPqJ (ORCPT + 27 others); Thu, 15 Sep 2016 11:46:09 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33333 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129AbcIOPqI (ORCPT ); Thu, 15 Sep 2016 11:46:08 -0400 Received: by mail-pa0-f50.google.com with SMTP id cm16so17083241pac.0 for ; Thu, 15 Sep 2016 08:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=wL3p5GgdaJ45g9APCwKG1Tmg86vb3ieH470ERZAQ2C8=; b=R07G20qi2ph9bG41+ILePQDTJi88CPgUbLZ5ihUc1cG2XY9dD+2rakUOpK7rY4iI6f i0mVQF9SYZV8ghn+3m0bF7z1e5qj61H1s73ZmYfhPV/Cwk8x7OZGZHkw6fya9W0ISWef 8WNriss2QhCDaqlSAy/G9pda4HrDJv1qnBABQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wL3p5GgdaJ45g9APCwKG1Tmg86vb3ieH470ERZAQ2C8=; b=WVpQj8qPdxtUQ2DhV9KEszJ6kMWJOeiTM7WYv6bKoc2CE2pRnMaE1fArGilnpAIBCG 3eb5KXPKkxmfTAR+F998AjE0X8iBg/wvAV99GS3+fcz5iA8MIbRM1kGaqxp3SNAs6g+e j8K5dQeocXoJ8lkSQnSv407FoHhjU11Z1UHi+MvFWghzV2AkfvpnNN8WiLQEiTgS1K6/ N9sE+DwVJzNSLcqk9dHKPwIs2gS8ao9mN2/bJqI5MPnFwjIVkkCSA2csBrz/0pgvPM7h XcK1GPb0BV3TQpUJz6BVrrFV7sCmOZ2r/+o9YFRECQVRSN3k5S8x/g8zKMYvwXtkTHjN PyAw== X-Gm-Message-State: AE9vXwNFjYmbFjrs3UBuwfm9lzEjC82aalKqG6KSxmQ+ktWS/JfSpCbtgEpsrdz56XbdcZID X-Received: by 10.67.23.70 with SMTP id hy6mr15629027pad.75.1473954367385; Thu, 15 Sep 2016 08:46:07 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.187]) by smtp.gmail.com with ESMTPSA id f65sm26263290pfg.30.2016.09.15.08.45.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Sep 2016 08:46:06 -0700 (PDT) From: Baoyou Xie To: oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, john.hammond@intel.com, shraddha.6596@gmail.com, di.wang@intel.com, ksenija.stanojevic@gmail.com, mike.rapoport@gmail.com, andrew.perepechko@seagate.com, kirill.shutemov@linux.intel.com, lustre-devel@lists.lustre.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH v2] staging: lustre: clean function declarations in class_obd.c up Date: Thu, 15 Sep 2016 23:45:17 +0800 Message-Id: <1473954317-27343-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes] drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for 'class_procfs_clean' [-Wmissing-prototypes] In fact, both functions are declared in drivers/staging/lustre/lustre/obdclass/class_obd.c,but should be declared in a header file, thus can be recognized in other file. So this patch moves the declarations into drivers/staging/lustre/lustre/include/obd_class.h. Signed-off-by: Baoyou Xie --- drivers/staging/lustre/lustre/include/obd_class.h | 2 ++ drivers/staging/lustre/lustre/obdclass/class_obd.c | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h index 9702ad4..324c70d 100644 --- a/drivers/staging/lustre/lustre/include/obd_class.h +++ b/drivers/staging/lustre/lustre/include/obd_class.h @@ -1716,6 +1716,8 @@ void class_exit_uuidlist(void); extern char obd_jobid_node[]; extern struct miscdevice obd_psdev; extern spinlock_t obd_types_lock; +int class_procfs_init(void); +int class_procfs_clean(void); /* prng.c */ #define ll_generate_random_uuid(uuid_out) cfs_get_random_bytes(uuid_out, sizeof(class_uuid_t)) diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c index 6700167..710039a 100644 --- a/drivers/staging/lustre/lustre/obdclass/class_obd.c +++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c @@ -446,9 +446,6 @@ static int obd_init_checks(void) return ret; } -extern int class_procfs_init(void); -extern int class_procfs_clean(void); - static int __init obdclass_init(void) { int i, err;