From patchwork Sun Sep 18 08:47:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76452 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp446326qgf; Sun, 18 Sep 2016 01:48:03 -0700 (PDT) X-Received: by 10.98.31.133 with SMTP id l5mr23327384pfj.178.1474188482928; Sun, 18 Sep 2016 01:48:02 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b11si6382637pfj.256.2016.09.18.01.48.02; Sun, 18 Sep 2016 01:48:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756004AbcIRIsA (ORCPT + 27 others); Sun, 18 Sep 2016 04:48:00 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:35480 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754492AbcIRIrv (ORCPT ); Sun, 18 Sep 2016 04:47:51 -0400 Received: by mail-pf0-f177.google.com with SMTP id z123so40772255pfz.2 for ; Sun, 18 Sep 2016 01:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=V8oym2u+yeu8+UgTk5CxFbES7pRv/ns9j4l9tCOv9MM=; b=VuItympolXa6o1XLDlRfYK5b9KWIAGIJbK5qTpXimXWST1ZgaLMZeZG5qhlOF1A62F pQpiIfC2Gjusr3wuEGRvXBANGsaZqw364SX+XPfVjMVx8tmZmkfG00cW6bP9mObKV4ME OayBHg9+aijiMfjfe+bO0fy0xp7AWS5ksh3hw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=V8oym2u+yeu8+UgTk5CxFbES7pRv/ns9j4l9tCOv9MM=; b=FmW4LXaHtm+F+i2wfzyXZGN8moLRLOa8vkKih36hom42RDIfkkRl7/uuUvYz1kB0lJ orRNbH30VdYG1rgLqfI8ClBYcRxa1LF+59yvYdn6qOA8e1G1qLMjMeeE6tfIRZxEFnxL GBYoO8/rkigcRyHOyp+KEC3GjWN5gZ3jwrT4uehP0zeEAPWqo9+cu9cSuDeZSbwjYh/M YE/GLlYd4YlTUwV/HuGxyTPbExlJw6YN44M/8UDrA/qitkD7CDQl2gbzg06gyU9sVdjX 91/8Lgpl0igP2Hn5PEphYxQR2sarl64Dt6FuYsuf5VcpchoEkaC5w74fTGtX7dWjbL/C yxNg== X-Gm-Message-State: AE9vXwOZmCfHtpY4tPWMUT03+lER02bLyFF6a7YAC9oQvAE4tSY7vOlV+hFmzFy86GQqSBHD X-Received: by 10.98.37.130 with SMTP id l124mr36859089pfl.60.1474188470585; Sun, 18 Sep 2016 01:47:50 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.27]) by smtp.gmail.com with ESMTPSA id l128sm63297147pfl.21.2016.09.18.01.47.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 01:47:50 -0700 (PDT) From: Baoyou Xie To: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] ixgbe: mark symbols static where possible Date: Sun, 18 Sep 2016 16:47:34 +0800 Message-Id: <1474188454-8872-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no previous prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c index e092a89..dec8b11 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c @@ -2125,7 +2125,7 @@ static s32 ixgbe_reset_phy_t_X550em(struct ixgbe_hw *hw) * @hw: pointer to hardware structure * @led_idx: led number to turn on **/ -s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) +static s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) { u16 phy_data; @@ -2147,7 +2147,7 @@ s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) * @hw: pointer to hardware structure * @led_idx: led number to turn off **/ -s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx) +static s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx) { u16 phy_data;