From patchwork Mon Sep 19 08:22:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 76518 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp840992qgf; Mon, 19 Sep 2016 01:24:13 -0700 (PDT) X-Received: by 10.66.27.44 with SMTP id q12mr44953456pag.58.1474273453122; Mon, 19 Sep 2016 01:24:13 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qp8si27854904pac.89.2016.09.19.01.24.12; Mon, 19 Sep 2016 01:24:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938856AbcISIX5 (ORCPT + 27 others); Mon, 19 Sep 2016 04:23:57 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34128 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754464AbcISIWQ (ORCPT ); Mon, 19 Sep 2016 04:22:16 -0400 Received: by mail-lf0-f44.google.com with SMTP id y6so28396300lff.1 for ; Mon, 19 Sep 2016 01:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=3MrLSKapWd2G7IBZh9YKRKSmnnJxIoj0IEbNh011q9g=; b=X4FtDBpUXIpfFFc3jbsqa4pPmFOiOPnQEen1xwTcLO87LgHaV8pE9if6gCU8NC3S2X 9R2Me74j4emWl5URvd9nn4nJFrMzII/6sRBxWLsUfgqf6ynqW2is+61rtoJBa+KWmPUR wFLcaDnU/wuzmdcki94ZIM3zdFU1SOJAhvbjk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3MrLSKapWd2G7IBZh9YKRKSmnnJxIoj0IEbNh011q9g=; b=Kx3jA9g91DpTKvcxXibz0OTojMsN3F7NE4nZQDiGfj2JeqAb/tIay5CXTdwJIWgjT7 NJNmAc4VMbFTOEtURWrybuxdwciaLx+bFufUz54/DzcSuZvxNoi6hOGsB5UL04gguGIm pjh6//Fdpmxz9g8ZVvlXtfM63NZCokhpJiib+wxbKEFq7UrMpE+UDkfV4BHRkfeBZvaj 6LaPrW1e2s46TFiFDCfaXJ1FIq22ILXDgiJ3pEr5dySPs/LGNzNMLhXEk4IfYXB9IJ7z Z5EL66cdIPf15D2nOD7+o0urSFsei1GCH03GQqduxIxAx87SBV/gB+Ptl/SpDxK/sULI MIDQ== X-Gm-Message-State: AE9vXwN+gVyTKLm7fLTfW2rBw9wBFETLafKK1iyxx30TdsYH1rd0Ck2Wz4a/Vjc+ik2Z9BLB X-Received: by 10.25.218.12 with SMTP id r12mr10209896lfg.50.1474273334218; Mon, 19 Sep 2016 01:22:14 -0700 (PDT) Received: from linuslaptop.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id h41sm4681412lji.28.2016.09.19.01.22.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Sep 2016 01:22:13 -0700 (PDT) From: Linus Walleij To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier Cc: linux-gpio@vger.kernel.org, Linus Walleij Subject: [PATCH] pinctrl: nomadik: don't default-flag IRQs as falling Date: Mon, 19 Sep 2016 10:22:10 +0200 Message-Id: <1474273330-15789-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no point in adding any default trigger for these GPIO interrupts: the device tree should contain all trigger information and the platforms using the driver boots exclusively from device tree. Also the boot log is nagging me to fix this: [ 0.771057] ------------[ cut here ]------------ [ 0.775695] WARNING: CPU: 0 PID: 1 at ../drivers/gpio/gpiolib.c:1622 _gpiochip_irqchip_add+0x138/0x160 [ 0.785034] /soc/gpio@8012e000: Ignoring 2 default trigger (...) [ 0.942962] gpio 8012e000.gpio: at address e08f8000 (etc ad nauseam) Suggested-by: Marc Zyngier Signed-off-by: Linus Walleij --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index 205fb399268a..d318ca055489 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1177,7 +1177,7 @@ static int nmk_gpio_probe(struct platform_device *dev) irqchip, 0, handle_edge_irq, - IRQ_TYPE_EDGE_FALLING); + IRQ_TYPE_NONE); if (ret) { dev_err(&dev->dev, "could not add irqchip\n"); gpiochip_remove(&nmk_chip->chip);