From patchwork Fri Sep 23 13:22:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76864 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp568116qgf; Fri, 23 Sep 2016 06:23:05 -0700 (PDT) X-Received: by 10.98.223.22 with SMTP id u22mr12406337pfg.128.1474636985596; Fri, 23 Sep 2016 06:23:05 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a81si2481070pfa.112.2016.09.23.06.23.05; Fri, 23 Sep 2016 06:23:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965498AbcIWNWp (ORCPT + 27 others); Fri, 23 Sep 2016 09:22:45 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35840 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760007AbcIWNWl (ORCPT ); Fri, 23 Sep 2016 09:22:41 -0400 Received: by mail-pf0-f179.google.com with SMTP id q2so42138136pfj.3 for ; Fri, 23 Sep 2016 06:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=tA3Y5fJfWJBrZpG7kAIXg6EeYb3korVn4h+lCXkafQI=; b=fHtJOWCklvg7zsfRVlzaT+NW1uiFI+lZO3R7A0O0DEh6ivzKGoFuDbq7PA28xXEz/I MWVhCbNMFQ2l3rIfa/GMf93eh1q7Q/sGG/IQM/Fs5X6og9Pt78aQLFV3SMPLBQKNrV9y QYWe0vskd1yGyMEm2Nwk/k/meBv5RIZuOGDt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tA3Y5fJfWJBrZpG7kAIXg6EeYb3korVn4h+lCXkafQI=; b=AOCxbZQz/I9vC6GZH67S7qcSw8DM3c+frsB0u/dX0ThunQAcmxxc3/fW7ZkMtnc9T+ nuVluFM3+zFDmMIPZ9olJyjcR8xkxd0LZFzTDXJ/y3ZrIkZDKKp+kSSZiz1MqU/h0M2D V/ob+0xVqOLriCImuD2Z17JQUCHy5F7HRmO4SHf1xw8EpZGBzlOloezq63usaLrqbYGf zquR6Iu0Tq/YTo97HkpSXgF7ipf/i1I9cnwu2VgR1znipsZf5YQRgEfqNwI8G4MLzXwK Q14sdM44b8VhUYnjJ0gWgGqXFiODcJeIyMWZvSFmdsg1d39S13XzSEZSLxENtGbAxVet SqoA== X-Gm-Message-State: AE9vXwOtz62DFEkzoq0tD0yZCRRlZ6tTzoJkdCkDQI+B+sukcuAFYhPdKBnwG9AyyIQZmJRk X-Received: by 10.98.20.137 with SMTP id 131mr12272630pfu.11.1474636960751; Fri, 23 Sep 2016 06:22:40 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.27]) by smtp.gmail.com with ESMTPSA id x66sm11692068pfb.86.2016.09.23.06.22.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 Sep 2016 06:22:40 -0700 (PDT) From: Baoyou Xie To: gregkh@linuxfoundation.org, wsa@the-dreams.de, bhumirks@gmail.com, dan.carpenter@oracle.com, julia.lawall@lip6.fr, weiyongjun1@huawei.com, karniksayli1995@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH 1/2] Staging: ks7010: mark symbols static where possible Date: Fri, 23 Sep 2016 21:22:29 +0800 Message-Id: <1474636949-10297-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 3 warnings when building kernel with W=1: drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes] drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes] drivers/staging/ks7010/ks7010_sdio.c:172:5: warning: no previous prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 25ad43d..9442532 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -87,7 +87,7 @@ static int ks7010_sdio_write(struct ks_wlan_private *priv, unsigned int address, return rc; } -void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) +static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) { unsigned char rw_data; int retval; @@ -117,7 +117,7 @@ void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) priv->sleep_mode = atomic_read(&priv->sleepstatus.status); } -void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv) +static void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv) { unsigned char rw_data; int retval; @@ -169,7 +169,7 @@ void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv) } } -int _ks_wlan_hw_power_save(struct ks_wlan_private *priv) +static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv) { int rc = 0; unsigned char rw_data;