From patchwork Fri Sep 23 13:56:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76875 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp583471qgf; Fri, 23 Sep 2016 06:57:15 -0700 (PDT) X-Received: by 10.66.164.227 with SMTP id yt3mr12831683pab.117.1474639035811; Fri, 23 Sep 2016 06:57:15 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z25si8035145pff.271.2016.09.23.06.57.15; Fri, 23 Sep 2016 06:57:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034545AbcIWN5N (ORCPT + 27 others); Fri, 23 Sep 2016 09:57:13 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33777 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935271AbcIWN5I (ORCPT ); Fri, 23 Sep 2016 09:57:08 -0400 Received: by mail-pa0-f42.google.com with SMTP id hm5so40652249pac.0 for ; Fri, 23 Sep 2016 06:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=KNkjf3/Fos7ddTRN22CTP3rxb4EZKlMKpOT/En9UmQk=; b=VOZPiJPYaaEzUk5wYc47IYswTQy2JkCKawZ9MGH+eXVWqB4v2e4dCx0++O6+wanRh0 8OW2ZgUspMcEn8phDN/O14Gim17W8Cpb7Khi1RzycptfXv2n9wgY1CfZy3/fB+zO0ZRT r6GiGXfCgt2lD/1a6xIKn8+wk1yuDZmqVRoHw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KNkjf3/Fos7ddTRN22CTP3rxb4EZKlMKpOT/En9UmQk=; b=XNIYUEmJpwP01QOMwcGum7yHgTNeGt2QFcVl8bD4mTasp5ryiZ9AOGPiQCbe7yLnms dc4q9QZjJ4vI4zyK3JDY09RxvG6y/bG2QvsbnAP6+cAhGGOrJrMwin1VM4kn6tDAXSHO cjn6BMLM9m5xD0Nstm75RmvdB+Q60MUvv6UcqV90EbKwZVAFE5CskDdkLsv2n07CohUQ T5qzsf7WpyLGfkDf1U34R9uw4NlbNs6OazV0JJrIQ7hw8YFE1+mWv18c9ozsmmJyuwhV F5ADWAfHvUAzRVpy8+MqbfOc3teexX9xneJuG+Ahf9juDrfHkF79J2o5m4YYaeDTkBqW Vb1w== X-Gm-Message-State: AE9vXwPmh4sIwH18pGr2mtZR5WA1wuOyDSFK+9g5eHNu8qDZsPJa2CLD7wuS1SMbCPAl6iiW X-Received: by 10.66.232.106 with SMTP id tn10mr12714540pac.17.1474639011788; Fri, 23 Sep 2016 06:56:51 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.27]) by smtp.gmail.com with ESMTPSA id e71sm11911539pfc.75.2016.09.23.06.56.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 Sep 2016 06:56:51 -0700 (PDT) From: Baoyou Xie To: jinpu.wang@profitbricks.com, lindar_liu@usish.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: pmchba@pmcs.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] pm80xx: mark symbols static where possible Date: Fri, 23 Sep 2016 21:56:35 +0800 Message-Id: <1474638995-19833-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/scsi/pm8001/pm80xx_hwi.c:69:6: warning: no previous prototype for 'pm80xx_pci_mem_copy' [-Wmissing-prototypes] drivers/scsi/pm8001/pm80xx_hwi.c:4540:6: warning: no previous prototype for 'mpi_set_phy_profile_req' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/scsi/pm8001/pm80xx_hwi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c index eb4fee6..cab4024 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -66,7 +66,7 @@ int pm80xx_bar4_shift(struct pm8001_hba_info *pm8001_ha, u32 shift_value) return 0; } -void pm80xx_pci_mem_copy(struct pm8001_hba_info *pm8001_ha, u32 soffset, +static void pm80xx_pci_mem_copy(struct pm8001_hba_info *pm8001_ha, u32 soffset, const void *destination, u32 dw_count, u32 bus_base_number) { @@ -4537,8 +4537,9 @@ pm80xx_chip_isr(struct pm8001_hba_info *pm8001_ha, u8 vec) return IRQ_HANDLED; } -void mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha, - u32 operation, u32 phyid, u32 length, u32 *buf) +static void +mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha, + u32 operation, u32 phyid, u32 length, u32 *buf) { u32 tag , i, j = 0; int rc;