From patchwork Sun Sep 25 08:43:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76967 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp642964qgf; Sun, 25 Sep 2016 01:43:49 -0700 (PDT) X-Received: by 10.66.176.141 with SMTP id ci13mr28267096pac.85.1474793029541; Sun, 25 Sep 2016 01:43:49 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vu8si18353615pab.180.2016.09.25.01.43.49; Sun, 25 Sep 2016 01:43:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941003AbcIYInq (ORCPT + 27 others); Sun, 25 Sep 2016 04:43:46 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:35523 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938857AbcIYInk (ORCPT ); Sun, 25 Sep 2016 04:43:40 -0400 Received: by mail-pf0-f176.google.com with SMTP id s13so21093669pfd.2 for ; Sun, 25 Sep 2016 01:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=vismCQvgc4L2hp7hCt1byKLfLOzCOdEPkPSEa089U+c=; b=iHXCcgGnE2sGDG4pVo/cLhHfRXZAYuH9Lvnz2nSdAeQfV6gIkoIoWaFZKf/u2BgjJD J6rxj2DpHE8tc8BdXowEYJss6HdFD+1wOtAuDpYdtkhaUL6z3wLVSWcb0kxKzUoGFKe3 xIAcVVazvPHiAhNVaPvB3rugQgjv4oJPWYDjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vismCQvgc4L2hp7hCt1byKLfLOzCOdEPkPSEa089U+c=; b=Mcv0XF69SX0byjPZleJwJMU8Y/1AzcXv9k8mbFEUhGiVIee+MDAZQbIJcWvtgSQL/Q tEKCTv/65lErku7FY0+/NPGjC1pqp9NcVvbTidS9tuNerbA0Yr5MiT2khcwqS2R5PbhE V+LRSBBPkl5H1YXtdCudQAgsfAPKRPdHYDP8b/gHC1hirOEc67szgz7hUC6vLOZcwsb9 feoFKxmNsvuQCsEUFMAQjgAkj00S85e1g70OKHIW+I4EmP6du9+3VAWnpWEpQKl9bANI SlhTiylGLJzpUZVH3XjI1VLDax2EGtenl1SPTRRHa5mom5o9/Sh9XyrVfO1wYDM2v7Cr ep3Q== X-Gm-Message-State: AE9vXwMCp1I+WAhbY8+GOKVG2WGc581L8WL+6iGz03HwNPw1KCiXEDledL47+AEeF6F08San X-Received: by 10.98.9.25 with SMTP id e25mr27933685pfd.143.1474793019498; Sun, 25 Sep 2016 01:43:39 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.164]) by smtp.gmail.com with ESMTPSA id u64sm22722669pfi.0.2016.09.25.01.43.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 25 Sep 2016 01:43:38 -0700 (PDT) From: Baoyou Xie To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, oded.gabbay@gmail.com, David1.Zhou@amd.com, Monk.Liu@amd.com, Rex.Zhu@amd.com, JinHuiEric.Huang@amd.com, Flora.Cui@amd.com, Jammy.Zhou@amd.com, lukas@wunner.de, mario.kleiner.de@gmail.com, nils.wallmenius@gmail.com, Emily.Deng@amd.com, cpaul@redhat.com, arindam.nath@amd.com, tom.stdenis@amd.com, nicolai.haehnle@amd.com, Qingqing.Wang@amd.com, samuel.li@amd.com, ray.huang@amd.com, michel.daenzer@amd.com, daniel.vetter@ffwll.ch, gustavo.padovan@collabora.co.uk, eric.engestrom@imgtec.com, vitaly.prosyak@amd.com, alexandre.f.demers@gmail.com, Jerry.Zhang@amd.com, seanpaul@chromium.org, yamada.masahiro@socionext.com, maruthi.bayyavarapu@amd.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 1/4] drm/amdgpu: add missing header dependencies Date: Sun, 25 Sep 2016 16:43:13 +0800 Message-Id: <1474792996-22998-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get a few warnings when building kernel with W=1: drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:629:6: warning: no previous prototype for 'dce_v8_0_disable_dce' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:730:6: warning: no previous prototype for 'dce_v10_0_disable_dce' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/dce_v11_0.c:699:6: warning: no previous prototype for 'dce_v11_0_disable_dce' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:40:5: warning: no previous prototype for 'amdgpu_gfx_scratch_get' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:62:6: warning: no previous prototype for 'amdgpu_gfx_scratch_free' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:84:6: warning: no previous prototype for 'amdgpu_gfx_parse_disable_cu' [-Wmissing-prototypes] .... In fact, these functions are declared in drivers/gpu/drm/amd/amdgpu/atombios_crtc.h, drivers/gpu/drm/amd/amdgpu/dce_v8_0.h drivers/gpu/drm/amd/amdgpu/dce_v10_0.h drivers/gpu/drm/amd/amdgpu/dce_v11_0.h drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h, so this patch adds missing header dependencies. by the way, we amend the declaration of amdgpu_gfx_parse_disable_cu(). Signed-off-by: Baoyou Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 ++- drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 + 6 files changed, 7 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c index a074edd..01a42b6 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c @@ -24,6 +24,7 @@ */ #include #include "amdgpu.h" +#include "amdgpu_gfx.h" /* * GPU scratch registers helpers function. diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h index 51321e1..abd9432 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h @@ -27,6 +27,7 @@ int amdgpu_gfx_scratch_get(struct amdgpu_device *adev, uint32_t *reg); void amdgpu_gfx_scratch_free(struct amdgpu_device *adev, uint32_t reg); -unsigned amdgpu_gfx_parse_disable_cu(unsigned *mask, unsigned max_se, unsigned max_sh); +void amdgpu_gfx_parse_disable_cu(unsigned int *mask, unsigned int max_se, + unsigned int max_sh); #endif diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c index f7d236f..4853ae0 100644 --- a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c +++ b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c @@ -30,6 +30,7 @@ #include "amdgpu.h" #include "atom.h" #include "atom-bits.h" +#include "atombios_crtc.h" #include "atombios_encoders.h" #include "amdgpu_atombios.h" #include "amdgpu_pll.h" diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c index bc5bb4e..d3925a5 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c @@ -32,6 +32,7 @@ #include "amdgpu_pll.h" #include "amdgpu_connectors.h" +#include "dce_v10_0.h" #include "dce/dce_10_0_d.h" #include "dce/dce_10_0_sh_mask.h" #include "dce/dce_10_0_enum.h" diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c index b93eba0..1002113 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c @@ -32,6 +32,7 @@ #include "amdgpu_pll.h" #include "amdgpu_connectors.h" +#include "dce_v11_0.h" #include "dce/dce_11_0_d.h" #include "dce/dce_11_0_sh_mask.h" #include "dce/dce_11_0_enum.h" diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c index abd5213..686c50d 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c @@ -32,6 +32,7 @@ #include "amdgpu_pll.h" #include "amdgpu_connectors.h" +#include "dce_v8_0.h" #include "dce/dce_8_0_d.h" #include "dce/dce_8_0_sh_mask.h"