From patchwork Sun Sep 25 09:16:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76972 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp652021qgf; Sun, 25 Sep 2016 02:17:11 -0700 (PDT) X-Received: by 10.98.13.73 with SMTP id v70mr27785926pfi.149.1474795031656; Sun, 25 Sep 2016 02:17:11 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dc7si18470265pad.277.2016.09.25.02.17.10; Sun, 25 Sep 2016 02:17:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965755AbcIYJRC (ORCPT + 27 others); Sun, 25 Sep 2016 05:17:02 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:33872 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbcIYJRA (ORCPT ); Sun, 25 Sep 2016 05:17:00 -0400 Received: by mail-pf0-f180.google.com with SMTP id l25so7451801pfb.1 for ; Sun, 25 Sep 2016 02:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=P4W/vi31Z5wIwOW5bjb9r6lAERTyEUyXYbrgp768huQ=; b=TF7f/1qxBqzqPyvJKEoLGk9afbQBhvOwNcM5gj98TGaCxnkU6eWnfhZ6aVp0UF+M1i Wf6GAubk3BEzKuEAeP8N7jGVm02rmbikaSLFCa0igMtX4LAPMCvqhw4pemOeaVLBb0t6 5k9Od/JyyVSgLffTibvQukhYtZOK9sfKZM2QM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=P4W/vi31Z5wIwOW5bjb9r6lAERTyEUyXYbrgp768huQ=; b=WdF1btvw/rSkL3UeM9RIPtvwjKMlMd+QNaHEUiImxE8PDDcafmJpj/7SslUzTtfHKI Ce/0mpezMv+Kg8HSDwG6DwT9wTwohhaE74rKVc3U0Zn+QxYHS/FxUVXn3gTZWqzemGfs 2Ff35ARffLiLVV6w5u6zvZB9bkElj2ekDdfIzenF6QcwkfLfX28r4Y6CFMYWmkS1LOqw HP3vkv3kb3CLxuzpVeUSHjCQIsO2TvqN0YFeJ9ovyWU05tt0bzZHBdMLUtGcRaEydNFV gLH7F1jIPhioGvPRgwDq/9n3d/sObq+SK2RDtan0dWDF+ONuPertfA7E/bmOtIq4l689 zZNA== X-Gm-Message-State: AE9vXwPyIQS4oRDEpRbstAh0VwRlThakMBNGWDYizjXL6gvVVPD/okXgPo38wQ/SFNuf/Ogu X-Received: by 10.98.148.2 with SMTP id m2mr28269530pfe.129.1474795019330; Sun, 25 Sep 2016 02:16:59 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.164]) by smtp.gmail.com with ESMTPSA id cu2sm22874355pad.18.2016.09.25.02.16.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 25 Sep 2016 02:16:58 -0700 (PDT) From: Baoyou Xie To: yisen.zhuang@huawei.com, salil.mehta@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH] net: hisilicon: mark symbols static where possible Date: Sun, 25 Sep 2016 17:16:44 +0800 Message-Id: <1474795004-8743-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes] drivers/net/ethernet/hisilicon/hisi_femac.c:960:5: warning: no previous prototype for 'hisi_femac_drv_resume' [-Wmissing-prototypes] In fact, these two functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/net/ethernet/hisilicon/hisi_femac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c index ca68e22..ced1859 100644 --- a/drivers/net/ethernet/hisilicon/hisi_femac.c +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c @@ -940,8 +940,8 @@ static int hisi_femac_drv_remove(struct platform_device *pdev) } #ifdef CONFIG_PM -int hisi_femac_drv_suspend(struct platform_device *pdev, - pm_message_t state) +static int hisi_femac_drv_suspend(struct platform_device *pdev, + pm_message_t state) { struct net_device *ndev = platform_get_drvdata(pdev); struct hisi_femac_priv *priv = netdev_priv(ndev); @@ -957,7 +957,7 @@ int hisi_femac_drv_suspend(struct platform_device *pdev, return 0; } -int hisi_femac_drv_resume(struct platform_device *pdev) +static int hisi_femac_drv_resume(struct platform_device *pdev) { struct net_device *ndev = platform_get_drvdata(pdev); struct hisi_femac_priv *priv = netdev_priv(ndev);